* [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY
@ 2023-01-16 11:51 Konrad Dybcio
2023-01-16 11:56 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Konrad Dybcio @ 2023-01-16 11:51 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Jonathan Marek, dri-devel,
freedreno, devicetree, linux-kernel
On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm
or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line,
which is voted for in the DSI ctrl node.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
index 9c9184f94c44..8e9031bbde73 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
@@ -48,7 +48,6 @@ required:
- compatible
- reg
- reg-names
- - vdds-supply
unevaluatedProperties: false
--
2.39.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY
2023-01-16 11:51 [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY Konrad Dybcio
@ 2023-01-16 11:56 ` Krzysztof Kozlowski
2023-01-16 12:52 ` Dmitry Baryshkov
2023-01-18 2:06 ` Dmitry Baryshkov
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-16 11:56 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Jonathan Marek, dri-devel, freedreno,
devicetree, linux-kernel
On 16/01/2023 12:51, Konrad Dybcio wrote:
> On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm
> or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line,
> which is voted for in the DSI ctrl node.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY
2023-01-16 11:51 [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY Konrad Dybcio
2023-01-16 11:56 ` Krzysztof Kozlowski
@ 2023-01-16 12:52 ` Dmitry Baryshkov
2023-01-16 14:18 ` Konrad Dybcio
2023-01-18 2:06 ` Dmitry Baryshkov
2 siblings, 1 reply; 5+ messages in thread
From: Dmitry Baryshkov @ 2023-01-16 12:52 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-arm-msm, andersson, agross, krzysztof.kozlowski,
marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul, David Airlie,
Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Jonathan Marek,
dri-devel, freedreno, devicetree, linux-kernel
On Mon, 16 Jan 2023 at 13:51, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm
> or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line,
> which is voted for in the DSI ctrl node.
I think we should have an explicit `if compatible then required:
vdds-supply' clause. WDYT?
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
> index 9c9184f94c44..8e9031bbde73 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
> @@ -48,7 +48,6 @@ required:
> - compatible
> - reg
> - reg-names
> - - vdds-supply
>
> unevaluatedProperties: false
>
> --
> 2.39.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY
2023-01-16 12:52 ` Dmitry Baryshkov
@ 2023-01-16 14:18 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2023-01-16 14:18 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: linux-arm-msm, andersson, agross, krzysztof.kozlowski,
marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul, David Airlie,
Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Jonathan Marek,
dri-devel, freedreno, devicetree, linux-kernel
On 16.01.2023 13:52, Dmitry Baryshkov wrote:
> On Mon, 16 Jan 2023 at 13:51, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm
>> or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line,
>> which is voted for in the DSI ctrl node.
>
> I think we should have an explicit `if compatible then required:
> vdds-supply' clause. WDYT?
Well, the driver will still probe and function without it,
so I'm not sure if it's strictly required..
Konrad
>
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
>> index 9c9184f94c44..8e9031bbde73 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml
>> @@ -48,7 +48,6 @@ required:
>> - compatible
>> - reg
>> - reg-names
>> - - vdds-supply
>>
>> unevaluatedProperties: false
>>
>> --
>> 2.39.0
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY
2023-01-16 11:51 [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY Konrad Dybcio
2023-01-16 11:56 ` Krzysztof Kozlowski
2023-01-16 12:52 ` Dmitry Baryshkov
@ 2023-01-18 2:06 ` Dmitry Baryshkov
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2023-01-18 2:06 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski,
Konrad Dybcio
Cc: marijn.suijten, Rob Clark, Abhinav Kumar, Sean Paul, David Airlie,
Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Jonathan Marek,
dri-devel, freedreno, devicetree, linux-kernel
On Mon, 16 Jan 2023 12:51:32 +0100, Konrad Dybcio wrote:
> On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm
> or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line,
> which is voted for in the DSI ctrl node.
>
>
Applied, thanks!
[1/1] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY
https://gitlab.freedesktop.org/lumag/msm/-/commit/4ff00ebb193a
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-18 2:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-16 11:51 [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY Konrad Dybcio
2023-01-16 11:56 ` Krzysztof Kozlowski
2023-01-16 12:52 ` Dmitry Baryshkov
2023-01-16 14:18 ` Konrad Dybcio
2023-01-18 2:06 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).