From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, catalin.marinas@arm.com
Cc: geert+renesas@glider.be, arnd@arndb.de,
neil.armstrong@linaro.org, nfraprado@collabora.com,
rafal@milecki.pl, peng.fan@nxp.com,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, quic_tsoni@quicinc.com,
quic_shashim@quicinc.com, quic_kaushalk@quicinc.com,
quic_tdas@quicinc.com, quic_tingweiz@quicinc.com,
quic_aiquny@quicinc.com, kernel@quicinc.com
Subject: Re: [PATCH v2 4/8] dt-bindings: arm-smmu: Add compatible for SM4450 SoC
Date: Fri, 15 Sep 2023 11:10:57 +0200 [thread overview]
Message-ID: <e026878f-9303-4cae-bcab-7ee69e32db2d@linaro.org> (raw)
In-Reply-To: <2c42d2b6-a838-4d8e-99f1-c08b0c8e4457@quicinc.com>
On 15/09/2023 09:15, Tengfei Fan wrote:
>
>
> 在 9/15/2023 3:11 PM, Krzysztof Kozlowski 写道:
>> On 15/09/2023 04:15, Tengfei Fan wrote:
>>> Add the SoC specific compatible for SM4450 implementing arm,mmu-500.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>> index cf29ab10501c..b57751c8ad90 100644
>>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>> @@ -47,6 +47,7 @@ properties:
>>> - qcom,sdx55-smmu-500
>>> - qcom,sdx65-smmu-500
>>> - qcom,sdx75-smmu-500
>>> + - qcom,sm4450-smmu-500
>>> - qcom,sm6115-smmu-500
>>> - qcom,sm6125-smmu-500
>>> - qcom,sm6350-smmu-500
>>> @@ -70,6 +71,7 @@ properties:
>>> - qcom,sc8180x-smmu-500
>>> - qcom,sc8280xp-smmu-500
>>> - qcom,sdm845-smmu-500
>>> + - qcom,sm4450-smmu-500
>>
>> Isn't there comment just few lines above your edit? Comment saying DON'T?
> yes, I saw this "DON'T" comment, but if I remove "qcom,sm4450-smmu-500"
> from sm4450.dtsi and this arm,smmu.yaml, will get DT check warning about
Why would you remove it?
> this, this warning cannot be find after add "qcom,sm4450-smmu-500" from
> sm4450.dtsi and this arm,smmu.yaml, so update this patch again.
What does the comment say? Why are you adding it to the enum which asks
- do not add to this enum, but add to other above and below?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-15 9:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 2:15 [PATCH v2 0/8] soc: qcom: Add uart console support for SM4450 Tengfei Fan
2023-09-15 2:15 ` [PATCH v2 1/8] dt-bindings: firmware: document Qualcomm SM4450 SCM Tengfei Fan
2023-09-15 2:15 ` [PATCH v2 4/8] dt-bindings: arm-smmu: Add compatible for SM4450 SoC Tengfei Fan
2023-09-15 7:11 ` Krzysztof Kozlowski
2023-09-15 7:15 ` Tengfei Fan
2023-09-15 9:10 ` Krzysztof Kozlowski [this message]
2023-09-15 8:52 ` Tengfei Fan
2023-09-15 9:10 ` Krzysztof Kozlowski
2023-09-15 2:15 ` [PATCH v2 2/8] dt-bindings: mfd: qcom,tcsr: Add compatible for sm4450 Tengfei Fan
2023-09-15 2:15 ` [PATCH v2 3/8] dt-bindings: interrupt-controller: qcom,pdc: document qcom,sm4450-pdc Tengfei Fan
2023-09-15 2:15 ` [PATCH v2 4/8] dt-bindings: arm-smmu: Add compatible for SM4450 SoC Tengfei Fan
2023-09-15 7:12 ` Krzysztof Kozlowski
2023-09-15 2:15 ` [PATCH v2 5/8] arm64: dts: qcom: sm4450: Add apps_rsc and cmd_db node Tengfei Fan
2023-09-20 3:49 ` Bjorn Andersson
2023-09-22 1:16 ` Tengfei Fan
2023-09-15 2:15 ` [PATCH v2 6/8] arm64: dts: qcom: sm4450: Add RPMH and Global clock controller Tengfei Fan
2023-09-15 7:22 ` Krzysztof Kozlowski
2023-09-18 10:34 ` Tengfei Fan
2023-09-18 11:54 ` Krzysztof Kozlowski
2023-09-15 2:15 ` [PATCH v2 7/8] arm64: dts: qcom: add uart console support for SM4450 Tengfei Fan
2023-09-15 7:14 ` Krzysztof Kozlowski
2023-09-15 12:12 ` Konrad Dybcio
2023-09-18 10:40 ` Tengfei Fan
2023-09-20 3:47 ` Bjorn Andersson
2023-09-20 5:46 ` Tengfei Fan
2023-09-15 2:15 ` [PATCH v2 8/8] arm64: defconfig: enable interconnect and pinctrl " Tengfei Fan
2023-09-15 7:21 ` Krzysztof Kozlowski
2023-09-15 9:12 ` Tengfei Fan
2023-09-15 9:16 ` Krzysztof Kozlowski
2023-09-15 11:18 ` Tengfei Fan
2023-09-15 11:29 ` Krzysztof Kozlowski
2023-09-16 2:21 ` Trilok Soni
2023-09-16 2:25 ` Trilok Soni
2023-09-16 15:13 ` Georgi Djakov
2023-09-16 20:32 ` Krzysztof Kozlowski
2023-09-16 22:55 ` Georgi Djakov
2023-09-17 7:35 ` Krzysztof Kozlowski
2023-09-18 0:53 ` Tengfei Fan
2023-09-16 20:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e026878f-9303-4cae-bcab-7ee69e32db2d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=peng.fan@nxp.com \
--cc=quic_aiquny@quicinc.com \
--cc=quic_kaushalk@quicinc.com \
--cc=quic_shashim@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_tengfan@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).