From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
rafael@kernel.org, daniel.lezcano@linaro.org, nm@ti.com,
sboyd@kernel.org, mka@chromium.org, dianders@chromium.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 3/4] OPP: Add support of "opp-microwatt" for advanced EM registration
Date: Wed, 2 Mar 2022 08:50:06 +0000 [thread overview]
Message-ID: <e02d9113-d1ae-c029-750f-aece1cefab2d@arm.com> (raw)
In-Reply-To: <20220302074515.dqzoutfiobildiph@vireshk-i7>
On 3/2/22 07:45, Viresh Kumar wrote:
> On 01-03-22, 09:35, Lukasz Luba wrote:
>> /**
>> * dev_pm_opp_of_register_em() - Attempt to register an Energy Model
>> * @dev : Device for which an Energy Model has to be registered
>> @@ -1517,6 +1567,12 @@ int dev_pm_opp_of_register_em(struct device *dev, struct cpumask *cpus)
>> goto failed;
>> }
>>
>> + /* First, try to find more precised Energy Model in DT */
>> + if (_of_has_opp_microwatt_property(dev)) {
>> + em_cb.active_power = _get_dt_power;
>
> You can also do (to fix the warning) this instead:
>
> em_cb = EM_DATA_CB(_get_dt_power);
>
> Similar for the else part.
>
Unfortunately, not for this case. When we declare that em_cb
it can handle the brackets '{ }', but not later in the code no.
In both configs it won't fly:
EM:
drivers/opp/of.c: In function ‘dev_pm_opp_of_register_em’:
./include/linux/energy_model.h:118:38: error: expected expression before
‘{’ token
#define EM_DATA_CB(_active_power_cb) { .active_power = &_active_power_cb }
^
drivers/opp/of.c:1573:11: note: in expansion of macro ‘EM_DATA_CB’
em_cb = EM_DATA_CB(_get_dt_power);
^~~~~~~~~~
./include/linux/energy_model.h:118:38: error: expected expression before
‘{’ token
#define EM_DATA_CB(_active_power_cb) { .active_power = &_active_power_cb }
^
drivers/opp/of.c:1600:10: note: in expansion of macro ‘EM_DATA_CB’
em_cb = EM_DATA_CB(_get_power);
^~~~~~~~~~
!EM:
drivers/opp/of.c: In function ‘dev_pm_opp_of_register_em’:
./include/linux/energy_model.h:266:38: error: expected expression before
‘{’ token
#define EM_DATA_CB(_active_power_cb) { }
^
drivers/opp/of.c:1573:11: note: in expansion of macro ‘EM_DATA_CB’
em_cb = EM_DATA_CB(_get_dt_power);
^~~~~~~~~~
./include/linux/energy_model.h:266:38: error: expected expression before
‘{’ token
#define EM_DATA_CB(_active_power_cb) { }
^
drivers/opp/of.c:1600:10: note: in expansion of macro ‘EM_DATA_CB’
em_cb = EM_DATA_CB(_get_power);
^~~~~~~~~~
If you like, I can introduce new dual-macro implementation
in energy_modle.h which would sole this issue:
ifdef EM:
#define EM_SET_ACTIVE_POWER_CB(em_cb, cb) ((em_cb).active_power = cb)
ifndef EM:
#define EM_SET_ACTIVE_POWER_CB(em_cb, cb) do { } while (0)
Then we would keep the single call to the registration EM and
we would have:
if (_of_has_opp_microwatt_property(dev)) {
EM_SET_ACTIVE_POWER_CB(em_cb, _get_dt_power);
goto register_em;
}
EM_SET_ACTIVE_POWER_CB(em_cb, _get_power);
register_em:
ret = em_dev_register_perf_domain(dev, nr_opp, &em_cb, cpus, true);
I can do that, please let me know.
next prev parent reply other threads:[~2022-03-02 8:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 9:35 [PATCH v4 0/4] Introduce "opp-microwatt" and Energy Model from DT Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 1/4] dt-bindings: opp: Add "opp-microwatt" entry in the OPP Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 2/4] OPP: Add "opp-microwatt" supporting code Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 3/4] OPP: Add support of "opp-microwatt" for advanced EM registration Lukasz Luba
2022-03-01 16:58 ` kernel test robot
2022-03-01 17:53 ` Lukasz Luba
2022-03-02 4:53 ` Viresh Kumar
2022-03-02 7:01 ` Lukasz Luba
2022-03-02 7:45 ` Viresh Kumar
2022-03-02 8:50 ` Lukasz Luba [this message]
2022-03-02 9:30 ` Viresh Kumar
2022-03-02 9:37 ` Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 4/4] Documentation: EM: Describe new registration method using DT Lukasz Luba
2022-03-02 4:53 ` [PATCH v4 0/4] Introduce "opp-microwatt" and Energy Model from DT Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e02d9113-d1ae-c029-750f-aece1cefab2d@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox