Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Rakesh Kota <rakesh.kota@oss.qualcomm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Ulf Hansson <ulfh@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	kamal.wadhwa@oss.qualcomm.com, jishnu.prakash@oss.qualcomm.com
Subject: Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains
Date: Tue, 12 May 2026 14:16:07 +0200	[thread overview]
Message-ID: <e032c072-57b3-44b4-84a7-5aff062b9c00@oss.qualcomm.com> (raw)
In-Reply-To: <20260429-add_rpmpd_shikra-v1-2-fdba28564380@oss.qualcomm.com>

On 4/29/26 4:09 PM, Rakesh Kota wrote:
> Add RPM Power Domains support for the Shikra platform.
> 
> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> ---
>  drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
> index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644
> --- a/drivers/pmdomain/qcom/rpmpd.c
> +++ b/drivers/pmdomain/qcom/rpmpd.c
> @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = {
>  	.max_state = RPM_SMD_LEVEL_TURBO,
>  };
>  
> +static struct rpmpd *shikra_rpmpds[] = {
> +	[RPMPD_VDDCX] =		&cx_rwcx0_lvl,
> +	[RPMPD_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
> +	[RPMPD_VDDCX_VFL] =	&cx_rwcx0_vfl,
> +	[RPMPD_VDDMX] =		&mx_rwmx0_lvl,
> +	[RPMPD_VDDMX_AO] =	&mx_rwmx0_lvl_ao,
> +	[RPMPD_VDDMX_VFL] =	&mx_rwmx0_vfl,
> +};

This is identical to sm6125_rpmpds. If you're sure the list is correct
and complete (no LPI domains etc.), you can drop this patch, and proceed
with just this change:

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index 0bf1e13a9964..e7d9e8e65641 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -73,6 +73,10 @@ properties:
           - enum:
               - qcom,msm8937-rpmpd
           - const: qcom,msm8917-rpmpd
+      - items:
+          - enum:
+              - qcom,shikra-rpmpd
+          - const: qcom,sm6125-rpmpd
 
   '#power-domain-cells':
     const: 1


Konrad

      reply	other threads:[~2026-05-12 12:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 14:09 [PATCH 0/2] power: qcom,rpmpd: Add support for Shikra Rakesh Kota
2026-04-29 14:09 ` [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document the Shikra RPM Power Domains Rakesh Kota
2026-05-03 14:34   ` Krzysztof Kozlowski
2026-04-29 14:09 ` [PATCH 2/2] soc: qcom: rpmpd: Add " Rakesh Kota
2026-05-12 12:16   ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e032c072-57b3-44b4-84a7-5aff062b9c00@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rakesh.kota@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox