From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: forbidden405@outlook.com, Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v4 1/6] dt-bindings: net: hisilicon-femac-mdio: convert to YAML
Date: Thu, 22 Feb 2024 19:14:51 +0100 [thread overview]
Message-ID: <e053448f-2b58-408a-af22-d7b464c52781@linaro.org> (raw)
In-Reply-To: <20240222-net-v4-1-eea68f93f090@outlook.com>
On 22/02/2024 13:43, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
>
> For some FEMAC cores, MDIO bus is integrated to the MAC controller. So
> We don't have a dedicated MDIO bus clock.
Hm, this means you miss compatibles for these different cores.
>
> Also due to the PHY reset procedure, it's required to manage all clocks
> and resets in the MAC controller driver. MAC controller clock can not be
> shared with MDIO bus node in dts.
>
> Mark the clock optional to resolve this problem.
I don't understand how making clock optional solves this problem. Clock
is still there. Whether driver handles it, does not affect the binding.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-22 18:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 12:43 [PATCH net-next v4 0/6] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles Yang Xiwen via B4 Relay
2024-02-22 12:43 ` [PATCH net-next v4 1/6] dt-bindings: net: hisilicon-femac-mdio: convert to YAML Yang Xiwen via B4 Relay
2024-02-22 18:14 ` Krzysztof Kozlowski [this message]
2024-02-22 18:19 ` Yang Xiwen
2024-02-24 10:01 ` Krzysztof Kozlowski
2024-02-24 12:01 ` Yang Xiwen
2024-02-22 12:43 ` [PATCH net-next v4 2/6] net: mdio: hisi-femac: make clock optional Yang Xiwen via B4 Relay
2024-02-22 12:43 ` [PATCH net-next v4 3/6] dt-bindings: net: remove outdated hisilicon-femac Yang Xiwen via B4 Relay
2024-02-26 7:50 ` Krzysztof Kozlowski
2024-02-27 1:43 ` Yang Xiwen
2024-02-27 6:51 ` Krzysztof Kozlowski
2024-02-22 12:43 ` [PATCH net-next v4 4/6] dt-bindings: net: add hisilicon,hisi-femac Yang Xiwen via B4 Relay
2024-02-26 7:53 ` Krzysztof Kozlowski
2024-02-22 12:43 ` [PATCH net-next v4 5/6] net: hisilicon: add support for hisi_femac core on Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-26 7:54 ` Krzysztof Kozlowski
2024-02-22 12:43 ` [PATCH net-next v4 6/6] net: hisi_femac: remove unused compatible strings Yang Xiwen via B4 Relay
2024-02-26 7:55 ` Krzysztof Kozlowski
2024-02-27 1:51 ` Yang Xiwen
2024-02-27 6:53 ` Krzysztof Kozlowski
2024-02-27 7:36 ` Yang Xiwen
2024-02-27 7:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e053448f-2b58-408a-af22-d7b464c52781@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=forbidden405@outlook.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).