From: skakit@codeaurora.org
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
gregkh@linuxfoundation.org, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, akashast@codeaurora.org,
rojay@codeaurora.org, msavaliy@qti.qualcomm.com
Subject: Re: [PATCH V3 1/3] arm64: dts: sc7180: Add wakeup support over UART RX
Date: Wed, 02 Sep 2020 18:39:41 +0530 [thread overview]
Message-ID: <e073ccd4fe47ab7e1a61fb201c9f5d84@codeaurora.org> (raw)
Hi Matthias,
On 2020-08-21 21:56, Matthias Kaehlcke wrote:
> On Thu, Aug 20, 2020 at 07:21:05PM +0530, satya priya wrote:
>> Add the necessary pinctrl and interrupts to make UART
>> wakeup capable.
>>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> Reviewed-by: Akash Asthana <akashast@codeaurora.org>
>> ---
>> Changes in V2:
>> - As per Matthias's comment added wakeup support for all the UARTs
>> of SC7180.
>>
>> Changes in V3:
>> - No change.
>>
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 98
>> ++++++++++++++++++++++++++++++------
>> 1 file changed, 84 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index d46b383..855b13e 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>>
>> ...
>>
>> + qup_uart0_sleep: qup-uart0-sleep {
>> + pinmux {
>> + pins = "gpio34", "gpio35",
>> + "gpio36", "gpio37";
>> + function = "gpio";
>
> What is the reason that the GPIO function needs to be selected in sleep
> mode
> to support wakeup?
>
> This should be explained in the commit message unless it is evident.
When QUP function is selected in sleep state, RTS/RFR is pulled high as
soon as we enter suspend and not receiving wakeup bytes from BT SoC to
wakeup device. Whereas in GPIO mode it is staying low and receiving
data.
Thanks,
Satya Priya
next reply other threads:[~2020-09-02 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 13:09 skakit [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-20 13:51 [PATCH V3 0/3] Add wakeup support over UART RX satya priya
2020-08-20 13:51 ` [PATCH V3 1/3] arm64: dts: sc7180: " satya priya
2020-08-21 16:26 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e073ccd4fe47ab7e1a61fb201c9f5d84@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).