public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Nickolay Goppen <setotau@mainlining.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: sdm630: assign adsp_mem region to ADSP FastRPC node
Date: Thu, 23 Apr 2026 16:06:05 +0300	[thread overview]
Message-ID: <e0c2c127-9f27-4d8e-802f-bdf1acfa960c@mainlining.org> (raw)
In-Reply-To: <0d411167-caad-4f6e-b52b-de7caeaf2333@oss.qualcomm.com>


23.04.2026 14:05, Konrad Dybcio пишет:
> On 4/22/26 5:39 PM, Nickolay Goppen wrote:
>> Downstream [1] ADSP FastRPC node has the adsp_mem region assigned, so
>> assign it to the ADSP FastRPC node.
>>
>> [1]: https://github.com/xiaomi-sdm660/android_kernel_xiaomi_sdm660/blob/11-EAS/arch/arm/boot/dts/qcom/sdm660.dtsi#L1693
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> index 36b419dea153..af2bc29ccdad 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>> @@ -2458,6 +2458,9 @@ fastrpc {
>>   					compatible = "qcom,fastrpc";
>>   					qcom,glink-channels = "fastrpcglink-apps-dsp";
>>   					label = "adsp";
>> +					memory-region = <&adsp_mem>;
>> +					qcom,vmids = <QCOM_SCM_VMID_LPASS
>> +						      QCOM_SCM_VMID_ADSP_HEAP>;
> Please double-check that, the VMID used to be different on
> older SoCs
Do you know how to check that?
>
> Konrad

-- 
Best regards,
Nickolay


  reply	other threads:[~2026-04-23 13:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 15:39 [PATCH v3 0/4] arm64: dts: qcom: sdm630/660 FastRPC fixes Nickolay Goppen
2026-04-22 15:39 ` [PATCH v3 1/4] arm64: dts: qcom: sdm660: set cdsp compute-cbs' regs properly Nickolay Goppen
2026-04-22 15:39 ` [PATCH v3 2/4] arm64: dts: qcom: sdm630: set adsp " Nickolay Goppen
2026-04-22 15:39 ` [PATCH v3 3/4] arm64: dts: qcom: sdm630: describe adsp_mem region properly Nickolay Goppen
2026-04-22 15:52   ` Dmitry Baryshkov
2026-04-23  9:09   ` Ekansh Gupta
2026-04-27 11:49   ` Konrad Dybcio
2026-04-27 12:00     ` Nickolay Goppen
2026-04-27 12:08       ` Konrad Dybcio
2026-04-27 12:28         ` Nickolay Goppen
2026-04-27 15:20     ` Nickolay Goppen
2026-04-27 15:28       ` Alexey Minnekhanov
2026-04-22 15:39 ` [PATCH v3 4/4] arm64: dts: qcom: sdm630: assign adsp_mem region to ADSP FastRPC node Nickolay Goppen
2026-04-23  9:09   ` Ekansh Gupta
2026-04-23 11:05   ` Konrad Dybcio
2026-04-23 13:06     ` Nickolay Goppen [this message]
2026-04-23 13:08       ` Konrad Dybcio
2026-04-23 13:48         ` Nickolay Goppen
2026-04-23 14:39           ` Ekansh Gupta
2026-04-23 15:00             ` Nickolay Goppen
2026-04-24 10:01               ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0c2c127-9f27-4d8e-802f-bdf1acfa960c@mainlining.org \
    --to=setotau@mainlining.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=ekansh.gupta@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox