From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED38927281D for ; Fri, 13 Jun 2025 08:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749804698; cv=none; b=Ss9ypA1rkaEpbgw4SwF5egsV8bIbnB/zS3a66Iwr5WtptpMLO6nn2uemccd+VHs9S1CosJ2J0sQ6PuvWsj1DyGOF0QrqJVeHix62kVukxFmM+oZY6JXjABFMlFKgdr7iBA54NawdE81c0nK6xNwcRsvZXt4OjpCkukXvqQss+rs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749804698; c=relaxed/simple; bh=2LkWo1Pa57dprSLts/t1XsvdW5eFeYAlkgw5SnmM4Bc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=tYyaxITjgp9VaNqngRVJMnbo7QpCuTYNZZU1NMdfHk2QACkEB5V4PAmLACzf/W04CagL36hv+2OSxqgsd235CVcMs12xf8Cjgrox2pjJXJLdC2sDYuILLi1u0diKhRCVVpO4e2N3hD92d+WdBlF1nJwqhX3GRdsdm/GnU5J5o8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LPlMESds; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LPlMESds" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a525eee2e3so1498797f8f.2 for ; Fri, 13 Jun 2025 01:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749804695; x=1750409495; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=4i/uycGc9IMJTkT+aPn3NiUgZauSdlLEx0uEl81rWwk=; b=LPlMESdsMb5tEXEtiZJanLz/dYF82YRJ7yqH8lDOGG4Nr362fVduMT9Ufw/29w7y+W Q/IwenJLX2+hNBhKbT3vWJei8A8dDtXrxUyfR0qhl7IpIcRuH0DrspfMz11O3GOYxlwa XXrJvz9P71e+BhYdAxwK+1sFK8tAI0HccCF5UM0Y1v4Ap2WJYHncdnPUKlMKF0GvFRqp BW4Sse9pf/zRF0MqOASB5VmVIzY8Jj6FXV4EmpeylY6vhXLjUUar7lDR15EhXAeQ8X2g iJ4SfZNs12m/62liREwZ9gzt/QVLZsElxs6tzi7LEBzCqbNyg2vWfuF+s8a6JMJxv5n7 vdTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749804695; x=1750409495; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4i/uycGc9IMJTkT+aPn3NiUgZauSdlLEx0uEl81rWwk=; b=hf4SXa48o6EzaX8As2oHY49Jk9pvldcCWwskJuuOv1MMcHBnggl9fiqbVHroYVt82N RK2C4BpyooGsi5bNvD2Ir6iZyD8r+xoTC3KUl1gyY5GXD5JwAhiN51aNNgHKKzXgmNwV Kd8cs8REjVrh7Z/cZwN6TOCqIsY+KIIZtWDVSrkAqmzkyhDVHvH5Z9i/SaNNP2f+3eY2 wqKTDLrMA6Oxdwo6TlzIy/QDg9hWjF/W/NiVxikDCuS0tnG5916C4h46ZONJiI2SMNjE +LY6jf7m8/VaQq4W7Ya9ceLKFYc+Vf4bfGwUSlIPcLb1tIs5p4/q3W/yOYUHcWThNR1k CabQ== X-Forwarded-Encrypted: i=1; AJvYcCXfRSe9XlCwid9LKd1Oxuj3HpbYOrTOX0jn2B8RwVs4b42kDlObS6nPGWS5Fkc83dV1GuqNzgW1jWyp@vger.kernel.org X-Gm-Message-State: AOJu0Yxosv0Bezy1l95mFaOca9wSQjJoCGLrRLCysT4DXw4U6GBXvI8V +QHC6R4QpIxQJG34Hrey4hbob1R6hBxx5bZ7TMbcRb/sHCqwfPuAslGwIqH28H2HB4I= X-Gm-Gg: ASbGnctxa75Cmrm5XN2Dd/rfmh58gd9d/6L0TLFzjgCq7PULqkTGqnKBBNxsV9HcYpR nimBtCvoC5s65H/QEBBwxnZ0x5v188Ixg6V7WJRpAc1RhKT7mrH4G88+MN0wnbZGAJe5oUpXwec t8U+AQSTEnkWqiN3PkRQESTUBLejY7zw/RLbuUkm0hbfGp0xHMknRahieb1WwR9lzBQt/bCDgGE 1Xsu8NbRpxe4N3mS+4fvqemIUcVtRw0KJVCA5fZTpgQLLeTLvYCo1p8xXZh6SgJoe2Xa/SG4tdZ npMQKPIFmg5AAxss4w21vrvWyF63geBrkl7GXHOsX4bN6NiGRmR2c9USLhjRviEIil1wfJ/ydtF ORWluq/htlxt14oyqpSn0+4vuJ8ciX3C5fIMfY2c= X-Google-Smtp-Source: AGHT+IEUAqqXCa6QukFfprZqmstdAPX/2X+IrxwAqf6HoHLLDv2NyKBWx+d7mBvUd0+CFYb9GJHC/Q== X-Received: by 2002:a05:6000:4313:b0:3a4:dc2a:924e with SMTP id ffacd0b85a97d-3a5686e4794mr1735144f8f.6.1749804694922; Fri, 13 Jun 2025 01:51:34 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:4144:6a84:fe1d:3aae? ([2a01:e0a:3d9:2080:4144:6a84:fe1d:3aae]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a54a63sm1721189f8f.11.2025.06.13.01.51.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 01:51:34 -0700 (PDT) Message-ID: Date: Fri, 13 Jun 2025 10:51:33 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v4 2/4] phy: rockchip: usbdp: move orientation handling further down To: Nicolas Frattaroli , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Frank Wang Cc: Alexey Charkov , Sebastian Reichel , kernel@collabora.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250610-rk3576-sige5-usb-v4-0-7e7f779619c1@collabora.com> <20250610-rk3576-sige5-usb-v4-2-7e7f779619c1@collabora.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250610-rk3576-sige5-usb-v4-2-7e7f779619c1@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/06/2025 16:07, Nicolas Frattaroli wrote: > The orientation handling code isn't referenced until very far down the > driver code. > > Move it down some ways so it can later reference other driver functions > without needing forward declarations. > > Signed-off-by: Nicolas Frattaroli > --- > drivers/phy/rockchip/phy-rockchip-usbdp.c | 100 +++++++++++++++--------------- > 1 file changed, 50 insertions(+), 50 deletions(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c > index c066cc0a7b4f10fc3cd8779323c369360893520d..fff54900feea601c8fe6bf4c7123dfebc5661a15 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -651,56 +651,6 @@ static void rk_udphy_set_typec_default_mapping(struct rk_udphy *udphy) > udphy->mode = UDPHY_MODE_DP_USB; > } > > -static int rk_udphy_orien_sw_set(struct typec_switch_dev *sw, > - enum typec_orientation orien) > -{ > - struct rk_udphy *udphy = typec_switch_get_drvdata(sw); > - > - mutex_lock(&udphy->mutex); > - > - if (orien == TYPEC_ORIENTATION_NONE) { > - gpiod_set_value_cansleep(udphy->sbu1_dc_gpio, 0); > - gpiod_set_value_cansleep(udphy->sbu2_dc_gpio, 0); > - /* unattached */ > - rk_udphy_usb_bvalid_enable(udphy, false); > - goto unlock_ret; > - } > - > - udphy->flip = (orien == TYPEC_ORIENTATION_REVERSE) ? true : false; > - rk_udphy_set_typec_default_mapping(udphy); > - rk_udphy_usb_bvalid_enable(udphy, true); > - > -unlock_ret: > - mutex_unlock(&udphy->mutex); > - return 0; > -} > - > -static void rk_udphy_orien_switch_unregister(void *data) > -{ > - struct rk_udphy *udphy = data; > - > - typec_switch_unregister(udphy->sw); > -} > - > -static int rk_udphy_setup_orien_switch(struct rk_udphy *udphy) > -{ > - struct typec_switch_desc sw_desc = { }; > - > - sw_desc.drvdata = udphy; > - sw_desc.fwnode = dev_fwnode(udphy->dev); > - sw_desc.set = rk_udphy_orien_sw_set; > - > - udphy->sw = typec_switch_register(udphy->dev, &sw_desc); > - if (IS_ERR(udphy->sw)) { > - dev_err(udphy->dev, "Error register typec orientation switch: %ld\n", > - PTR_ERR(udphy->sw)); > - return PTR_ERR(udphy->sw); > - } > - > - return devm_add_action_or_reset(udphy->dev, > - rk_udphy_orien_switch_unregister, udphy); > -} > - > static int rk_udphy_refclk_set(struct rk_udphy *udphy) > { > unsigned long rate; > @@ -1451,6 +1401,56 @@ static struct phy *rk_udphy_phy_xlate(struct device *dev, const struct of_phandl > return ERR_PTR(-EINVAL); > } > > +static int rk_udphy_orien_sw_set(struct typec_switch_dev *sw, > + enum typec_orientation orien) > +{ > + struct rk_udphy *udphy = typec_switch_get_drvdata(sw); > + > + mutex_lock(&udphy->mutex); > + > + if (orien == TYPEC_ORIENTATION_NONE) { > + gpiod_set_value_cansleep(udphy->sbu1_dc_gpio, 0); > + gpiod_set_value_cansleep(udphy->sbu2_dc_gpio, 0); > + /* unattached */ > + rk_udphy_usb_bvalid_enable(udphy, false); > + goto unlock_ret; > + } > + > + udphy->flip = (orien == TYPEC_ORIENTATION_REVERSE) ? true : false; > + rk_udphy_set_typec_default_mapping(udphy); > + rk_udphy_usb_bvalid_enable(udphy, true); > + > +unlock_ret: > + mutex_unlock(&udphy->mutex); > + return 0; > +} > + > +static void rk_udphy_orien_switch_unregister(void *data) > +{ > + struct rk_udphy *udphy = data; > + > + typec_switch_unregister(udphy->sw); > +} > + > +static int rk_udphy_setup_orien_switch(struct rk_udphy *udphy) > +{ > + struct typec_switch_desc sw_desc = { }; > + > + sw_desc.drvdata = udphy; > + sw_desc.fwnode = dev_fwnode(udphy->dev); > + sw_desc.set = rk_udphy_orien_sw_set; > + > + udphy->sw = typec_switch_register(udphy->dev, &sw_desc); > + if (IS_ERR(udphy->sw)) { > + dev_err(udphy->dev, "Error register typec orientation switch: %ld\n", > + PTR_ERR(udphy->sw)); > + return PTR_ERR(udphy->sw); > + } > + > + return devm_add_action_or_reset(udphy->dev, > + rk_udphy_orien_switch_unregister, udphy); > +} > + > static int rk_udphy_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > Reviewed-by: Neil Armstrong