public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Diederik de Haas <diederik@cknow-tech.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	kernel@collabora.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576
Date: Mon, 23 Feb 2026 20:29:23 +0200	[thread overview]
Message-ID: <e0d7da4c-e779-43e9-bf0f-c2a0224114df@collabora.com> (raw)
In-Reply-To: <aZyaLG0lYao6_xxb@venus>

Hi Sebastian,

On 2/23/26 8:21 PM, Sebastian Reichel wrote:
> Hi,
> 
> On Mon, Feb 23, 2026 at 07:07:42PM +0200, Cristian Ciocaltea wrote:
>> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> @@ -34,10 +34,12 @@ properties:
>>        - description: The cache configuration registers base
>>
>>    reg-names:
>> -    items:
>> +    oneOf:
>>        - const: function
>> -      - const: link
>> -      - const: cache
>> +      - items:
>> +          - const: link
>> +          - const: function
>> +          - const: cache
>>
>>    interrupts:
>>      maxItems: 1
>>
> 
> With that change the descriptions in the reg section are wrong.

Yeah, I assumed it'd be acceptable for the description to document just once all
possible items, to avoid repeating this for all possible combinations.

E.g. this is from Documentation/devicetree/bindings/net/snps,dwmac.yaml:

  resets:
    minItems: 1
    items:
      - description: GMAC stmmaceth reset
      - description: AHB reset

  reset-names:
    oneOf:
      - items:
          - enum: [stmmaceth, ahb]
      - items:
          - const: stmmaceth
          - const: ahb

Thanks,
Cristian


  reply	other threads:[~2026-02-23 18:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 12:25 [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576 Cristian Ciocaltea
2026-02-23 14:31 ` Sebastian Reichel
2026-02-23 14:39   ` Diederik de Haas
2026-02-23 17:07     ` Cristian Ciocaltea
2026-02-23 18:08       ` Nicolas Dufresne
2026-02-23 18:21       ` Sebastian Reichel
2026-02-23 18:29         ` Cristian Ciocaltea [this message]
2026-02-23 20:02           ` Cristian Ciocaltea
2026-02-23 14:51 ` Nicolas Dufresne
2026-02-23 17:19   ` Cristian Ciocaltea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0d7da4c-e779-43e9-bf0f-c2a0224114df@collabora.com \
    --to=cristian.ciocaltea@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=diederik@cknow-tech.com \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox