From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, - <devicetree@vger.kernel.org>,
linux-riscv@lists.infradead.org,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Tomer Maimon <tmaimon77@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Peter Korsgaard <jacmet@sunsite.dk>, Chester Lin <clin@suse.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-stm32@st-md-mailman.stormreply.com,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, Fugang Duan <fugang.duan@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Le Ray <erwan.leray@foss.st.com>,
Michal Simek <michal.simek@xilinx.com>,
Lubomir Rintel <lkundrak@v3.sk>,
Jerome Brunet <jbrunet@baylibre.com>,
Magnus Damm <magnus.damm@gmail.com>,
Pragnesh Patel <pragnesh.patel@sifive.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-amlogic@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 11/13] dt-bindings: serial: restrict possible child node names
Date: Tue, 24 Jan 2023 08:25:05 +0100 [thread overview]
Message-ID: <e0dd24e8-9d4b-ea23-d1de-190330c0e825@linaro.org> (raw)
In-Reply-To: <167451486467.2795286.1299932821783618559.robh@kernel.org>
On 24/01/2023 00:05, Rob Herring wrote:
>
> On Mon, 23 Jan 2023 16:13:00 +0100, Krzysztof Kozlowski wrote:
>> The re-usable serial.yaml schema matches every property with ".*"
>> pattern, thus any other schema referencing it will not report unknown
>> (unevaluated) properties. This hides several wrong properties. It is
>> a limitation of dtschema, thus provide a simple workaround: expect
>> children to be only of few names matching upstream usage (Bluetooth,
>> GNSS, GPS and MCU).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/intel,ixp4xx-expansion-bus-controller.example.dtb: serial@1,0: Unevaluated properties are not allowed ('intel,ixp4xx-eb-byte-access', 'intel,ixp4xx-eb-cycle-type', 'intel,ixp4xx-eb-t3', 'intel,ixp4xx-eb-write-enable' were unexpected)
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/8250.yaml
Did I just forgot to test all the bindings (except the changed ones)? It
seems so, therefoer note to myself:
Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions). :)
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-24 7:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 15:12 [PATCH 01/13] dt-bindings: serial: amlogic,meson-uart: allow other serial properties Krzysztof Kozlowski
2023-01-23 15:12 ` [PATCH 02/13] dt-bindings: serial: 8250: correct Nuvoton NPCM850 compatible Krzysztof Kozlowski
2023-01-23 15:12 ` [PATCH 03/13] dt-bindings: serial: pl011: allow ARM Primecell properties Krzysztof Kozlowski
2023-01-23 15:12 ` [PATCH 04/13] dt-bindings: serial: correct ref to serial.yaml Krzysztof Kozlowski
2023-01-23 15:40 ` Michal Simek
2023-01-23 15:12 ` [PATCH 05/13] dt-bindings: serial: cdsn,uart: add power-domains Krzysztof Kozlowski
2023-01-23 15:39 ` Michal Simek
2023-01-23 15:40 ` Krzysztof Kozlowski
2023-01-23 15:12 ` [PATCH 06/13] dt-bindings: serial: 8250_omap: drop rs485 properties Krzysztof Kozlowski
2023-01-23 15:12 ` [PATCH 07/13] dt-bindings: serial: fsl-imx-uart: drop common properties Krzysztof Kozlowski
2023-01-23 15:12 ` [PATCH 08/13] dt-bindings: serial: fsl-lpuart: drop rs485 properties Krzysztof Kozlowski
2023-01-23 15:12 ` [PATCH 09/13] dt-bindings: serial: fsl-lpuart: allow other serial properties Krzysztof Kozlowski
2023-01-23 15:12 ` [PATCH 10/13] dt-bindings: serial: st,stm32-uart: drop common properties Krzysztof Kozlowski
2023-01-23 15:13 ` [PATCH 11/13] dt-bindings: serial: restrict possible child node names Krzysztof Kozlowski
2023-01-23 23:05 ` Rob Herring
2023-01-24 7:25 ` Krzysztof Kozlowski [this message]
2023-01-24 9:05 ` Krzysztof Kozlowski
2023-01-25 17:11 ` Rob Herring
2023-01-23 15:13 ` [PATCH 12/13] dt-bindings: serial: drop unneeded quotes Krzysztof Kozlowski
2023-01-23 15:13 ` [PATCH 13/13] dt-bindings: serial: example cleanup Krzysztof Kozlowski
2023-01-23 15:16 ` [PATCH 01/13] dt-bindings: serial: amlogic,meson-uart: allow other serial properties Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0dd24e8-9d4b-ea23-d1de-190330c0e825@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=clin@suse.com \
--cc=devicetree@vger.kernel.org \
--cc=erwan.leray@foss.st.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jacmet@sunsite.dk \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lkundrak@v3.sk \
--cc=magnus.damm@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=neil.armstrong@linaro.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pragnesh.patel@sifive.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tmaimon77@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).