From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 080ADC77B70 for ; Wed, 12 Apr 2023 02:36:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbjDLCgk convert rfc822-to-8bit (ORCPT ); Tue, 11 Apr 2023 22:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbjDLCgj (ORCPT ); Tue, 11 Apr 2023 22:36:39 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C3B95253; Tue, 11 Apr 2023 19:36:24 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id D535924E2E7; Wed, 12 Apr 2023 10:36:22 +0800 (CST) Received: from EXMBX067.cuchost.com (172.16.6.67) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 12 Apr 2023 10:36:22 +0800 Received: from [192.168.125.89] (113.72.145.176) by EXMBX067.cuchost.com (172.16.6.67) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 12 Apr 2023 10:36:21 +0800 Message-ID: Date: Wed, 12 Apr 2023 10:36:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v1 1/3] riscv: dts: starfive: Enable axp15060 pmic for cpufreq Content-Language: en-US To: Shengyu Qu , Conor Dooley CC: "Rafael J. Wysocki" , Viresh Kumar , Emil Renner Berthing , "Rob Herring" , Krzysztof Kozlowski , Conor Dooley , "Paul Walmsley" , Palmer Dabbelt , Albert Ou , , , , References: <20230411083257.16155-1-mason.huo@starfivetech.com> <20230411083257.16155-2-mason.huo@starfivetech.com> <20230411-chimp-unvarying-142394732ff5@wendy> From: Mason Huo In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [113.72.145.176] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX067.cuchost.com (172.16.6.67) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/11 22:49, Shengyu Qu wrote: >> On Tue, Apr 11, 2023 at 04:32:55PM +0800, Mason Huo wrote: >>> The VisionFive 2 board has an embedded pmic axp15060, >>> which supports the cpu DVFS through the dcdc2 regulator. >>> This patch enables axp15060 pmic and configs the dcdc2. >>> >>> Signed-off-by: Mason Huo >>> --- >>>   .../starfive/jh7110-starfive-visionfive-2.dtsi    | 15 +++++++++++++++ >>>   1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >>> index 2a6d81609284..df582bddae4b 100644 >>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >>> @@ -114,6 +114,21 @@ &i2c5 { >>>       pinctrl-names = "default"; >>>       pinctrl-0 = <&i2c5_pins>; >>>       status = "okay"; >>> + >>> +    pmic: axp15060_reg@36 { >> No underscores in node names please & "pmic" is the generic node name >> for pmics. >> >> Cheers, >> Conor. >> >>> +        compatible = "x-powers,axp15060"; >>> +        reg = <0x36>; >>> + >>> +        regulators { >>> +            reg_dcdc2: dcdc2 { > > reg_dcdc2 seems not a good name, too generic for identification. In most > > cases, it's same as regulator-name but using "_" rather than "-". > Hi Shengyu, Thanks for your review. Will change to "vdd_cpu". >>> +                regulator-boot-on; > > It should not be used,  in Documentation/devicetree/bindings/regulator > > /regulator.yaml, it is described as follows: > > "This property is intended to only be used for regulators where software > > cannot read the state of the regulator." > > In this case, regulator state is completely able to be read by driver. > > Best regards, > > Shengyu >Will remove it. Thanks Mason