From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4460CC10F1E for ; Tue, 20 Dec 2022 10:15:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230100AbiLTKPW (ORCPT ); Tue, 20 Dec 2022 05:15:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbiLTKPV (ORCPT ); Tue, 20 Dec 2022 05:15:21 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFFD3A46F for ; Tue, 20 Dec 2022 02:15:19 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id bp15so17821186lfb.13 for ; Tue, 20 Dec 2022 02:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U9GdfxfR5+EYFRbQQTp+s7HyhqzEMbsaLXxL7CcHk+g=; b=cpGUGSLwT13nmqNu6iSP2AElp+dsMPLQa++MS8J6/OvNCC3S/BxRQVT8tSurRsYtO4 G2WvOu6I7stSzI0dl6QE7g6uselrW4jxG/wGWkk3vlvAv1O5zpGN9FAQqdebWtUHpgys vNVT4GipuclKgDNW52xzrhHv2HdwgaJmJZ81hDMgj3Uwv6CJKP5knXb8VmRq7fihDIHL Q/yY2n33GvfvM5VdbbfDjxwV2/EQLpzfZ2JM6YX14Zzi9qLVkm+5mbaUMjstJ8uhpPwW 8YHcuVScluC156Gw3KLOxBkbzxhlJtwcjpxVfaiRaUwRHZHNkog9fis1OcizySMJOog2 EOww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U9GdfxfR5+EYFRbQQTp+s7HyhqzEMbsaLXxL7CcHk+g=; b=MaBi97VdVXGU4CJeBXiql+EGmRF6Jdyi6CHRer554lmEVZLLUJv2gJZdWgEkZJuEQA I7bglSlDTUjyitUvpkXCFFFPPKhsp5FJ8tNUf3Xv13o2aPrOgMOSw6fVlEyNR0RmL7eR oMfd7ZN79oX+H/3ZudRYt2jj8seIB0fOC2SNyiiyVllUHdUMDDfE0dMgDeALvlOOM8Dd RMc07Uah4uHMqiDY9Y3pYjNxfbfnt5pkVW/udZEaWbvKlxunnoIuIR1/a+WjqElTL+SZ 5PmaxTDIWb6vkty3p1mKP/IjLvjR7rIa3LLWTZdUrd851Od6MYx4EbDXH4dbQCbFdwJd FBAA== X-Gm-Message-State: ANoB5pkMfvkfNF5d43icDQeCj+H/ms/1KKyhChYBWW7fIUFVVZmAQSU6 /BJiwYBt1V2MxCyUwQuq/yCcBD913QzLgJRS X-Google-Smtp-Source: AA0mqf7k5zItWg0Bot3y5LRFmvevyM5Cr0btlX+T/QPdsl6i0E5eWOSOxaCnbN66mFi8QSxTwZGa1Q== X-Received: by 2002:a05:6512:3b86:b0:4b5:5f2b:ddfa with SMTP id g6-20020a0565123b8600b004b55f2bddfamr17468217lfv.30.1671531318166; Tue, 20 Dec 2022 02:15:18 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id d4-20020ac244c4000000b004b57277474esm1395906lfm.106.2022.12.20.02.15.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 02:15:17 -0800 (PST) Message-ID: Date: Tue, 20 Dec 2022 11:15:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 1/4] dt-bindings: hwmon: adi,ltc2945: Add binding Content-Language: en-US To: "Cormier, Jonathan" , linux-hwmon@vger.kernel.org Cc: Jean Delvare , Guenter Roeck , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Bob Duke , John Pruitt References: <20221214220727.1350784-1-jcormier@criticallink.com> <20221220000457.1163446-1-jcormier@criticallink.com> <20221220000457.1163446-2-jcormier@criticallink.com> From: Krzysztof Kozlowski In-Reply-To: <20221220000457.1163446-2-jcormier@criticallink.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/12/2022 01:04, Cormier, Jonathan wrote: > Create initial binding for the LTC2945 I2C power monitor. > Also adds shunt-resistor-micro-ohms parameter The last sentence does not make sense. I propose to skip it. > > Signed-off-by: "Cormier, Jonathan" > --- > .../bindings/hwmon/adi,ltc2945.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml > new file mode 100644 > index 000000000000..f90d40919ee6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/adi,ltc2945.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices LTC2945 wide range i2c power monitor > + > +maintainers: > + - Guenter Roeck Maintainer of binding is person interested in the device, e.g. having the hardware or datasheet. Not the subsystem maintainer. Unless by coincidence this is the same person here? > + > +description: | > + Analog Devices LTC2945 wide range i2c power monitor over I2C. > + > + https://www.analog.com/media/en/technical-documentation/data-sheets/LTC2945.pdf > + > +properties: > + compatible: > + enum: > + - adi,ltc2945 > + > + reg: > + maxItems: 1 > + > + shunt-resistor-micro-ohms: > + description: > + Shunt resistor value in micro-Ohms > + default: 1000 > + > +required: > + - compatible > + - reg > + > + This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > +additionalProperties: false > + Best regards, Krzysztof