From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0AAC43334 for ; Wed, 20 Jul 2022 16:46:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234003AbiGTQqf (ORCPT ); Wed, 20 Jul 2022 12:46:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233532AbiGTQqe (ORCPT ); Wed, 20 Jul 2022 12:46:34 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78FA23B979 for ; Wed, 20 Jul 2022 09:46:33 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id p6so21781253ljc.8 for ; Wed, 20 Jul 2022 09:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=eW32Y7kHOoyCzchouD8dBLTcqgbgXS4BmFC/O4Lg30M=; b=nyqku3a3HLHK+70E+Y8GEosypIROvWnmFa/2I+30KlBVuuce+jbXYBdjw1HU1XIQYo IASGUJ/GmK9MfrIUqi2Oh5EQ/YEDzyYpX908dTmykKAamIkU3klTz2s2TFVdqR2IT3YN /KJzjooCKdFzBCrI8VTgCbCnkHc1VRMVVG75oZbZnR5scYqfChufd0b2rdf+wlEVUZFK JhjQVarnP0hpatl07I5UhhBwKnn7bI69wb+IzXsdaE9M1Nz5gtKhHBlK9XShN9r/ofrj YnppJW+jXsoT58Jw1VLWlxyIfbVQ64Wfvo8ik+zs6lX86yaaUpwltp5KtzpHaD6hmMas EdJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=eW32Y7kHOoyCzchouD8dBLTcqgbgXS4BmFC/O4Lg30M=; b=220r1xRfHhuB3FKlBLdrv/pPiAGp8CX39Ec3Xhk6BOGaNirfjUiFfMORoU3YREtTvx Gb/DVB10QZbu1QwPjcmFLKdZYOooPPCepV59nf6etJ7wtSbx+2YFT/80VUk+/zBrGSz7 S6GoPBNRAKtyrrw9deNZfnTUnuwYTWliZJmIdkD1BDLNiA5IucI3hwQ+RPRxLMeySVpT fHHmM3lRUE0hUiVwCmSt+vL8EK4JXcP/pugUfTYt5n0z23xbyUTEUCnGGhXxcq6fQTJE mlMENFTTSefmpyXTq+VDogopxwTEuxRv2gmLqvDd+VaFxdZM/iqpf+ZdzSKHXFkSZWWQ BFSA== X-Gm-Message-State: AJIora/WfFHiOOCs7EqJ3fcA2BVpOmhs+h7BApzNHVIUca6aW41Z7F4Z ccT0tb4oSKtGIpQ6nnW+luvWKQ== X-Google-Smtp-Source: AGRyM1urk9m4eQiadowgrMKnFWZPaGdClLxR5kV7tNRV7fT6yqR9omQX/92QK4itmaBnZ/RRFFCbKQ== X-Received: by 2002:a05:651c:1207:b0:25d:4eba:e247 with SMTP id i7-20020a05651c120700b0025d4ebae247mr16601237lja.100.1658335591868; Wed, 20 Jul 2022 09:46:31 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id h28-20020a0565123c9c00b00489da512f5asm3915996lfv.86.2022.07.20.09.46.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 09:46:31 -0700 (PDT) Message-ID: Date: Wed, 20 Jul 2022 18:46:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] dt-bindings: arm: qcom: Document additional sku6 for sc7180 pazquel Content-Language: en-US To: Doug Anderson Cc: Yunlong Jia , LKML , Henry Sun , Bob Moragues , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm References: <20220720073755.1.Ifab936517646b3876dd31b6e9b1b58a858529e57@changeid> <4cc6a276-4cbe-506a-6425-677c56469645@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/07/2022 17:07, Doug Anderson wrote: > Hi, > > On Wed, Jul 20, 2022 at 12:46 AM Krzysztof Kozlowski > wrote: >> >> On 20/07/2022 09:38, Yunlong Jia wrote: >>> The difference between sku6 and sku4 is that there is no esim >>> >>> Signed-off-by: Yunlong Jia >>> --- >>> >>> Documentation/devicetree/bindings/arm/qcom.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >>> index 4dd18fbf20b6..aebeefdab27f 100644 >>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>> @@ -410,6 +410,7 @@ properties: >>> - description: Google Pazquel with LTE and Parade (newest rev) >>> items: >>> - const: google,pazquel-sku4 >>> + - const: google,pazquel-sku6 >> >> This looks wrong, did you test it? > > Why do you think it's wrong? This patch is adding a second compatible > string to an existing dts. Because it was sent after a patch adding sku6+sku4+sc7180, but the order here is different. However for some reason it was not part of a patchset which makes it total mess and even less possible to understand. > The only difference between SKU4 and SKU6 > is that one of them has the eSIM component stuffed and the other one > doesn't. This need not be represented in the dts since the eSIM is > automatically detected, but it was still stuffed as a SKU strapping so > the factory could tell whether the missing eSIM was an error or > intentional. > > This is just like the SKU0 vs. SKU2 difference. > > Other than the fact that this should be together in one series with > the dts patch: > > Reviewed-by: Douglas Anderson I don't agree. With last DTS patch this is a wrong binding (or wrong DTS) therefore I must NAK it. Please do not upstream stuff in some different way, like sending bindings and DTS separate. Best regards, Krzysztof