From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D298EB64DB for ; Wed, 14 Jun 2023 16:52:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236300AbjFNQwT (ORCPT ); Wed, 14 Jun 2023 12:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235920AbjFNQwS (ORCPT ); Wed, 14 Jun 2023 12:52:18 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 209872122 for ; Wed, 14 Jun 2023 09:52:16 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9745baf7c13so127562066b.1 for ; Wed, 14 Jun 2023 09:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686761534; x=1689353534; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/4RKuZCqzW2Dlrgh/BnCWxatIsnaqixg2Yy82HrsyRc=; b=ea5niOQKFslWBeiu8l8bwW2emOXzF+TZN9SXr6i6QQGhp+/Rdf7xCwSxDj4eCkhE/x ixSyBRefLvGETnEw79vEBBJvw6TMiaS7seZe6l+jhYIK5aike+iFA3QzmbwqVdtGyRa3 Kc5CKve1Wfl9CZVQiDSwPLlShhaHSdjgc6QikaV4cOde4oTY2iB6UEe8nmdXB+ftFd6I N+/h2rvuVm56oG/884rJdLharBgh6ijnN5RIeI7fyLvljOXocqTYgzB4Q+Jj3TkJiG/O 6fWUTFcmCCcRTJk0I0DJ/tTqqrFQN2OcylO40akZYApsIi+WCslvmTg9vyCrR1+gBH/r BQZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686761534; x=1689353534; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/4RKuZCqzW2Dlrgh/BnCWxatIsnaqixg2Yy82HrsyRc=; b=f+a1y7gyoT56BboOLsoo0Z0jJmsdx3mQq1UROfuOTyOPbUPidfHLQn0Qyz2Bsdvipq wHLQ6TWf0UdZS0zhsxDQTZ5B6GL7NixpH9WHQnvNcLcpXVQuvOcr8Wy/W6LSl4w2zJ/c AJdkar6tB02dOtyDWxSg8ZVkoE+b08dOYDJp5M/dheDubQyJ5QhGu5wlprXeyUk2X9Cx r69t0ry2UWtzCLS3y0/UDmAh6e6HThzo0NDGn/jUdcDYFij0NcC4x5TC2aeWX2NnsCme dDRSf1xW8GmJeHYBCZGPBK2zr6zRUH8coPgullgY7jED9Af4xkF+LAjWiT3RuXC6aQOG 5ogg== X-Gm-Message-State: AC+VfDxLdR0l6pJkmL2GNUq3xdpbv06zWeolwmrrmrKiTOzAbKzd7rQs xQ85CisrNcAWqzYPrOfg4M3zVA== X-Google-Smtp-Source: ACHHUZ7E7FKxahgtG+bxV0HhVkZEyxm7yrjKAS9lo7WpJwoXEvrbR8cTx0jmapBX4FNtiJqh6VEy0w== X-Received: by 2002:a17:907:80c:b0:978:8e58:e1a9 with SMTP id wv12-20020a170907080c00b009788e58e1a9mr16265342ejb.15.1686761534577; Wed, 14 Jun 2023 09:52:14 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id o7-20020a170906358700b00969cbd5718asm8140798ejb.48.2023.06.14.09.52.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 09:52:14 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 18:52:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5 01/22] dt-bindings: interconnect: Add Qcom RPM ICC bindings Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Georgi Djakov , Leo Yan , Evan Green , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org References: <20230526-topic-smd_icc-v5-0-eeaa09d0082e@linaro.org> <20230526-topic-smd_icc-v5-1-eeaa09d0082e@linaro.org> <47cfe777-45b9-6303-1374-bc96803d26d4@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/06/2023 18:48, Konrad Dybcio wrote: > On 14.06.2023 18:47, Krzysztof Kozlowski wrote: >> On 14/06/2023 18:43, Konrad Dybcio wrote: >>> On 14.06.2023 18:43, Krzysztof Kozlowski wrote: >>>> On 14/06/2023 12:22, Konrad Dybcio wrote: >>>>> The SMD RPM interconnect driver requires different icc tags to the >>>>> RPMh driver. Add bindings to reflect that. >>>>> >>>>> Signed-off-by: Konrad Dybcio >>>>> --- >>>>> include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++ >>>>> 1 file changed, 13 insertions(+) >>>>> >>>>> diff --git a/include/dt-bindings/interconnect/qcom,rpm-icc.h b/include/dt-bindings/interconnect/qcom,rpm-icc.h >>>>> new file mode 100644 >>>>> index 000000000000..2cd56f91e5c5 >>>>> --- /dev/null >>>>> +++ b/include/dt-bindings/interconnect/qcom,rpm-icc.h >>>>> @@ -0,0 +1,13 @@ >>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>>>> +/* >>>>> + * Copyright (c) 2023, Linaro Limited >>>>> + */ >>>>> + >>>>> +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H >>>>> +#define __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H >>>>> + >>>>> +#define RPM_ACTIVE_TAG (1 << 0) >>>>> +#define RPM_SLEEP_TAG (1 << 1) >>>>> +#define RPM_ALWAYS_TAG (RPM_ACTIVE_TAG | RPM_SLEEP_TAG) >>>> >>>> Where are these used? I don't see any DTS in your patchset. Did you send >>>> it separately? >>> In the driver for now, e.g. patch 19. DTS can only come after the >>> driver is fixed or things will explode! >> >> You reference it in patch 19, but I still do not see the constants being >> used. > > Fragment of P19: > > if (!tag) > - tag = QCOM_ICC_TAG_ALWAYS; > + tag = RPM_ALWAYS_TAG; Now I see, thanks:) Best regards, Krzysztof