From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FFDA2957A7 for ; Mon, 28 Apr 2025 18:03:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745863440; cv=none; b=rH3APoHLStnPyKzcvgs21ECKU/xblbZUC1IVZwV4fW1S7hKsyTyXBphoAnjMw4qw8/S8XMDDAHmXvUq31pWOzrGxq+z0iB8bS2qLTirqWvPJsDeYjsDBYsCFZOLR5giOii229fkjO71UBOkuRLPwv8mAPJ3CfNd9GkkC9i9mwmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745863440; c=relaxed/simple; bh=2l8v5GoV84d39u4DAVXZu15z37k8q2ZY6Rdpku5UUCk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=NhAMJaN+L0Z0Ui3xjC5I1sTjhxh+lLPxyJLpMwDUtSCU2sb5NUInOWk9sFA+mAANX0E2fD0UAS17bQoyvUSVgFM036p3KqJTbm63MSlyHc4lTpCxJkHTfx8veU32Rdq8S1EbKNiqXPP6t+omBtAFtM+GS5FdRlxelU+M4uuSajQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Bs668uBa; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Bs668uBa" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-39ee651e419so2686610f8f.3 for ; Mon, 28 Apr 2025 11:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745863437; x=1746468237; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=LhH2cWJiOFiPJwDHm1EMiooPrujkspMZlGWkH+fi+54=; b=Bs668uBaSvY4P1JahQrbvlmfhR/SnCL81rC6Hp7aJ0v+O6Q/KFCeQeGa2SQ7+Pe8Lu /F4OyEaeSoRUfDRJqlUL2pJcm2SbRwO9sLknWc3bUj1mrH1LtxuYR/IRnp6UgUtPvuzA 2oaPU69vccyRLup0su+yxXjXn5Ax6UN/rSGpZ4/7OTZCADCJ4Muee4JbPI8b2Ti3VCNs KbkonCIZ/TEMc5QeaTKuaChAiR2a/nag+nfjHQuGYjQAQVMroXCoY0WnM8ZdA89Xaeix jzkXh3uiHusV5J2aeoq+f1MXb0uftAaLHnsJGCYni969eExB3e5rI+cEYGxnstj2hLRt Fafw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745863437; x=1746468237; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LhH2cWJiOFiPJwDHm1EMiooPrujkspMZlGWkH+fi+54=; b=pg/O4/LpSnEMz4aPxgnBHg5/GCcGVzJYwUY2TvCv9AWYbuLkqGuJ59YuGXPMej0FaF qMBLU2KPqPJI7QQp9gKzBzhq8rGfLnlsLKSee/vD9vs/S9nJzvf3NgOc9Hwcl1rLL6Ep ueBGE8HAhAtze47D5VhaRnEgINus5kGZzLLxt6Qz1Apugxpmw4e8ez/ee09Sm9Ofanau NmKwAbwTWd7GY6VjMEjBu7QP93ex5ZJ+tEI/fJ1k/lAwxb+ZbQhat8fDsV5Il5868Di8 /t1e4IRIeRmQDDIe8d6cR0B5q7LzrZhbrHjUTkd14k8DJju2GTT3OkxuqbeClNh7MGWs kkDQ== X-Forwarded-Encrypted: i=1; AJvYcCU6L3sL+pLMPEdQ1CEHfYk6WTmfz4aYtMd7BH7t/zU2+OB7R2cUcH+u4dIrWEZu0v5Wb0UX86R/Zt2T@vger.kernel.org X-Gm-Message-State: AOJu0YwBkf10Jov/GgdhKZuffXjDfo7kopEy9aDWvGOsmIpjOrTdahmM Rz08k3Tsmw9zVWVXV1z0YAP/t+YX5pTFVEVYPUVkruZ+W2p3yzk4ha6I+pw+tSs= X-Gm-Gg: ASbGnctRnUov4eh7I0I2gDVT1vDj+rZhGeh0ljaJ7GbooCCxt7DF3wkAp6iTyGzR4B4 NmZ+wPihfmA2OgjvgYy4C59kAYfHLaXn9QWnk5ykVp9aGf/jGPuOqj7xhK0pKlCNJ4cghss26VO HBVBzdyJYByeF15nUtx6JAEQc8+qd/jVTMoOfh7Jy2cJU8GvgoN+mFWQZf4Wapbw+RXXrZyzPk0 Klq14h+VfY4HUIkHKcMmB6Z6u3ORoQE3Zdyg0WS34zzTlBTYS+DyHGXBRtPQojKixe74mveGDic IHlDVu8PBCNMbjT0AzfmZwZlZG/5i3YcnHEmXGSkkQcU X-Google-Smtp-Source: AGHT+IFufjFxqWpK/DiwzoIhe+tnqis6Q5i4cTihbGu1kOEcV7a+TqrcCHr03xN9hBxN/HPNsngJAw== X-Received: by 2002:a05:6000:4282:b0:39a:c9c1:5453 with SMTP id ffacd0b85a97d-3a08a3c8a48mr205683f8f.49.1745863436775; Mon, 28 Apr 2025 11:03:56 -0700 (PDT) Received: from draszik.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d29b9c4sm167552465e9.3.2025.04.28.11.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 11:03:56 -0700 (PDT) Message-ID: Subject: Re: [PATCH v4 00/32] Samsung S2MPG10 PMIC MFD-based drivers From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski Cc: Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni , Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org Date: Mon, 28 Apr 2025 19:03:54 +0100 In-Reply-To: <20250410-dancing-free-peacock-536c24@shite> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> <20250410-dancing-free-peacock-536c24@shite> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3-2+build1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Krzysztof, On Thu, 2025-04-10 at 08:18 +0200, Krzysztof Kozlowski wrote: > On Wed, Apr 09, 2025 at 09:37:21PM GMT, Andr=C3=A9 Draszik wrote: > > This series adds initial support for the Samsung S2MPG10 PMIC using the > > MFD framework. This is a PMIC for mobile applications and is used on > > the Google Pixel 6 and 6 Pro (oriole / raven). > >=20 > > *** dependency note *** > >=20 > > To compile, this depends on the Samsung ACPM driver in Linux next with >=20 > Are you sure these are build time dependencies? Do not look like. Yes, there is a build time dependency on the ACPM driver (also mentioned in Kconfig). In particular the last series mentioned below (acpm-children) adds devm_acpm_get_by_node() which this driver needs. > Also, > if they are, the patchset will wait for quite some time. All the dependencies appear to have landed in linux-next as of writing this. >=20 > > the following additional patches: > > https://lore.kernel.org/all/20250324-acpm-atomic-v2-0-7d87746e1765@lina= ro.org/ > > https://lore.kernel.org/all/20250319-acpm-fixes-v2-0-ac2c1bcf322b@linar= o.org/ > > https://lore.kernel.org/all/20250327-acpm-children-v1-0-0afe15ee2ff7@li= naro.org/ > >=20 > > *** dependency note end *** > >=20 > > +++ Kconfig update +++ > >=20 > > There is a Kconfig symbol update in this series, because the existing > > Samsung S2M driver has been split into core and transport (I2C & ACPM) > > parts. CONFIG_MFD_SEC_CORE is now truly a core driver, and > > the I2C code that was part of it is now enabled via CONFIG_MFD_SEC_I2C. > >=20 > > This was necessary because unlike the other S2M PMICs, S2MPG10 doesn't > > talk via I2C, but via the Samsung ACPM firmware. > >=20 > > +++ Kconfig update end +++ > >=20 > > This series must be applied in-order, due to interdependencies of some > > of the patches. There are also various cleanup patches to the S2M > > drivers. I've kept them ordered as: >=20 > They should not depend... although actually not my trees, except the > firmware. The s2mpg10 core patch adds enums and register macros for the new PMIC, which the clk and rtc drivers then use, hence I'm calling out this dependency - they can not compile without the core patch in place. Cheers, Andre'