Re: [PATCH 2/2] dt-bindings: misc: merge qcom,qrc

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 03/03/2024 17:53, Canfeng Zhuang wrote:
> Merge Qualcomm-specific qrc binding

Merge? No, instead describe the hardware.

Similar problem with the sibject.

> 
> Signed-off-by: Canfeng Zhuang <quic_czhuang@quicinc.com>
> ---
>  .../devicetree/bindings/misc/qcom,qrc.yaml         | 32 ++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/misc/qcom,qrc.yaml b/Documentation/devicetree/bindings/misc/qcom,qrc.yaml
> new file mode 100644
> index 000000000000..730efd679ba0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/qcom,qrc.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/qcom,qrc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Robotics Communication Driver

Driver? Unfortunately bindings are for hardware, not drivers.

> +
> +maintainers:
> +  - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The QRC (Qualcomm Robotics Communication) driver is used for information interaction

Agaim, driver?

> +  between the robot control board and the main board when using a uart port connection.
> +  This Driver will support uart read & write and robot control board

No, describe the hardware.

> +  reset function.
> +
> +properties:
> +  compatible:
> +    const: qcom,qrc-uart
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    qrc: qcom,qrc_uart {


How does it remotely look like upstream DTS? Please don't send
downstream/vendor DTS before cleaning it up. Before posting, please read
submitting patches and/or quite extensive Qualcomm upstreaming guides.

> +        compatible = "qcom,qrc-uart";

Nope, so this is just to instantiate Linux device? No resources? This
looks really incomplete.

> +    };
> +
> 

Best regards,
Krzysztof