From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D48C433F5 for ; Wed, 30 Mar 2022 16:57:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349102AbiC3Q6v (ORCPT ); Wed, 30 Mar 2022 12:58:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349099AbiC3Q6u (ORCPT ); Wed, 30 Mar 2022 12:58:50 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E54F648E60 for ; Wed, 30 Mar 2022 09:57:03 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id g20so25165454edw.6 for ; Wed, 30 Mar 2022 09:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fEzld4oIJa86hl09sRy64K2e8LGIGCRfWuc+U0PWYOs=; b=pz8Axq5e3iFbz7Jw0eIdKg+hWyV0eg5X/OrzwVODe4qALsVNW5P6XCIffz7jZBls1S Ay8G4ifJkD57k5cn7sKOqZqcX8jZz7AiV0A+xfY0usJu+I228VzlXlRNwtFfpvWDYChT tCTa4NX0jot2hZU9MZto6acQS6j1L5ezvPVFwjTq5mozRXGJ/05EDtzB/X0fdtun30yf E7wrNN00iG4bycxxZuXuO6Zu97SotlzoyB98sU++D3zFCPA3T7stPpKNzWvbRrSL+Hzq CLmsL7H9fVbfmMMXR72/C2K+zdLRiND4Sk71buZAy/vXVdCalN6MK04NuIfO07hJu1FF XYsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fEzld4oIJa86hl09sRy64K2e8LGIGCRfWuc+U0PWYOs=; b=boCi/8aE1wLSKWGg5RX8EEGDStYfeRyB6cntKIrxfoDZTXLwmC/FmKu8zhv/KUWU4l TQTXQllEJ1Ln80P17ob3afvWZD3bm91ROMBR7zb5IAt75ektN/bRoRP6G2IfJWJ2QAAi 3NDRuwQMXEW6NUdNHg2igXV0Ip0K5nmZ61udS00Y2seN3i3wrc43k2YyxfVsRSBgSy5F NZAE0wroRHTS1RyOxcHQnUG2fWzQs5h6UMLrUR04ghAwOJ/ouG42O+rj5UEcJMWiFtta 1NEO+UpP/JY8Ld4j8yJv/ui+s2aFWz/5y4iFNQ3oetYU6PHhbyBh5bGPfIWbpEyoeysK OuQA== X-Gm-Message-State: AOAM533wmgxlJkjyYO7JmNhmBI4ZuB9E8CGJjv+9SudLDDOd2aB6SDYy tTjvT/SC3qJdwoFZH/W0GLhogQ== X-Google-Smtp-Source: ABdhPJyCpxyw7R6T+pFO1zsX01vbrvk5lvAApJ9RbFPs/LdEa4c5G+bltActTe6FNicQwS1ouiR2cg== X-Received: by 2002:a05:6402:d67:b0:419:48b:a762 with SMTP id ec39-20020a0564020d6700b00419048ba762mr11695300edb.291.1648659422507; Wed, 30 Mar 2022 09:57:02 -0700 (PDT) Received: from [192.168.0.164] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id q15-20020a1709060e4f00b006cdf4535cf2sm8394201eji.67.2022.03.30.09.57.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 09:57:01 -0700 (PDT) Message-ID: Date: Wed, 30 Mar 2022 18:57:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] dt-bindings: Fix incomplete if/then/else schemas Content-Language: en-US To: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Olivier Moysan , Arnaud Pouliquen , Bjorn Andersson , Georgi Djakov , Ulf Hansson , Thierry Reding , Jonathan Hunter , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Kishon Vijay Abraham I , Vinod Koul , Mark Brown , Fabrice Gasnier , Grygorii Strashko , Dmitry Osipenko , linux-iio@vger.kernel.org, alsa-devel@alsa-project.org, linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org References: <20220330145741.3044896-1-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220330145741.3044896-1-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/03/2022 16:57, Rob Herring wrote: > A recent review highlighted that the json-schema meta-schema allows any > combination of if/then/else schema keywords even though if, then or else > by themselves makes little sense. With an added meta-schema to only > allow valid combinations, there's a handful of schemas found which need > fixing in a variety of ways. Incorrect indentation is the most common > issue. > > Cc: Lars-Peter Clausen > Cc: Michael Hennerich > Cc: Jonathan Cameron > Cc: Krzysztof Kozlowski > Cc: Olivier Moysan > Cc: Arnaud Pouliquen > Cc: Bjorn Andersson > Cc: Georgi Djakov > Cc: Ulf Hansson > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > Cc: Mark Brown > Cc: Fabrice Gasnier > Cc: Grygorii Strashko > Cc: Dmitry Osipenko > Cc: linux-iio@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-phy@lists.infradead.org > Signed-off-by: Rob Herring > --- > .../bindings/iio/adc/adi,ad7476.yaml | 1 + > .../bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 8 +- > .../bindings/iio/dac/adi,ad5360.yaml | 6 +- > .../bindings/interconnect/qcom,rpm.yaml | 84 +++++++++---------- > .../bindings/mmc/nvidia,tegra20-sdhci.yaml | 2 + > .../bindings/net/ti,davinci-mdio.yaml | 1 + > .../bindings/phy/nvidia,tegra20-usb-phy.yaml | 20 ++--- > .../bindings/phy/qcom,usb-hs-phy.yaml | 36 ++++---- > .../bindings/regulator/fixed-regulator.yaml | 34 ++++---- > .../bindings/sound/st,stm32-sai.yaml | 6 +- > .../devicetree/bindings/sram/sram.yaml | 16 ++-- > 11 files changed, 108 insertions(+), 106 deletions(-) Looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof