devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "James Tai [戴志峰]" <james.tai@realtek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v2 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs
Date: Sat, 2 Dec 2023 16:18:56 +0000	[thread overview]
Message-ID: <e1490203387d4c48a5f8c4040ece038a@realtek.com> (raw)
In-Reply-To: <7959920acf004f3cb8072de1e17439fa@realtek.com>

Hi Krzysztof,

>>> +
>>> +  compatible:
>>> +    enum:
>>> +      - realtek,rtd1319-intc-iso
>>> +      - realtek,rtd1319-intc-misc
>>> +
>>> +  "#address-cells":
>>> +    const: 0
>>> +
>>> +  interrupt-controller: true
>>> +
>>> +  interrupts-extended:
>>
>>interrupts instead.
>>
>>Anyway, you must describe the items. Why this is not fixed but flexible?
>>Hardware has different number of pins? That's unlikely.
>>
>I will replace it with 'interrupts'. Since our Interrupt controller architecture
>doesn't involve multiple interrupt sources, using 'interrupts' should suffice.
>

Due to changes in hardware design, some peripheral interrupts pin initially connected to the Realtek interrupt controller were redirected to the GIC. 
However, the associated fields and statuses in the Realtek interrupt controller registers were not removed.
As a result, these interrupts cannot be cleared by peripheral register, and their status clearing is still needing the Realtek interrupt controller driver to manage.

That's why flexibility is necessary.

Regards,
James

  reply	other threads:[~2023-12-02 16:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 16:27 [PATCH v2 0/6] Initial support for the Realtek interrupt controller James Tai
2023-11-17 16:27 ` [PATCH v2 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs James Tai
2023-11-17 17:32   ` Rob Herring
2023-11-18 13:32     ` James Tai [戴志峰]
2023-11-18  1:37   ` kernel test robot
2023-11-19 12:47   ` Krzysztof Kozlowski
2023-11-20  9:08     ` James Tai [戴志峰]
2023-12-02 16:18       ` James Tai [戴志峰] [this message]
2023-12-03 15:04         ` Krzysztof Kozlowski
2023-12-03 15:56           ` James Tai [戴志峰]
2023-12-03 16:32             ` Krzysztof Kozlowski
2023-12-05  8:43               ` James Tai [戴志峰]
2023-12-05  8:47                 ` Krzysztof Kozlowski
2023-12-06 15:07                   ` James Tai [戴志峰]
2023-12-06 17:48                     ` Krzysztof Kozlowski
2023-12-07  5:59                       ` James Tai [戴志峰]
2023-12-02 16:39       ` James Tai [戴志峰]
2023-12-02 16:42     ` James Tai [戴志峰]
2023-11-17 16:27 ` [PATCH v2 2/6] irqchip: Add interrupt controller " James Tai
2023-11-17 16:27 ` [PATCH v2 3/6] irqchip: Introduce RTD1319 support using the Realtek common interrupt controller driver James Tai
2023-11-20 16:18   ` Dan Carpenter
2023-11-22  8:39     ` James Tai [戴志峰]
2024-01-03  9:45   ` Dan Carpenter
2023-11-17 16:27 ` [PATCH v2 4/6] irqchip: Introduce RTD1319D " James Tai
2023-11-17 16:27 ` [PATCH v2 5/6] irqchip: Introduce RTD1325 " James Tai
2023-11-17 16:27 ` [PATCH v2 6/6] irqchip: Introduce RTD1619B " James Tai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1490203387d4c48a5f8c4040ece038a@realtek.com \
    --to=james.tai@realtek.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).