public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>,
	marcel@holtmann.org, luiz.dentz@gmail.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, amitkumar.karwar@nxp.com,
	sherry.sun@nxp.com, manjeet.gupta@nxp.com
Subject: Re: [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support for 4M baudrate
Date: Mon, 16 Jun 2025 18:26:54 +0200	[thread overview]
Message-ID: <e15f4d39-379d-436f-b401-36f5b3f6f010@kernel.org> (raw)
In-Reply-To: <20250616150919.8821-1-neeraj.sanjaykale@nxp.com>

On 16/06/2025 17:09, Neeraj Sanjay Kale wrote:
> Add support for 4000000 as secondary baudrate for downloading FW chunks and
> after HCI initialization is done at fw-init-baudrate.
> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> ---
>  .../bindings/net/bluetooth/nxp,88w8987-bt.yaml         | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 3ab60c70286f..f1c7f900001c 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -34,6 +34,16 @@ properties:
>        This property depends on the module vendor's
>        configuration.
>  
> +  secondary-baudrate:
> +    $ref: /schemas/types.yaml#/definitions/uint32

baudrate is in some value, so use unit suffix from property-units and
drop the ref.

And then you will see that it could be actually an array, so why not
using existing properties? Otherwise you will add soon "tertiary" etc?
This does not scale.

Best regards,
Krzysztof

  parent reply	other threads:[~2025-06-16 16:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 15:09 [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support for 4M baudrate Neeraj Sanjay Kale
2025-06-16 15:09 ` [PATCH v1 2/2] Bluetooth: btnxpuart: " Neeraj Sanjay Kale
2025-06-17  2:53   ` Sherry Sun
2025-06-17  6:43     ` Krzysztof Kozlowski
2025-06-17  9:57       ` Neeraj Sanjay Kale
2025-06-16 16:26 ` Krzysztof Kozlowski [this message]
2025-06-17  9:52   ` [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: " Neeraj Sanjay Kale
2025-06-17  9:56     ` Neeraj Sanjay Kale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e15f4d39-379d-436f-b401-36f5b3f6f010@kernel.org \
    --to=krzk@kernel.org \
    --cc=amitkumar.karwar@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=manjeet.gupta@nxp.com \
    --cc=marcel@holtmann.org \
    --cc=neeraj.sanjaykale@nxp.com \
    --cc=robh@kernel.org \
    --cc=sherry.sun@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox