From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7248C4167B for ; Tue, 27 Dec 2022 11:30:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231318AbiL0LaH (ORCPT ); Tue, 27 Dec 2022 06:30:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231215AbiL0LaF (ORCPT ); Tue, 27 Dec 2022 06:30:05 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9757C63FF for ; Tue, 27 Dec 2022 03:30:03 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id z26so19241974lfu.8 for ; Tue, 27 Dec 2022 03:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=aN3V6trDzvXSYtL26lx3FV7PuCk2Xl5LGxwnUm2VEh4=; b=D6oARKb10jppciRnCilQ32Dej7uYF6DSTuvY/IP+oORmU/pLbrptAk5OvgLB7b/LGz oV7OFaGBSJvYCcJ3rAVE0CPVtzVzFcW2cR8kTME64K70KdZ/lptsknSNE/p30R/f21LA 3lM1SXOztnLyMbdSVbrcivQ2061TJzTVnxqf7On/F8qq0kRkjnkZa18PgdDC9Hv+ignV W7vIpGaICcqC0D2lGZKXk+fsw5IaD7DBbJ086Nzn4G0d7mVLzFf87cZ9EIvcFel5+6gU NvZHoLsyoB/h+VSobCXAqiX1fM8XhxpwhGTqkRsnQVH1lmhvjuujtsXH4pA3l/sDDVQo wYHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aN3V6trDzvXSYtL26lx3FV7PuCk2Xl5LGxwnUm2VEh4=; b=kxid/vY+P/0QF1F6fIt1A7zzQIM/StGMEuYAocaMRHttrrJMc49vVC1XZqHA+dKMVa KUIb529nIg8t12euUiwRcnWpBLiXVYZEziRj/VXtaMtIKClJVg/nO5dsCxy2nPkpyYey aJ/xfbU7EkLU0wF4nQ9obm/7iPy/JQd4zwAzr5tCyQEUN03b451ho6hIdV++30I7nRff vDijWjNa9pFKLLEcWbNG1qBKfJp9DhqUgJnVb/57rtvZkghyrbkHIArP767NKMphg/Ux pU1dAF0J0CiPZBx1pGLt7YJIRsOaOPMKQ3yfWWqnQuQv4cEGJfUaNYNmza+GZf0v4Sb7 oG4A== X-Gm-Message-State: AFqh2krP0D210cDsW3gDHqGetXNCgdi7SRMV01gVnJAt6cCGQojvbZzr Ga4HnJNtWog/XnUtks/+Mjrh5A== X-Google-Smtp-Source: AMrXdXuQCFF6EAuPGhKVlnd9xb+jRbrMxibY4uYGpnnSUw158af9QxPKYTxPgBMtBgUBq5JAQ+Szdg== X-Received: by 2002:a05:6512:6cb:b0:4a4:68b7:e71a with SMTP id u11-20020a05651206cb00b004a468b7e71amr6566622lff.4.1672140601477; Tue, 27 Dec 2022 03:30:01 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id k2-20020ac24562000000b004b4ea0f4e7fsm2192712lfm.299.2022.12.27.03.30.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 03:30:01 -0800 (PST) Message-ID: Date: Tue, 27 Dec 2022 12:29:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/4] ARM: dts: qcom: sdx65: add specific compatible for USB HS PHY To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Wesley Cheng , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221223161835.112079-1-krzysztof.kozlowski@linaro.org> <20221223161835.112079-3-krzysztof.kozlowski@linaro.org> <6a9506a5-caf0-0977-af75-0a4e4c0e3a0f@linaro.org> <542a4f6f-931a-3e0a-bd5d-1344339651ea@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <542a4f6f-931a-3e0a-bd5d-1344339651ea@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/12/2022 12:14, Konrad Dybcio wrote: > > > On 24.12.2022 14:12, Krzysztof Kozlowski wrote: >> On 23/12/2022 17:20, Konrad Dybcio wrote: >>> >>> >>> On 23.12.2022 17:18, Krzysztof Kozlowski wrote: >>>> Add SoC-specific compatible to the USB HS PHY to match other devices and >>>> bindings. >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> --- >>>> arch/arm/boot/dts/qcom-sdx65.dtsi | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi >>>> index b073e0c63df4..d3c661d7650d 100644 >>>> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi >>>> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi >>>> @@ -219,7 +219,8 @@ blsp1_uart3: serial@831000 { >>>> }; >>>> >>>> usb_hsphy: phy@ff4000 { >>>> - compatible = "qcom,usb-snps-hs-7nm-phy"; >>>> + compatible = "qcom,sdx65-usb-hs-phy", >>>> + "qcom,usb-snps-hs-7nm-phy"; >>> Not sure if the newline is necessary, but still: >>> >>> Reviewed-by: Konrad Dybcio >> >> It is over 80 - up to 90 - and we still keep 80-limit in coding style. > Torvalds said 100 is fine a year a go or so. Yes - when it increases the readability. When it does not, the limit by coding style is still 80. Otherwise the coding style would be updated, which did not happen: https://lore.kernel.org/all/20220119160642.140e84c6@gandalf.local.home/ Best regards, Krzysztof