From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jon Hunter <jonathanh@nvidia.com>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers
Date: Tue, 23 Jan 2024 10:45:30 +0100 [thread overview]
Message-ID: <e19f2aa5-5040-4cab-8c67-557436883e40@linaro.org> (raw)
In-Reply-To: <a00a3d5f-9d96-4886-9ebe-4e2962667ab3@nvidia.com>
On 23/01/2024 10:20, Jon Hunter wrote:
>
> On 23/01/2024 08:35, Krzysztof Kozlowski wrote:
>> Regular expression used to match the unit address part should not allow
>> non-hex numbers.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> index f54e553e6c0e..71896cb10692 100644
>> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> @@ -145,7 +145,7 @@ patternProperties:
>> "^emc-table@[0-9]+$":
>> $ref: "#/$defs/emc-table"
>>
>> - "^emc-tables@[a-z0-9-]+$":
>> + "^emc-tables@[a-f0-9-]+$":
>> type: object
>> properties:
>> reg:
>
>
> Thanks! We could add the fixes tag ...
>
> Fixes: de3d7018372c dt-bindings: memory: tegra20: emc: Convert to schema
There is no bug here, really. At least no bug with impact, because dtc
won't allow DTS with non-hex numbers.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-23 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 8:35 [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers Krzysztof Kozlowski
2024-01-23 9:20 ` Jon Hunter
2024-01-23 9:45 ` Krzysztof Kozlowski [this message]
2024-01-25 11:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e19f2aa5-5040-4cab-8c67-557436883e40@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).