devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml
Date: Mon, 7 Oct 2024 09:03:27 +0200	[thread overview]
Message-ID: <e1aaf325-2bdc-4b3b-a955-35a313b44255@kernel.org> (raw)
In-Reply-To: <ZwN_2LsLep_mXUgy@gmail.com>

On 07/10/2024 08:29, Marcus Folkesson wrote:
> On Mon, Oct 07, 2024 at 08:07:27AM +0200, Krzysztof Kozlowski wrote:
>> On Sun, Oct 06, 2024 at 03:05:47PM +0200, Marcus Folkesson wrote:
>>> +  ti,davinci-nand-use-bbt:
>>> +    type: boolean
>>> +    description:
>>> +      Use flash based bad block table support. OOB identifier is saved in OOB
>>> +      area.
>>> +    deprecated: true
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - ti,davinci-chipselect
>>> +
>>> +additionalProperties: true
>>
>> That's a final device schema, this cannot be true. Why you are doing
>> this entirely different than all other bindings?
> 
> From my understanding, additionalProperties is to indicate that the
> schema could contain properties that were not explicit listed here but
> inherited from e.g. nand-controller.yaml.
> 
> Obviously that is not the case.
> Could you please give me some guidance?

I suggested - open any other binding. What is there? What was the exact
error automation reported to you *twice*?



Best regards,
Krzysztof


  reply	other threads:[~2024-10-07  7:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-06 13:05 [PATCH v4 0/2] Add support for "on-die" ECC on Davinci Marcus Folkesson
2024-10-06 13:05 ` [PATCH v4 1/2] mtd: nand: davinci: add support for on-die ECC engine type Marcus Folkesson
2024-10-06 13:05 ` [PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml Marcus Folkesson
2024-10-07  6:07   ` Krzysztof Kozlowski
2024-10-07  6:29     ` Marcus Folkesson
2024-10-07  7:03       ` Krzysztof Kozlowski [this message]
2024-10-07  8:31       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1aaf325-2bdc-4b3b-a955-35a313b44255@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marcus.folkesson@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).