From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712E11509A0 for ; Tue, 7 May 2024 11:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715080023; cv=none; b=TM119IFtg1W4RPp3oS4hVczrA12cdzqSSPgmMdVY1dtbIiDgQQ/aJTUg0WwQcA0IFcAATwrjZl2XQZQVzoOju0PPvoAeNeGvjGK9TVQQVOAX4a2KR0gBpl45LLwt+j1H3S6iLNBi0HkS5hki0Yg0hw0wCHmXIVpH2JO+Apl983s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715080023; c=relaxed/simple; bh=0wthStaM0L1IEMjidKAObMHjHCckB8nsQgt387187UE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZNf/g3KPtfaUcTdXWfjk0OwSGG99oMe2Pi09uJFjgFug+Dq8koxJB3ridG1nF+vowQF+nw6wQXpnve5+CnS4TRj7by/J1jXeKN/W8qy5GfTUsTTvFnmajzMqqpIBHuanvnmuoCxUIynRELe+ELjLPRnwDocFiE1yx/3dZwR3Cds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DjbvWXXS; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DjbvWXXS" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2e30c625178so26857451fa.1 for ; Tue, 07 May 2024 04:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715080018; x=1715684818; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vu3E57enROBhkqZ25vaLZg3w8R1eCilIpWi4uX7bS5I=; b=DjbvWXXSHAEEzyvHkXXH/E7lcMDOaq9rKhpNeikRSahjxHmcdpE+aZbSTZRFd0Hh2x W2BIQOkswQRIsP5zr5Cq5dY0lOO4et3Wau+e6qL6iwn3eOwPK7FytbFKHmUGamT4FGiV E1WKBrj/N35fgoYt4ycwNW9UK8WKvgGfjMjT3ugrWPM+O93DJi8+YGRQKzA+HfKfF1fq rbRWkb4/w+wyTDEyRZPdfCDJO/HXep8UNfUtK1L7O+AXgzBXMQeqiBZqEWpwWruZr+kH TW0wVCt/fQiC0nZIjweWbrOmLIgyYSKyNIwq8cOVET077Q0BgQCdMisKFdFWjQDPqY92 W9Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715080018; x=1715684818; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vu3E57enROBhkqZ25vaLZg3w8R1eCilIpWi4uX7bS5I=; b=VwO4Cfh62AskX/xGRfGFdrLutSTFs62FHbTTqFCKXH4Jw0rc1DPd7R5eJ0+ZpUhK7G r6ZQARdMckBLDElAZea+vmBgr3W8Q/R4o4wxKxMPixCoC75EQxqUpVQ0i5RD7otLwiro YTOFkD26BhIrfYbCdHETU4n7z2q1wR3vGbIjYVkVvdejXfw4lrZkP68jg8MZsKGrz/sA L1TlVFCG5VOLZxT1qos/c+XdenVDmtrzScmFTkNOZoBj3YiOgJqaDR5Vf4wRV/9zRhq6 SrD0FLxeduKoO/y8nxJWpBUHShyfCnGsDgbTcWtynGetrensPhj0Kea1rqgMutNJ9tVs i/cA== X-Forwarded-Encrypted: i=1; AJvYcCU3XJTZV2zTaGkgHATsmtRPkg3753uSmmW8LxTXjCrXd4XqUPH+R9TKO0tMp1MNrNEF7Wux7z5H4bAncuOKkfH7WTHsajpUK6tA7A== X-Gm-Message-State: AOJu0Yw25Y8QUSKwOGFSxpk+Z+BrWEgatDZW/iJfDd07b74ZLoFS4Ifn 7OZMRh2uHo9q5VglQf9S38437/jlBwZpqFnWUesnJST0P/F/VtKU3UslyDBvPhc= X-Google-Smtp-Source: AGHT+IExp0qXNrJyw996e89disi8phPXmFYED+G9fNF42W0b5gF5pUVkJQl64hC5epdp7ic0/3TADw== X-Received: by 2002:a2e:9153:0:b0:2da:15cf:1e23 with SMTP id q19-20020a2e9153000000b002da15cf1e23mr7938406ljg.17.1715080018522; Tue, 07 May 2024 04:06:58 -0700 (PDT) Received: from [172.30.205.144] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id e3-20020a2e9e03000000b002d6daf3b41fsm1906226ljk.101.2024.05.07.04.06.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 May 2024 04:06:57 -0700 (PDT) Message-ID: Date: Tue, 7 May 2024 13:06:54 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi To: Marc Gonzalez , Bjorn Andersson , Kalle Valo , Jeff Johnson , ath10k Cc: wireless , DT , MSM , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson , Arnaud Vrac , Jami Kettunen , Jeffrey Hugo , Dmitry Baryshkov , Alexey Minnekhanov References: <0914f96e-fcfd-4088-924a-fc1991bce75f@freebox.fr> <02592b09-8ab5-42ab-bd6b-6db79722d708@freebox.fr> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <02592b09-8ab5-42ab-bd6b-6db79722d708@freebox.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/6/24 12:39, Marc Gonzalez wrote: > On 29/04/2024 16:07, Marc Gonzalez wrote: > >> The ath10k driver waits for an "MSA_READY" indicator >> to complete initialization. If the indicator is not >> received, then the device remains unusable. >> >> cf. ath10k_qmi_driver_event_work() >> >> Several msm8998-based devices are affected by this issue. >> Oddly, it seems safe to NOT wait for the indicator, and >> proceed immediately when QMI_EVENT_SERVER_ARRIVE. >> >> Jeff Johnson wrote: >> >> The feedback I received was "it might be ok to change all ath10k qmi >> to skip waiting for msa_ready", and it was pointed out that ath11k >> (and ath12k) do not wait for it. >> >> However with so many deployed devices, "might be ok" isn't a strong >> argument for changing the default behavior. >> >> cf. also >> https://wiki.postmarketos.org/wiki/Qualcomm_Snapdragon_835_(MSM8998)#WLAN >> >> Signed-off-by: Marc Gonzalez >> --- >> arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi >> index 67b8374ddf02f..4e6245095adfc 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi >> @@ -3234,6 +3234,7 @@ wifi: wifi@18800000 { >> iommus = <&anoc2_smmu 0x1900>, >> <&anoc2_smmu 0x1901>; >> qcom,snoc-host-cap-8bit-quirk; >> + qcom,no-msa-ready-indicator; >> }; >> }; >> }; > > > Bjorn, > > This patch is supposed to go through your tree, right? Reviewed-by: Konrad Dybcio Konrad