From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Austin, Brian" Subject: Re: [PATCH 1/5] ASoC: cs35l35: Add missing return in probe Date: Wed, 8 Mar 2017 19:55:36 +0000 Message-ID: References: <1488991371-22513-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1488991371-22513-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Charles Keepax , "broonie@kernel.org" Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , "patches@opensource.wolfsonmicro.com" , "lgirdwood@gmail.com" , "robh+dt@kernel.org" List-Id: devicetree@vger.kernel.org On 3/8/17, 10:42 AM, "alsa-devel-bounces@alsa-project.org on behalf of Charles Keepax" wrote: >A return statement is missing just before the error paths at the end of >probe. This causes us to fall straight into the error path and disable >the supplies and re-enable reset, as these are only controlled during >probe this causes the part to no longer function. > >Signed-off-by: Charles Keepax >--- For the series Acked-by: Brian Austin