From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA84BCCA480 for ; Wed, 20 Jul 2022 17:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233286AbiGTROW (ORCPT ); Wed, 20 Jul 2022 13:14:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239876AbiGTROS (ORCPT ); Wed, 20 Jul 2022 13:14:18 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E29346EEA3 for ; Wed, 20 Jul 2022 10:14:16 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id w17so21881825ljh.6 for ; Wed, 20 Jul 2022 10:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=5RkpDfJmyBWfRHg2fVFR+/EdZ4rlvuqSFEKHbwoMbsM=; b=H+7FhV05lIhk0PGB4Z6gEALJjTiEw084oSQ2Ud8MgD/y8JOhBTo9CTroBwwYaV4KRf wo+T2+13vBg07aE5ZDkkmJIQREcaPEvxHTDK2GeS9txCcnfFeII3xhclMU7qdpgTtKpq Qv6x+YINWQAxvFegcEHp6NxYwoRPU6CirCLgAxMLhcSDQ2VkFe0yR+YwsEa4iv3KZpDf 4S8Mu6emImwTEBRYFM5m/GSpYwNK9vR4HZsbk/6xWL0+7eMGpVBpFy+QpHoXc9ERr5CT +PZtNyIhcUhtAVC3NpzD3jCYEfxQ3IWW0HE8xTYTeZoSA1ssGYiIlzIpiARAdMOO2xNu wMIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5RkpDfJmyBWfRHg2fVFR+/EdZ4rlvuqSFEKHbwoMbsM=; b=DEQb9Smd4pJoMuZnj9wTyOOrJ5GjNthNJ6D9qaanrYauvBd4MxlF7K0INuP1PI6+2G BCTSlYpJPm/Mu+rXtRCs1p6YLyW4g8LH+8pZdy5KKIHe1UmyD6kKK+hJqqLJC1b7kn/m nqU/3PFOIWW2ue2oEaBou6jMeDL0SClKdN/TlpPTXAFs7Apt9V3bBTMeiqx6eYwIIHP7 yN+D5OG0LG+iJFb8zOgWH8jCl17bQ4PJvjp6hi2Ehr0ub7ImW4KbEJmDuFN3Oc+Kg9Cv MpVfMqtaHsL/Ia6xyH3DTqqolx3rIqre0IqrSqE3CeZL3jFQ2aJKFkbpY03UbCVFFBDv tqcA== X-Gm-Message-State: AJIora96lyynwkvb7/W2fIsWhvtggGwz/X19eDDyh84liUf3JiLYkaTf oWWLhv7iZs6ERf79ICjUtZOIFw== X-Google-Smtp-Source: AGRyM1slZ6hO/HAIyCG+31XwLnAM/4pQ8U2rWmJCFJJE6uLFgNQ5+vsUtnCPoRcx6jCpEMRuF7B7KQ== X-Received: by 2002:a2e:9ed6:0:b0:25d:5cef:72c3 with SMTP id h22-20020a2e9ed6000000b0025d5cef72c3mr16423219ljk.381.1658337255308; Wed, 20 Jul 2022 10:14:15 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id d25-20020a19e619000000b00489c7fb668dsm3901824lfh.182.2022.07.20.10.14.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 10:14:14 -0700 (PDT) Message-ID: Date: Wed, 20 Jul 2022 19:14:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 2/6] dt-bindings: mediatek,mt6779-keypad: use unevaluatedProperties Content-Language: en-US To: Mattijs Korpershoek , Rob Herring , Krzysztof Kozlowski , Dmitry Torokhov , Matthias Brugger Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent , linux-arm-kernel@lists.infradead.org References: <20220720-mt8183-keypad-v1-0-ef9fc29dbff4@baylibre.com> <20220720-mt8183-keypad-v1-2-ef9fc29dbff4@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220720-mt8183-keypad-v1-2-ef9fc29dbff4@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/07/2022 16:48, Mattijs Korpershoek wrote: > writing-bindings.rst states: >> - If schema includes other schema (e.g. /schemas/i2c/i2c-controller.yaml) use >> "unevaluatedProperties:false". In other cases, usually use >> "additionalProperties:false". > > mt6779-keypad includes matrix-keymap.yaml so replace additionalProperties:false > by unevaluatedProperties:false. This is not sufficient explanation. You now allow all properties from matrix-keymap.yaml, which might be desired or might be not (e.g. they are not valid for this device). Please investigate it and mention the outcome. Best regards, Krzysztof