From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB6FC54EBC for ; Wed, 11 Jan 2023 15:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234872AbjAKP6u (ORCPT ); Wed, 11 Jan 2023 10:58:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233529AbjAKP6r (ORCPT ); Wed, 11 Jan 2023 10:58:47 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35FB5DF3C for ; Wed, 11 Jan 2023 07:58:46 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id bf43so24228367lfb.6 for ; Wed, 11 Jan 2023 07:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YUP9M1dJhtlso5U1m3Rwn8hS3yu3g/oQrTNH6scnNKs=; b=gBlyyO+oLZgO/cIzR0dG9h/JjwDJYaQDY7cpNfsHTef4Vji5lFZzN6uXQMV96U6/ne smjkLpdoZ6nhC1cTeQT2iFPIIyWnLsZ5P7MnuQs/hLj0XvphPWLw02vFCqT+KeqX6tLy WJyZGaSVLyQDjZyON5JUNA7lfCPsZvmyD+hz2T9KdWDEc5w6yOm9cfK7e2xrMXdFXZ+y SbezmzF36eQN+s1YVvjCeVlbsrMoQJKqjERElv3vR7KMyvpLoG3Rji5SgZUdHkHwTmCH WjjFrPBeOPYbr/a54JzKp52QKor/+peGSyP0xTkYF5kXFyOnziwAjn1EYMP2RzGsyt7j v/Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YUP9M1dJhtlso5U1m3Rwn8hS3yu3g/oQrTNH6scnNKs=; b=Gp1xrrnmr3uecVuAhKhCzcGb/9kYoS/h8uoU7lmU63ybZJSwjFmOEWgiUq09k5BZwD ABqwBhRsZhmoCq5jSMboYVzY4ckVFh1nWCAyFWT+lu2k0JTTxXX1qM4Pwi5VjiH1qQdY 9RvaunAcx3jzHBLl90RTyum7F26SkmG5Z7uShneSa7iZArMQH/vB5pF6W2FMhnvi1lso pXTFOJmr65/QhPrG4VU+qu4lXkuXyznAwL7wHwvdCBTLpLspKaBBei/H/mxLID9bANrQ JErDCAYgQ13jRanMcC/w7E4FHMeCQQ620eKi1y7kh2qn3c84zf1TOJsthEbGB+nJUFvw 2wTg== X-Gm-Message-State: AFqh2kqlefugqD8OGJUaPXi6UVB4QB6jHH//E97ReSApbMONfdCa6y0I IfLv+e3ws6aRirFhGEnCF8bKnQ== X-Google-Smtp-Source: AMrXdXtncrDESfrykRgJw7M5y/Nd4d6yktAIkabE6EvX+HCcoGfAvgiPKa6kREMy0dGBUCWSG0uH4A== X-Received: by 2002:a05:6512:1687:b0:4cb:bf8:cf0e with SMTP id bu7-20020a056512168700b004cb0bf8cf0emr18440948lfb.19.1673452724550; Wed, 11 Jan 2023 07:58:44 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id l9-20020ac24a89000000b004cc99cd94basm329510lfp.113.2023.01.11.07.58.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 07:58:44 -0800 (PST) Message-ID: Date: Wed, 11 Jan 2023 17:58:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v8 1/5] dt-bindings: soc: qcom: cpr3: Add bindings for CPR3 driver Content-Language: en-GB To: Konrad Dybcio , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, angelogioacchino.delregno@collabora.com, AngeloGioacchino Del Regno , Rob Herring , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230110175605.1240188-1-konrad.dybcio@linaro.org> <20230110175605.1240188-2-konrad.dybcio@linaro.org> <889c3bce-8b88-3a0d-5aa0-1000d3dd26cd@linaro.org> <8463810e-a3bf-1303-6ca7-0945a5d6fc0d@linaro.org> From: Dmitry Baryshkov In-Reply-To: <8463810e-a3bf-1303-6ca7-0945a5d6fc0d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/01/2023 15:30, Konrad Dybcio wrote: > > > On 11.01.2023 03:18, Dmitry Baryshkov wrote: >> On 10/01/2023 20:54, Konrad Dybcio wrote: >>> >>> >>> On 10.01.2023 18:56, Konrad Dybcio wrote: >>>> From: AngeloGioacchino Del Regno >>>> >>>> Add the bindings for the CPR3 driver to the documentation. >>>> >>>> Reviewed-by: Rob Herring >>>> Signed-off-by: AngeloGioacchino Del Regno >>>> [Konrad: Add type reference to acc-syscon; update AGdR's email] >>>> Signed-off-by: Konrad Dybcio >>>> --- >>> Need to add >>> >>> qcom,opp-oloop-vadj >>> qcom,opp-cloop-vadj >> >> And note that at least for CPR3 they are different between fusing revisions. I see that for CPRh (esp. for 8998v2) they are the same, but this is not the case for 8996 (CPR3). > If we both mean the "speed bin"-dependent values, the driver > reads the fuse value but currently does nothing. My guess would > be that Angelo omitted it, as - just like you pointed out - MSM8998 > (and SDM660 for that matter) don't really use it. I suppose I could > take care of that in bindings by making this an array and handle it > separately in a different patchset, as the per-revision values > aren't *that much* different, and again aren't really of concern for > the first round of supported SoCs. No, there are two dimensions there: speed-bin and then cpr fusing_rev, see: ret = nvmem_cell_read_variable_le_u32(dev, "cpr_fuse_revision", &drv->fusing_rev); While the speed bin determines overall SoC performance characteristics, cpr_fuse_revision determines how we interpret the fuse values. E.g. on msm8996 some of loop adjustment values depend on fusing_rev. I interpreted this as 'the manufacturer could not decide on how to measure things'. May be we can support only the latest fusing rev (like we do for the SoC versions). But I can not guarantee that it would be enough. -- With best wishes Dmitry