From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: John Watts <contact@jookia.org>, dri-devel@lists.freedesktop.org
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Shawn Guo <shawnguo@kernel.org>,
Chris Morgan <macromorgan@hotmail.com>,
Jagan Teki <jagan@edgeble.ai>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 8/8] dt-bindings: display: panel: add Fascontek FS035VG158 panel
Date: Mon, 11 Sep 2023 11:41:12 +0200 [thread overview]
Message-ID: <e22e61e7-02b1-8127-888d-e470838f4a18@linaro.org> (raw)
In-Reply-To: <20230911090206.3121440-9-contact@jookia.org>
On 11/09/2023 11:02, John Watts wrote:
> This is a small 3.5" 640x480 IPS LCD panel.
>
> Signed-off-by: John Watts <contact@jookia.org>
> ---
Thank you for your patch. There is something to discuss/improve.
> +maintainers:
> + - John Watts <contact@jookia.org>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + const: fascontek,fs035vg158
> +
> + backlight: true
> + port: true
> + power-supply: true
> + reg: true
> + reset-gpios: true
Why do you need all these 5? They are allowed by panel-common.
> +
> + spi-3wire: true
> +
> +required:
> + - compatible
Missing reg. Probably also port.
> + - power-supply
> + - reset-gpios
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-11 20:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 9:01 [RFC PATCH 0/8] Add FS035VG158 panel John Watts
2023-09-11 9:01 ` [RFC PATCH 1/8] drm/panel: nv3052c: Document known register names John Watts
2023-09-13 21:43 ` Jessica Zhang
2023-09-14 4:12 ` John Watts
2023-09-14 20:27 ` Jessica Zhang
2023-09-11 9:02 ` [RFC PATCH 2/8] drm/panel: nv3052c: Add SPI device IDs John Watts
2023-09-15 21:50 ` Jessica Zhang
2023-09-11 9:02 ` [RFC PATCH 3/8] drm/panel: nv3052c: Sleep for 150ms after reset John Watts
2023-09-11 9:02 ` [RFC PATCH 4/8] drm/panel: nv3052c: Wait before entering sleep mode John Watts
2023-09-11 9:02 ` [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel John Watts
2023-09-13 21:34 ` Jessica Zhang
2023-09-14 4:09 ` John Watts
2023-09-14 20:22 ` Jessica Zhang
2023-09-15 21:23 ` Jessica Zhang
2023-09-11 9:02 ` [RFC PATCH 6/8] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display John Watts
2023-09-11 9:02 ` [RFC PATCH 7/8] dt-bindings: vendor-prefixes: Add fascontek John Watts
2023-09-11 9:41 ` Krzysztof Kozlowski
2023-09-11 9:02 ` [RFC PATCH 8/8] dt-bindings: display: panel: add Fascontek FS035VG158 panel John Watts
2023-09-11 9:41 ` Krzysztof Kozlowski [this message]
2023-09-11 9:49 ` John Watts
2023-09-11 11:49 ` Krzysztof Kozlowski
2023-09-11 16:47 ` John Watts
2023-09-12 6:55 ` Krzysztof Kozlowski
2023-09-12 8:56 ` John Watts
2023-09-17 20:24 ` John Watts
2023-09-18 12:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e22e61e7-02b1-8127-888d-e470838f4a18@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=contact@jookia.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).