From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Srinivas Kandagatla" <srini@kernel.org>
Cc: semen.protsenko@linaro.org, willmcvicker@google.com,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] soc: samsung: exynos-chipid: use devm action to unregister soc device
Date: Wed, 19 Nov 2025 13:13:57 +0100 [thread overview]
Message-ID: <e25b9f14-b583-434d-ac4f-364b962f0ed1@kernel.org> (raw)
In-Reply-To: <20251118-gs101-chipid-v2-3-e9f1e7460e35@linaro.org>
On 18/11/2025 14:56, Tudor Ambarus wrote:
> Simplify the unwinding of the soc device by using a devm action.
> Add the action before the exynos_asv_init() to avoid an explicit call
> to soc_device_unregister().
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> drivers/soc/samsung/exynos-chipid.c | 27 +++++++++++----------------
Can I take the cleanups before new GS support?
That's btw preferred order for all work. Fixes should be independent or
first in the patchset. Then cleanups before features/new support.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-19 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 13:56 [PATCH v2 0/7] soc: samsung: exynos-chipid: add gs101 support Tudor Ambarus
2025-11-18 13:56 ` [PATCH v2 1/7] dt-bindings: nvmem: add google,gs101-otp Tudor Ambarus
2025-11-18 13:56 ` [PATCH v2 2/7] soc: samsung: exynos-chipid: add google,gs101-otp support Tudor Ambarus
2025-11-18 13:56 ` [PATCH v2 3/7] soc: samsung: exynos-chipid: use devm action to unregister soc device Tudor Ambarus
2025-11-19 12:13 ` Krzysztof Kozlowski [this message]
2025-11-19 12:30 ` Tudor Ambarus
2025-11-18 13:56 ` [PATCH v2 4/7] soc: samsung: exynos-chipid: use dev_err_probe where appropiate Tudor Ambarus
2025-11-18 13:56 ` [PATCH v2 5/7] soc: samsung: exynos-chipid: rename method Tudor Ambarus
2025-11-18 13:56 ` [PATCH v2 6/7] soc: samsung: exynos-chipid: downgrade dev_info to dev_dbg for soc info Tudor Ambarus
2025-11-18 13:56 ` [PATCH v2 7/7] arm64: dts: exynos: gs101: add OTP node Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e25b9f14-b583-434d-ac4f-364b962f0ed1@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=srini@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox