From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FCFF16F27E for ; Tue, 6 Aug 2024 23:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722985500; cv=none; b=XSBnTcpr4VyHsC9Ueo6fCuZCcShPA0PT5Y6zX1/oNYkgS9VQfMQwkSVMJUnEZZ8pA92mRuSuIicvI5M5SLgM/wVxMrDVpG9MO8TRE29N7/VRFajcf56L084XLP6k0S86N14yvpMdG4sEgn066hek3+0Qwy22Wt5kbWsOuoZUSgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722985500; c=relaxed/simple; bh=eCHRZfbVih8dU7pR6xWQRl/juLSmaH8RtChWF+l8FCQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Pnc2E9x+ybTvrHLGEEBqbpd1YwDGJmrWz+mxJbqqAtgQmIcASadhPr6n2aH3IQE1e+r9xDaWXNxD9mRCx+bHATfRG/C6T+rm83yZTcr2n9wEvrUbZwgfHujSz8y1xQRrk09OFgOBCz7cK+nBeui1Samg4b0Jnhwg0hju3VbvLXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JMFqieiy; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JMFqieiy" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4281ca54fd3so7841615e9.2 for ; Tue, 06 Aug 2024 16:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722985496; x=1723590296; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=pVTzUvpo2J//Q7IWbA8OuCEthqk1HNLB6DJMBCparG0=; b=JMFqieiyZFZzLwuzGVnC6yuLWbsRouzjw87bCX2G4cDkTMiWOdm/HQ0VshXxe424sO EPkTuV7lkzRi0QzH0xFe69BcQJDRJSXKjjXPt4kS2oWCT3mz4DX4MyriF9KxLFxra87G 3Syhbpxb3RYkLPBh8hew3BBtS6ho8ex/b5UKrQaf4WjdMtUxAe0Pn2p1qdqUoA6rssvt 7FZGHcpcHQ8UavxwYSywuMNhp3T6t9ICg0uOQT52EV+06ZdBSoY+/oqtzL0AQz6vrRwS WGHnvIxAJn/TsLbajf4J+DvgOZgIEml+gAfSm9WXXGxxmHAgISzyXVUcuUhHNTKPRhmp AAQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722985496; x=1723590296; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pVTzUvpo2J//Q7IWbA8OuCEthqk1HNLB6DJMBCparG0=; b=RX5susJMy2bNCm1FNAuhQX9dqdqZMwQxUyJKHiQr4DXIiI7mlpiLhJ6hth7jKnS4v1 JWWwTvlk8kcW4dUFGFUTT5FhiHIfEyuDIQQtHxs3A8dvEtge3zCDK2x49IRtbv256Q2h Tfy5v7DIvYWgqXql5KtiXjM8VnZNoBZTJOvRY98VU2soHFB55DSv4lVlQugC4qQldrM1 WkYLVuJC5xCBrFZEOCVUX2UKjhJgzf6mQa2vW1nobW8iCdaEEgk2RUxWvUpKKGa+tWqO v8accjjqjUW2827NMyE1vPzhHrCTyMI5lBVzEx+dZwcxi6pUoSk+thAQ9od8x0QBrTb0 L/Pw== X-Forwarded-Encrypted: i=1; AJvYcCVqSo68j+vtWFx1O53KRgMMGCMtQnlAFz9P3+FOnx7eQ1TjUsmWvSLmmMeE7jEi+joT/+3rWcLhvhOePOKVbyEQmNDZfFCl5w9EUQ== X-Gm-Message-State: AOJu0YzuoSbCmjPZJhjypZNI0EzA0q30aXSfkxvD6vucjLyLgznZn47A yX/4qo93Nyu97Ecir0QecCbNi5CfI9hlrdkxdpXzDPLLefP3p/xPAGGdwDiwtnA= X-Google-Smtp-Source: AGHT+IG9YNHqbFX5l53AQ9wQth8ckoaQl2Thoi3GWV3148tXmmgL0gEm989pTRxvAg0gBDDK8748SQ== X-Received: by 2002:a05:600c:1ca9:b0:426:6f81:d235 with SMTP id 5b1f17b1804b1-428e6b037f1mr120214305e9.15.1722985495634; Tue, 06 Aug 2024 16:04:55 -0700 (PDT) Received: from [192.168.0.25] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbd059801sm14212373f8f.83.2024.08.06.16.04.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 16:04:55 -0700 (PDT) Message-ID: Date: Wed, 7 Aug 2024 00:04:54 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: sdm670: add camss and cci To: Richard Acayan , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org References: <20240806224219.71623-7-mailingradian@gmail.com> <20240806224219.71623-11-mailingradian@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240806224219.71623-11-mailingradian@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/08/2024 23:42, Richard Acayan wrote: > Add the camera subsystem and CCI used to interface with cameras on the > Snapdragon 670. > > Signed-off-by: Richard Acayan > + > + camcc: clock-controller@ad00000 { > + compatible = "qcom,sdm845-camcc"; > + reg = <0 0x0ad00000 0 0x10000>; > + clocks = <&rpmhcc RPMH_CXO_CLK>; > + clock-names = "bi_tcxo"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; > + You're adding camcc here too which is inconsistent with the commit log. Personally I'm a fan, perhaps the only fan, of very granular patches and I'd break this up - at a minimum into 1. Adding CAMCC 2. Adding CCI and CAMSS --- bod