[PATCH] ASoC: dt-bindings: nau8315: Convert to dtschema

[PATCH] ASoC: dt-bindings: nau8315: Convert to dtschema

[David Lin]

Convert the NAU8315 audio CODEC bindings to DT schema.

Signed-off-by: David Lin <CTLIN0@nuvoton.com>
---
 .../devicetree/bindings/sound/nau8315.txt     | 24 ----------
 .../bindings/sound/nuvoton,nau8315.yaml       | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/nau8315.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8315.yaml

diff --git a/Documentation/devicetree/bindings/sound/nau8315.txt b/Documentation/devicetree/bindings/sound/nau8315.txt
deleted file mode 100644
index 1cd94517d45e..000000000000
--- a/Documentation/devicetree/bindings/sound/nau8315.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-Nuvoton NAU8315 Mono Class-D Amplifier
-
-Required properties:
-- compatible   : "nuvoton,nau8315"
-                 "nuvoton,nau8318"
-
-Optional properties:
-- enable-gpios : GPIO specifier for the chip's device enable input(EN) pin.
-        If this option is not specified then driver does not manage
-        the pin state (e.g. chip is always on).
-
-Example:
-
-#include <dt-bindings/gpio/gpio.h>
-
-nau8315 {
-	compatible = "nuvoton,nau8315";
-	enable-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
-};
-
-nau8318 {
-	compatible = "nuvoton,nau8318";
-	enable-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
-};
diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8315.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8315.yaml
new file mode 100644
index 000000000000..24006e9dc501
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8315.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/nuvoton,nau8315.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NAU8315/NAU8318 Mono Class-D Amplifier
+
+maintainers:
+  - David Lin <CTLIN0@nuvoton.com>
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    enum:
+      - nuvoton,nau8315
+      - nuvoton,nau8318
+
+  '#sound-dai-cells':
+    const: 0
+
+  enable-gpios:
+    maxItems: 1
+    description:
+      GPIO specifier for the chip's device enable input(EN) pin.
+      If this option is not specified then driver does not manage
+      the pin state (e.g. chip is always on).
+
+required:
+  - compatible
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    codec {
+        compatible = "nuvoton,nau8315";
+        #sound-dai-cells = <0>;
+        enable-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
+    };
-- 
2.25.1

Re: [PATCH] ASoC: dt-bindings: nau8315: Convert to dtschema

[Krzysztof Kozlowski]

On 16/05/2023 07:49, David Lin wrote:
> Convert the NAU8315 audio CODEC bindings to DT schema.
> 
> Signed-off-by: David Lin <CTLIN0@nuvoton.com>
> ---


> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nuvoton,nau8315
> +      - nuvoton,nau8318
> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  enable-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO specifier for the chip's device enable input(EN) pin.
> +      If this option is not specified then driver does not manage
> +      the pin state (e.g. chip is always on).

The only thing driver is doing is to toggle this pin. If it is missing
the entire driver is noop, thus above comment is a bit funny. It
probably should be mandatory pin. But I see it was there since beginning
so ok.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH] ASoC: dt-bindings: nau8315: Convert to dtschema

[AS50 CTLin0]

On 5/17/2023 12:10 AM, Krzysztof Kozlowski wrote:
> On 16/05/2023 07:49, David Lin wrote:
>> Convert the NAU8315 audio CODEC bindings to DT schema.
>>
>> Signed-off-by: David Lin <CTLIN0@nuvoton.com>
>> ---
>
>> +allOf:
>> +  - $ref: dai-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - nuvoton,nau8315
>> +      - nuvoton,nau8318
>> +
>> +  '#sound-dai-cells':
>> +    const: 0
>> +
>> +  enable-gpios:
>> +    maxItems: 1
>> +    description:
>> +      GPIO specifier for the chip's device enable input(EN) pin.
>> +      If this option is not specified then driver does not manage
>> +      the pin state (e.g. chip is always on).
> The only thing driver is doing is to toggle this pin. If it is missing
> the entire driver is noop, thus above comment is a bit funny. It
> probably should be mandatory pin. But I see it was there since beginning
> so ok.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof


For "the chip is always on" might be make EN pin is always pull high in
the schematic.

so driver didn't need to manage it. Of course, this driver will just
have software switch.

Generally, the schematic will design an extra gpio for control.

>
________________________________
________________________________
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

Re: [PATCH] ASoC: dt-bindings: nau8315: Convert to dtschema

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

On Wed, May 17, 2023 at 11:28:46AM +0800, AS50 CTLin0 wrote:
> On 5/17/2023 12:10 AM, Krzysztof Kozlowski wrote:

> > The only thing driver is doing is to toggle this pin. If it is missing
> > the entire driver is noop, thus above comment is a bit funny. It
> > probably should be mandatory pin. But I see it was there since beginning
> > so ok.

No, it's not just that - the driver also describes the supported formats
and rates to the subsystem so we can constrain the DAI appropraitely.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: dt-bindings: nau8315: Convert to dtschema

[Mark Brown]

On Tue, 16 May 2023 13:49:45 +0800, David Lin wrote:
> Convert the NAU8315 audio CODEC bindings to DT schema.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: nau8315: Convert to dtschema
      commit: 268777caf0dd8d3c852cccb949ae73b7ea7b2f5e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark