From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0154EB64DA for ; Wed, 5 Jul 2023 11:09:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbjGELJF (ORCPT ); Wed, 5 Jul 2023 07:09:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231562AbjGELJD (ORCPT ); Wed, 5 Jul 2023 07:09:03 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6927A1727 for ; Wed, 5 Jul 2023 04:09:00 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b69f71a7easo107184741fa.1 for ; Wed, 05 Jul 2023 04:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688555338; x=1691147338; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8cYA7q56z8UCDFhXJUoPF4Hs2h/3aSmBTFzm6jnknrI=; b=Y+xZrKQcxcOAXxkre6DCpqb6au1aqmB8vgKFGj85xzIzfOiymDrBqiZtj/UhLqDm3K OVzjRe6GslLdtfRjP1KeSmTBsp33eRyFyW4UVguQ9XQjYUoPrpFMaDlg7cQxBzFl/2AD lsbVymnq8oN5KL2oKe89XYM7anov0NoroISe65jydA8HbwudDn6VzZqba8ZqBEPyZFr3 JN/Vw3gFp9E+yks3bk8OLaqTTlcEVzM6IxDEmKaFD0og2n6mSksoLEwexfolf5Lgkpk0 3bzCmKDIqpO/X2FbOOvynQ9EURWPNejkkDBdICBUg+Wsa1AsLWIIPyB5x7sdUvwKeOIw PUIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688555338; x=1691147338; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8cYA7q56z8UCDFhXJUoPF4Hs2h/3aSmBTFzm6jnknrI=; b=jtDGw6m1Ug6l23vFuxen5Wr7K6mdRrI1mRAXECbFVh3u4/MX7qdMZ6T6fw2nc/4CCm 1kWdSlrtRVOgy7r8Nn6zJnpMrEbCPrAUe5mvo0lFMJDb/t606UL1uRTp8I4JuphKWjJa JPgtCJuC0Ewte3AlPyRLqgm55SGM5gpvXsKvSUvr2oUvRz0PdFmkl6BZBWmAuVSmHqts pxrVFGGyAdQbDdKD7a9N3m2Ay3eHCo7BSwFQlVGY6jJ13rt99yqONBpSolKhsbZgnz31 rqGp3PYZC2k5VnLCwF23yDYqWy38LjfSApWE3nY8sHzwMsTwSm3rTF5JOpsmrPj8akAX wXpQ== X-Gm-Message-State: ABy/qLao4EhKgLDvLG9B4+sqrjzcQ1hGxV0prkPfcwfYv+I4rRfne9VX v7zPa02RoHjZOUXaLXM9sy3kUQ== X-Google-Smtp-Source: APBJJlFrZLcEbIW4U3eWNaqsqfzHNx73Dkh7DONT0KurkHuqw2NSgkKEkyeBHR4apfFEItXNygI+Cw== X-Received: by 2002:a05:6512:2006:b0:4fb:751a:98d5 with SMTP id a6-20020a056512200600b004fb751a98d5mr9981330lfb.18.1688555338635; Wed, 05 Jul 2023 04:08:58 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id er20-20020a05651248d400b004fad8b001f0sm5238764lfb.253.2023.07.05.04.08.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 04:08:58 -0700 (PDT) Message-ID: Date: Wed, 5 Jul 2023 13:08:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region Content-Language: en-US To: Dmitry Baryshkov , Komal Bajaj Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230705053914.9759-1-quic_kbajaj@quicinc.com> <20230705053914.9759-2-quic_kbajaj@quicinc.com> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5.07.2023 11:42, Dmitry Baryshkov wrote: > On Wed, 5 Jul 2023 at 10:06, Komal Bajaj wrote: >> >> >> >> On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote: >>> On Wed, 5 Jul 2023 at 08:40, Komal Bajaj wrote: >>>> Add missing reserved regions as described in QDU1000 memory map. >>>> >>>> Signed-off-by: Komal Bajaj >>>> --- >>>> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> index 1d22f87fd238..3f5512ec0a90 100644 >>>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> @@ -448,6 +448,32 @@ &qupv3_id_0 { >>>> status = "okay"; >>>> }; >>>> >>>> +&reserved_memory{ >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>>> + ranges; >>>> + >>>> + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ >>> no_underscores_in_node_names. Ever. >>> >>> Also, if you have checked other platforms, you'd have seen that other >>> platforms use a much more generic node name for 'memory' nodes (which >>> you should have used too). >> >> These memory nodes are new to QDU platform, so will it be okay if I keep >> these names without region suffix? > > Just use 'memory@abcd'. Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml Following the generic-names recommended practice, node names should reflect the purpose of the node (ie. "framebuffer" or "dma-pool"). Unit address (@
) should be appended to the name if the node is a static allocation. Konrad > >> >> Thanks >> Komal >> >>> >>>> + no-map; >>>> + reg = <0x0 0xe0000000 0x0 0x20000000>; >>>> + }; >>>> + >>>> + harq_buffer_mem:harq_buffer_region@800000000{ >>>> + no-map; >>>> + reg = <0x8 0x0 0x0 0x80000000>; >>>> + }; >>>> + >>>> + tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{ >>>> + no-map; >>>> + reg = <0x8 0x80000000 0x0 0x50000000>; >>>> + }; >>>> + >>>> + fapi_buffer_mem:fapi_buffer_region@8d0000000{ >>>> + no-map; >>>> + reg = <0x8 0xd0000000 0x0 0x20000000>; >>>> + }; >>>> +}; >>>> + >>>> &sdhc { >>>> pinctrl-0 = <&sdc_on_state>; >>>> pinctrl-1 = <&sdc_off_state>; >>>> -- >>>> 2.40.1 >>>> >>> >> > >