[net-next RFC PATCH 1/2] dt-bindings: net: Document support for Airoha AN7583 MDIO Controller

[net-next RFC PATCH 1/2] dt-bindings: net: Document support for Airoha AN7583 MDIO Controller

[Christian Marangi]

Airoha AN7583 SoC have 3 different MDIO Controller. One comes from
the intergated Switch based on MT7530. The other 2 live under the SCU
register and expose 2 dedicated MDIO controller.

Document the schema that expose the 2 dedicated MDIO controller.
Each MDIO controller can be independently reset with the SoC reset line.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 .../bindings/net/airoha,an7583-mdio.yaml      | 78 +++++++++++++++++++
 1 file changed, 78 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/airoha,an7583-mdio.yaml

diff --git a/Documentation/devicetree/bindings/net/airoha,an7583-mdio.yaml b/Documentation/devicetree/bindings/net/airoha,an7583-mdio.yaml
new file mode 100644
index 000000000000..2375f1bf85a2
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/airoha,an7583-mdio.yaml
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/airoha,an7583-mdio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Airoha AN7583 Dedicated MDIO Controller
+
+maintainers:
+  - Christian Marangi <ansuelsmth@gmail.com>
+
+description:
+  Airoha AN7583 SoC have 3 different MDIO Controller.
+
+  One comes from the intergated Switch based on MT7530.
+
+  The other 2 (that this schema describe) live under the SCU
+  register supporting both C22 and C45 PHYs.
+
+properties:
+  compatible:
+    const: airoha,an7583-mdio
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+patternProperties:
+  '^mdio(-(bus|external))@[0-1]$':
+    type: object
+
+    $ref: mdio.yaml#
+
+    properties:
+      reg:
+        minimum: 0
+        maximum: 1
+
+      resets:
+        maxItems: 1
+
+    required:
+      - reg
+
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - "#address-cells"
+  - "#size-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    mdio-controller {
+        compatible = "airoha,an7583-mdio";
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        mdio-bus@0 {
+            reg = <0>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            ethernet-phy@1f {
+                reg = <31>;
+            };
+        };
+
+        mdio-bus@1 {
+            reg = <1>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+        };
+    };
-- 
2.48.1

[net-next RFC PATCH 2/2] net: mdio: Add MDIO bus controller for Airoha AN7583

[Christian Marangi]

Airoha AN7583 SoC have 2 dedicated MDIO bus controller in the SCU
register map. To driver expose the 2 MDIO controller based on the DT
node and access the register by accessing the parent syscon.

The MDIO bus logic is similar to the MT7530 internal MDIO bus but
deviates of some setting to enable MDIO fast mode and some difference
for CL45 handling.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 drivers/net/mdio/Kconfig       |   7 +
 drivers/net/mdio/Makefile      |   1 +
 drivers/net/mdio/mdio-airoha.c | 275 +++++++++++++++++++++++++++++++++
 3 files changed, 283 insertions(+)
 create mode 100644 drivers/net/mdio/mdio-airoha.c

diff --git a/drivers/net/mdio/Kconfig b/drivers/net/mdio/Kconfig
index 7db40aaa079d..e1e32b687068 100644
--- a/drivers/net/mdio/Kconfig
+++ b/drivers/net/mdio/Kconfig
@@ -27,6 +27,13 @@ config ACPI_MDIO
 	help
 	  ACPI MDIO bus (Ethernet PHY) accessors
 
+config MDIO_AIROHA
+	tristate "Airoha AN7583 MDIO bus controller"
+	depends on ARCH_AIROHA || COMPILE_TEST
+	help
+	  This module provides a driver for the MDIO busses found in the
+	  Airoha AN7583 SoC's.
+
 config MDIO_SUN4I
 	tristate "Allwinner sun4i MDIO interface support"
 	depends on ARCH_SUNXI || COMPILE_TEST
diff --git a/drivers/net/mdio/Makefile b/drivers/net/mdio/Makefile
index c23778e73890..fbec636700e7 100644
--- a/drivers/net/mdio/Makefile
+++ b/drivers/net/mdio/Makefile
@@ -5,6 +5,7 @@ obj-$(CONFIG_ACPI_MDIO)		+= acpi_mdio.o
 obj-$(CONFIG_FWNODE_MDIO)	+= fwnode_mdio.o
 obj-$(CONFIG_OF_MDIO)		+= of_mdio.o
 
+obj-$(CONFIG_MDIO_AIROHA)		+= mdio-airoha.o
 obj-$(CONFIG_MDIO_ASPEED)		+= mdio-aspeed.o
 obj-$(CONFIG_MDIO_BCM_IPROC)		+= mdio-bcm-iproc.o
 obj-$(CONFIG_MDIO_BCM_UNIMAC)		+= mdio-bcm-unimac.o
diff --git a/drivers/net/mdio/mdio-airoha.c b/drivers/net/mdio/mdio-airoha.c
new file mode 100644
index 000000000000..a30081f6141a
--- /dev/null
+++ b/drivers/net/mdio/mdio-airoha.c
@@ -0,0 +1,275 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Airoha AN7583 MDIO interface driver
+ *
+ * Copyright (C) 2025 Christian Marangi <ansuelsmth@gmail.com>
+ */
+
+#include <linux/delay.h>
+#include <linux/kernel.h>
+#include <linux/mfd/syscon.h>
+#include <linux/module.h>
+#include <linux/of_mdio.h>
+#include <linux/of_address.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/reset.h>
+
+#define AN7583_MAX_MDIO_BUS			2
+
+/* MII address register definitions */
+#define AN7583_MDIO0_ADDR			0xc8
+#define AN7583_MDIO1_ADDR			0xcc
+#define   AN7583_MII_BUSY			BIT(31)
+#define   AN7583_MII_RDY			BIT(30) /* RO signal BUS is ready */
+#define   AN7583_MII_CL22_REG_ADDR		GENMASK(29, 25)
+#define   AN7583_MII_CL45_DEV_ADDR		AN7583_MII_CL22_REG_ADDR
+#define   AN7583_MII_PHY_ADDR			GENMASK(24, 20)
+#define   AN7583_MII_CMD			GENMASK(19, 18)
+#define   AN7583_MII_CMD_CL22_WRITE		FIELD_PREP_CONST(AN7583_MII_CMD, 0x1)
+#define   AN7583_MII_CMD_CL22_READ		FIELD_PREP_CONST(AN7583_MII_CMD, 0x2)
+#define   AN7583_MII_CMD_CL45_ADDR		FIELD_PREP_CONST(AN7583_MII_CMD, 0x0)
+#define   AN7583_MII_CMD_CL45_WRITE		FIELD_PREP_CONST(AN7583_MII_CMD, 0x1)
+#define   AN7583_MII_CMD_CL45_POSTREAD_INCADDR	FIELD_PREP_CONST(AN7583_MII_CMD, 0x2)
+#define   AN7583_MII_CMD_CL45_READ		FIELD_PREP_CONST(AN7583_MII_CMD, 0x3)
+#define   AN7583_MII_ST				GENMASK(17, 16)
+#define   AN7583_MII_ST_CL45			FIELD_PREP_CONST(AN7583_MII_ST, 0x0)
+#define   AN7583_MII_ST_CL22			FIELD_PREP_CONST(AN7583_MII_ST, 0x1)
+#define   AN7583_MII_RWDATA			GENMASK(15, 0)
+#define   AN7583_MII_CL45_REG_ADDR		AN7583_MII_RWDATA
+#define AN7583_MDIO_PHY				0xd4
+#define   AN7583_MDIO1_SPEED_MODE		BIT(11)
+#define   AN7583_MDIO0_SPEED_MODE		BIT(10)
+
+#define AN7583_MII_MDIO_DELAY_USEC		100
+#define AN7583_MII_MDIO_RETRY_MSEC		100
+
+static const u32 airoha_mdio_bus_base_addrs[] = {
+	AN7583_MDIO0_ADDR,
+	AN7583_MDIO1_ADDR,
+};
+
+static const u32 airoha_mdio_bus_speed_mode[] = {
+	AN7583_MDIO0_SPEED_MODE,
+	AN7583_MDIO1_SPEED_MODE,
+};
+
+struct airoha_mdio_data {
+	u32 base_addr;
+	struct regmap *regmap;
+	struct reset_control *reset;
+};
+
+static int
+airoha_mdio_wait_busy(struct airoha_mdio_data *priv)
+{
+	u32 busy;
+
+	return regmap_read_poll_timeout(priv->regmap, priv->base_addr, busy,
+					!(busy & AN7583_MII_BUSY),
+					AN7583_MII_MDIO_DELAY_USEC,
+					AN7583_MII_MDIO_RETRY_MSEC * USEC_PER_MSEC);
+}
+
+static int airoha_mdio_read(struct mii_bus *bus, int addr, int regnum)
+{
+	struct airoha_mdio_data *priv = bus->priv;
+	u32 val;
+	int ret;
+
+	val = AN7583_MII_BUSY | AN7583_MII_ST_CL22 |
+	      AN7583_MII_CMD_CL22_READ;
+	val |= FIELD_PREP(AN7583_MII_PHY_ADDR, addr);
+	val |= FIELD_PREP(AN7583_MII_CL22_REG_ADDR, regnum);
+
+	ret = regmap_write(priv->regmap, priv->base_addr, val);
+	if (ret)
+		return ret;
+
+	ret = airoha_mdio_wait_busy(priv);
+	if (ret)
+		return ret;
+
+	ret = regmap_read(priv->regmap, priv->base_addr, &val);
+	if (ret)
+		return ret;
+
+	return FIELD_GET(AN7583_MII_RWDATA, val);
+}
+
+static int airoha_mdio_write(struct mii_bus *bus, int addr, int regnum,
+			     u16 value)
+{
+	struct airoha_mdio_data *priv = bus->priv;
+	u32 val;
+	int ret;
+
+	val = AN7583_MII_BUSY | AN7583_MII_ST_CL22 |
+	      AN7583_MII_CMD_CL22_WRITE;
+	val |= FIELD_PREP(AN7583_MII_PHY_ADDR, addr);
+	val |= FIELD_PREP(AN7583_MII_CL22_REG_ADDR, regnum);
+	val |= FIELD_PREP(AN7583_MII_RWDATA, value);
+
+	ret = regmap_write(priv->regmap, priv->base_addr, val);
+	if (ret)
+		return ret;
+
+	ret = airoha_mdio_wait_busy(priv);
+
+	return ret;
+}
+
+static int airoha_mdio_cl45_read(struct mii_bus *bus, int addr, int devnum,
+				 int regnum)
+{
+	struct airoha_mdio_data *priv = bus->priv;
+	u32 val;
+	int ret;
+
+	val = AN7583_MII_BUSY | AN7583_MII_ST_CL45 |
+	      AN7583_MII_CMD_CL45_ADDR;
+	val |= FIELD_PREP(AN7583_MII_PHY_ADDR, addr);
+	val |= FIELD_PREP(AN7583_MII_CL45_DEV_ADDR, devnum);
+	val |= FIELD_PREP(AN7583_MII_CL45_REG_ADDR, regnum);
+
+	ret = regmap_write(priv->regmap, priv->base_addr, val);
+	if (ret)
+		return ret;
+
+	ret = airoha_mdio_wait_busy(priv);
+	if (ret)
+		return ret;
+
+	val = AN7583_MII_BUSY | AN7583_MII_ST_CL45 |
+	      AN7583_MII_CMD_CL45_READ;
+	val |= FIELD_PREP(AN7583_MII_PHY_ADDR, addr);
+	val |= FIELD_PREP(AN7583_MII_CL45_DEV_ADDR, devnum);
+
+	ret = regmap_write(priv->regmap, priv->base_addr, val);
+	if (ret)
+		return ret;
+
+	ret = airoha_mdio_wait_busy(priv);
+	if (ret)
+		return ret;
+
+	ret = regmap_read(priv->regmap, priv->base_addr, &val);
+	if (ret)
+		return ret;
+
+	return FIELD_GET(AN7583_MII_RWDATA, val);
+}
+
+static int airoha_mdio_cl45_write(struct mii_bus *bus, int addr, int devnum,
+				  int regnum, u16 value)
+{
+	struct airoha_mdio_data *priv = bus->priv;
+	u32 val;
+	int ret;
+
+	val = AN7583_MII_BUSY | AN7583_MII_ST_CL45 |
+	      AN7583_MII_CMD_CL45_ADDR;
+	val |= FIELD_PREP(AN7583_MII_PHY_ADDR, addr);
+	val |= FIELD_PREP(AN7583_MII_CL45_DEV_ADDR, devnum);
+	val |= FIELD_PREP(AN7583_MII_CL45_REG_ADDR, regnum);
+
+	ret = regmap_write(priv->regmap, priv->base_addr, val);
+	if (ret)
+		return ret;
+
+	ret = airoha_mdio_wait_busy(priv);
+	if (ret)
+		return ret;
+
+	val = AN7583_MII_BUSY | AN7583_MII_ST_CL45 |
+	      AN7583_MII_CMD_CL45_WRITE;
+	val |= FIELD_PREP(AN7583_MII_PHY_ADDR, addr);
+	val |= FIELD_PREP(AN7583_MII_CL45_DEV_ADDR, devnum);
+	val |= FIELD_PREP(AN7583_MII_RWDATA, value);
+
+	ret = regmap_write(priv->regmap, priv->base_addr, val);
+	if (ret)
+		return ret;
+
+	ret = airoha_mdio_wait_busy(priv);
+
+	return ret;
+}
+
+static int airoha_mdio_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct airoha_mdio_data *priv;
+	struct mii_bus *bus;
+	int ret;
+
+	if (of_get_child_count(dev->of_node) > AN7583_MAX_MDIO_BUS)
+		return -EINVAL;
+
+	for_each_child_of_node_scoped(dev->of_node, child) {
+		u32 id;
+
+		ret = of_property_read_u32(child, "reg", &id);
+		if (ret)
+			return ret;
+
+		if (id > AN7583_MAX_MDIO_BUS)
+			return -EINVAL;
+
+		bus = devm_mdiobus_alloc_size(dev, sizeof(*priv));
+		if (!bus)
+			return -ENOMEM;
+
+		priv = bus->priv;
+		priv->base_addr = airoha_mdio_bus_base_addrs[id];
+		priv->regmap = device_node_to_regmap(dev->parent->of_node);
+		priv->reset = devm_reset_control_get_optional(&pdev->dev, NULL);
+		if (IS_ERR(priv->reset))
+			return PTR_ERR(priv->reset);
+
+		reset_control_deassert(priv->reset);
+
+		bus->name = "airoha_mdio_bus";
+		snprintf(bus->id, MII_BUS_ID_SIZE, "%s-%d-mii",
+			 dev_name(dev), id);
+		bus->parent = dev;
+		bus->read = airoha_mdio_read;
+		bus->write = airoha_mdio_write;
+		bus->read_c45 = airoha_mdio_cl45_read;
+		bus->write_c45 = airoha_mdio_cl45_write;
+
+		ret = devm_of_mdiobus_register(dev, bus, child);
+		if (ret) {
+			reset_control_assert(priv->reset);
+			return ret;
+		}
+
+		ret = regmap_set_bits(priv->regmap, AN7583_MDIO_PHY,
+				      airoha_mdio_bus_speed_mode[id]);
+		if (ret) {
+			reset_control_assert(priv->reset);
+			return ret;
+		}
+	}
+
+	return 0;
+}
+
+static const struct of_device_id airoha_mdio_dt_ids[] = {
+	{ .compatible = "airoha,an7583-mdio" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, airoha_mdio_dt_ids);
+
+static struct platform_driver airoha_mdio_driver = {
+	.probe = airoha_mdio_probe,
+	.driver = {
+		.name = "airoha-mdio",
+		.of_match_table = airoha_mdio_dt_ids,
+	},
+};
+
+module_platform_driver(airoha_mdio_driver);
+
+MODULE_DESCRIPTION("Airoha AN7583 MDIO interface driver");
+MODULE_AUTHOR("Christian Marangi <ansuelsmth@gmail.com>");
+MODULE_LICENSE("GPL");
-- 
2.48.1

Re: [net-next RFC PATCH 2/2] net: mdio: Add MDIO bus controller for Airoha AN7583

[Andrew Lunn]

> +#define AN7583_MDIO_PHY				0xd4
> +#define   AN7583_MDIO1_SPEED_MODE		BIT(11)
> +#define   AN7583_MDIO0_SPEED_MODE		BIT(10)

Is there any documentation about what these bits do? The bus should
default to 2.5Mhz.

	Andrew

Re: [net-next RFC PATCH 2/2] net: mdio: Add MDIO bus controller for Airoha AN7583

[Christian Marangi]

On Wed, May 28, 2025 at 12:36:46AM +0200, Andrew Lunn wrote:
> > +#define AN7583_MDIO_PHY				0xd4
> > +#define   AN7583_MDIO1_SPEED_MODE		BIT(11)
> > +#define   AN7583_MDIO0_SPEED_MODE		BIT(10)
> 
> Is there any documentation about what these bits do? The bus should
> default to 2.5Mhz.
>

No but I can ask. In theory tho these MDIO controller are used for 10g
or 2.5g PHY that all require a firmware to load so 2.5MHz makes the boot
time of 2+ minute.

The documentation say...

1: fast mode
0: normal mode

Very useful I guess :D

-- 
	Ansuel

Re: [net-next RFC PATCH 2/2] net: mdio: Add MDIO bus controller for Airoha AN7583

[Andrew Lunn]

On Wed, May 28, 2025 at 12:39:45AM +0200, Christian Marangi wrote:
> On Wed, May 28, 2025 at 12:36:46AM +0200, Andrew Lunn wrote:
> > > +#define AN7583_MDIO_PHY				0xd4
> > > +#define   AN7583_MDIO1_SPEED_MODE		BIT(11)
> > > +#define   AN7583_MDIO0_SPEED_MODE		BIT(10)
> > 
> > Is there any documentation about what these bits do? The bus should
> > default to 2.5Mhz.
> >
> 
> No but I can ask. In theory tho these MDIO controller are used for 10g
> or 2.5g PHY that all require a firmware to load so 2.5MHz makes the boot
> time of 2+ minute.
> 
> The documentation say...
> 
> 1: fast mode
> 0: normal mode
> 
> Very useful I guess :D

Can you put an oscilloscope on the clock line and measure it?

We have the DT property:

  clock-frequency:
    description:
      Desired MDIO bus clock frequency in Hz. Values greater than IEEE 802.3
      defined 2.5MHz should only be used when all devices on the bus support
      the given clock speed.

It would be good to default to normal mode, but allow fast to be
selected, once we know what it actually is.

	Andrew

Re: [net-next RFC PATCH 1/2] dt-bindings: net: Document support for Airoha AN7583 MDIO Controller

[Rob Herring]

On Tue, May 27, 2025 at 11:34:42PM +0200, Christian Marangi wrote:
> Airoha AN7583 SoC have 3 different MDIO Controller. One comes from
> the intergated Switch based on MT7530. The other 2 live under the SCU
> register and expose 2 dedicated MDIO controller.
> 
> Document the schema that expose the 2 dedicated MDIO controller.
> Each MDIO controller can be independently reset with the SoC reset line.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  .../bindings/net/airoha,an7583-mdio.yaml      | 78 +++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/airoha,an7583-mdio.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/airoha,an7583-mdio.yaml b/Documentation/devicetree/bindings/net/airoha,an7583-mdio.yaml
> new file mode 100644
> index 000000000000..2375f1bf85a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/airoha,an7583-mdio.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/airoha,an7583-mdio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha AN7583 Dedicated MDIO Controller
> +
> +maintainers:
> +  - Christian Marangi <ansuelsmth@gmail.com>
> +
> +description:
> +  Airoha AN7583 SoC have 3 different MDIO Controller.
> +
> +  One comes from the intergated Switch based on MT7530.
> +
> +  The other 2 (that this schema describe) live under the SCU
> +  register supporting both C22 and C45 PHYs.
> +
> +properties:
> +  compatible:
> +    const: airoha,an7583-mdio
> +

No registers? Looks to me like this middle node should go and the SCU 
node should have 2 mdio child nodes at 0xc8 and 0xcc.

It looks like you'll need to define the speed mode bit location somehow 
as well.

> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  '^mdio(-(bus|external))@[0-1]$':

Just '^mdio@[0-1]$'

If you need to distinguish external or something, use compatible or 
something.

> +    type: object
> +
> +    $ref: mdio.yaml#
> +
> +    properties:
> +      reg:
> +        minimum: 0
> +        maximum: 1
> +
> +      resets:
> +        maxItems: 1
> +
> +    required:
> +      - reg
> +
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    mdio-controller {
> +        compatible = "airoha,an7583-mdio";
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mdio-bus@0 {
> +            reg = <0>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            ethernet-phy@1f {
> +                reg = <31>;
> +            };
> +        };
> +
> +        mdio-bus@1 {
> +            reg = <1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +        };
> +    };
> -- 
> 2.48.1
>