From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Aniket <aniketmaurya@google.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Joel Stanley <joel@jms.id.au>,
Billy Tsai <billy_tsai@aspeedtech.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: i3c: dw: Add property to select IBI ops
Date: Wed, 26 Jun 2024 13:31:03 +0800 [thread overview]
Message-ID: <e28ba03d1df1c0c5aec987411c40e44fc351ce0d.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240626052238.1577580-2-aniketmaurya@google.com>
Hi Aniket,
> Use this property to select IBI related ops in the base platform
> driver. Otherwise the driver defaults to return EINVAL for any IBI
> requests.
[...]
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -25,6 +25,10 @@ properties:
> interrupts:
> maxItems: 1
>
> + ibi-capable:
> + description: Set to select IBI ops.
> + type: boolean
> +
Wouldn't the compatible string select whether the hardware instance
supports IBI or not?
I'd imagine that each specific synthesis of the DW IP would imply
corresponding hardware settings, and so would warrant its own compatible
value.
Maybe one for the DT folks: would this work better as individual
properties? Is there a policy here?
Cheers,
Jeremy
next prev parent reply other threads:[~2024-06-26 5:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 5:22 [PATCH 0/2] Select IBI ops for base platform Aniket
2024-06-26 5:22 ` [PATCH 1/2] dt-bindings: i3c: dw: Add property to select IBI ops Aniket
2024-06-26 5:31 ` Jeremy Kerr [this message]
2024-06-26 8:06 ` Krzysztof Kozlowski
2024-06-26 8:18 ` Jeremy Kerr
2024-06-26 8:52 ` Aniket .
2024-06-26 9:00 ` Jeremy Kerr
2024-06-26 9:14 ` Aniket .
2024-06-26 10:24 ` Jeremy Kerr
2024-06-27 3:23 ` Aniket .
2024-06-26 5:22 ` [PATCH 2/2] i3c: dw: Select ibi ops for base platform driver Aniket
2024-06-26 8:06 ` Krzysztof Kozlowski
2024-06-27 3:26 ` Aniket .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e28ba03d1df1c0c5aec987411c40e44fc351ce0d.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=alexandre.belloni@bootlin.com \
--cc=aniketmaurya@google.com \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).