* [PATCH v2 0/2] Add support for Variscite Symphony board and VAR-SOM-MX8MP SoM
@ 2024-09-02 6:56 Tarang Raval
2024-09-02 6:56 ` [PATCH v2 1/2] arm64: dts: imx8mp-var-som-symphony: Add " Tarang Raval
2024-09-02 6:56 ` [PATCH v2 2/2] dt-bindings: arm: fsl: " Tarang Raval
0 siblings, 2 replies; 8+ messages in thread
From: Tarang Raval @ 2024-09-02 6:56 UTC (permalink / raw)
To: shawnguo, krzk+dt, robh, festevam
Cc: Tarang Raval, Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Hiago De Franco, Hugo Villeneuve, Joao Paulo Goncalves,
Gregor Herburger, Mathieu Othacehe, Alexander Stein, Josua Mayer,
Parthiban Nallathambi, Yannic Moog, Li Yang, devicetree,
linux-kernel, imx, linux-arm-kernel
Add initial support for Variscite Symphony evaluation kit with
VAR-SOM-MX8MP System on Module.
Change in v2:
in patch 1/2:
- Removed unnecessary property: "status"
in patch 2/2:
- Appropriate board name instead of the SoM alone
Tarang Raval (2):
arm64: dts: imx8mp-var-som-symphony: Add Variscite Symphony board and
VAR-SOM-MX8MP SoM
dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP
SoM
.../devicetree/bindings/arm/fsl.yaml | 7 +
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../dts/freescale/imx8mp-var-som-symphony.dts | 11 +
.../boot/dts/freescale/imx8mp-var-som.dtsi | 360 ++++++++++++++++++
4 files changed, 379 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dts
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] arm64: dts: imx8mp-var-som-symphony: Add Variscite Symphony board and VAR-SOM-MX8MP SoM
2024-09-02 6:56 [PATCH v2 0/2] Add support for Variscite Symphony board and VAR-SOM-MX8MP SoM Tarang Raval
@ 2024-09-02 6:56 ` Tarang Raval
2024-09-02 6:56 ` [PATCH v2 2/2] dt-bindings: arm: fsl: " Tarang Raval
1 sibling, 0 replies; 8+ messages in thread
From: Tarang Raval @ 2024-09-02 6:56 UTC (permalink / raw)
To: shawnguo, krzk+dt, robh, festevam
Cc: Tarang Raval, Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Francesco Dolcini, Gregor Herburger, Hugo Villeneuve,
Hiago De Franco, Joao Paulo Goncalves, Mathieu Othacehe,
Alexander Stein, Parthiban Nallathambi, Yannic Moog, Josua Mayer,
Li Yang, devicetree, linux-kernel, imx, linux-arm-kernel
Adds the DTSI file for the Variscite VAR-SOM-MX8MP System on Module which
is delivered with the Variscite Symphony Evaluation Kit.
Initial support includes:
- Serial console
- eMMC
- SD card
Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
---
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../dts/freescale/imx8mp-var-som-symphony.dts | 11 +
.../boot/dts/freescale/imx8mp-var-som.dtsi | 360 ++++++++++++++++++
3 files changed, 372 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dts
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index bd443c2bc5a4..03db6aef757d 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -177,6 +177,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-var-som-symphony.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw71xx-2x.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw72xx-2x.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw73xx-2x.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dts
new file mode 100644
index 000000000000..8cec3459722f
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dts
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2024 Variscite Ltd.
+ */
+
+#include "imx8mp-var-som.dtsi"
+
+/ {
+ model = "Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board";
+ compatible = "variscite,var-som-mx8mp-symphony", "variscite,var-som-mx8mp", "fsl,imx8mp";
+};
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
new file mode 100644
index 000000000000..958fb7be3eed
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
@@ -0,0 +1,360 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2024 Variscite Ltd.
+ *
+ * Author: Tarang Raval <tarang.raval@siliconsignals.io>
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/phy/phy-imx8-pcie.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/usb/pd.h>
+#include "imx8mp.dtsi"
+
+/ {
+ model = "Variscite VAR-SOM-MX8M-PLUS module";
+ compatible = "variscite,var-som-mx8mp", "fsl,imx8mp";
+
+ chosen {
+ stdout-path = &uart2;
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+
+ led-0 {
+ function = LED_FUNCTION_POWER;
+ gpios = <&pca9534 0 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+
+ memory@40000000 {
+ device_type = "memory";
+ reg = <0x0 0x40000000 0 0xc0000000>,
+ <0x1 0x00000000 0 0xc0000000>;
+ };
+
+
+ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
+ compatible = "regulator-fixed";
+ regulator-name = "VSD_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ startup-delay-us = <100>;
+ off-on-delay-us = <12000>;
+ };
+};
+
+&A53_0 {
+ cpu-supply = <&buck2>;
+};
+
+&A53_1 {
+ cpu-supply = <&buck2>;
+};
+
+&A53_2 {
+ cpu-supply = <&buck2>;
+};
+
+&A53_3 {
+ cpu-supply = <&buck2>;
+};
+
+&i2c1 {
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c1>;
+ status = "okay";
+
+ pmic@25 {
+ compatible = "nxp,pca9450c";
+ reg = <0x25>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pmic>;
+ interrupt-parent = <&gpio5>;
+ interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
+
+ regulators {
+ buck1: BUCK1 {
+ regulator-name = "BUCK1";
+ regulator-min-microvolt = <600000>;
+ regulator-max-microvolt = <2187500>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <3125>;
+ };
+
+ buck2: BUCK2 {
+ regulator-name = "BUCK2";
+ regulator-min-microvolt = <600000>;
+ regulator-max-microvolt = <2187500>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <3125>;
+ nxp,dvs-run-voltage = <950000>;
+ nxp,dvs-standby-voltage = <850000>;
+ };
+
+ buck4: BUCK4 {
+ regulator-name = "BUCK4";
+ regulator-min-microvolt = <600000>;
+ regulator-max-microvolt = <3400000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck5: BUCK5 {
+ regulator-name = "BUCK5";
+ regulator-min-microvolt = <600000>;
+ regulator-max-microvolt = <3400000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck6: BUCK6 {
+ regulator-name = "BUCK6";
+ regulator-min-microvolt = <600000>;
+ regulator-max-microvolt = <3400000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo1: LDO1 {
+ regulator-name = "LDO1";
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo2: LDO2 {
+ regulator-name = "LDO2";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1150000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo3: LDO3 {
+ regulator-name = "LDO3";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo4: LDO4 {
+ regulator-name = "LDO4";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ ldo5: LDO5 {
+ regulator-name = "LDO5";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ };
+ };
+ };
+};
+
+&i2c3 {
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c3>;
+ status = "okay";
+
+ /* GPIO expander */
+ pca9534: gpio@20 {
+ compatible = "nxp,pca9534";
+ reg = <0x20>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pca9534>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
+ wakeup-source;
+
+ usb3-sata-sel-hog {
+ gpio-hog;
+ gpios = <4 0>;
+ output-low;
+ line-name = "usb3_sata_sel";
+ };
+ };
+};
+
+/* Console */
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart2>;
+ status = "okay";
+};
+
+/* SD-card */
+&usdhc2 {
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
+ pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+ pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
+ pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
+ cd-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
+ vmmc-supply = <®_usdhc2_vmmc>;
+ bus-width = <4>;
+ status = "okay";
+};
+
+/* eMMC */
+&usdhc3 {
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
+ pinctrl-0 = <&pinctrl_usdhc3>;
+ pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+ pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+ bus-width = <8>;
+ non-removable;
+ status = "okay";
+};
+
+&wdog1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wdog>;
+ fsl,ext-reset-output;
+ status = "okay";
+};
+
+&iomuxc {
+
+ pinctrl_i2c1: i2c1grp {
+ fsl,pins = <
+ MX8MP_IOMUXC_SD1_DATA4__I2C1_SCL 0x400001c2
+ MX8MP_IOMUXC_SD1_DATA5__I2C1_SDA 0x400001c2
+ >;
+ };
+
+ pinctrl_i2c3: i2c3grp {
+ fsl,pins = <
+ MX8MP_IOMUXC_I2C3_SCL__I2C3_SCL 0x400001c2
+ MX8MP_IOMUXC_I2C3_SDA__I2C3_SDA 0x400001c2
+ >;
+ };
+
+ pinctrl_pca9534: pca9534grp {
+ fsl,pins = <
+ MX8MP_IOMUXC_GPIO1_IO15__GPIO1_IO15 0xc0
+ >;
+ };
+
+ pinctrl_pmic: pmicgrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_SPDIF_RX__GPIO5_IO04 0x1c0
+ >;
+ };
+
+ pinctrl_uart2: uart2grp {
+ fsl,pins = <
+ MX8MP_IOMUXC_UART2_RXD__UART2_DCE_RX 0x40
+ MX8MP_IOMUXC_UART2_TXD__UART2_DCE_TX 0x40
+ >;
+ };
+
+ pinctrl_usdhc2_gpio: usdhc2-gpiogrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_GPIO1_IO14__GPIO1_IO14 0x1c4
+ MX8MP_IOMUXC_SAI2_RXC__GPIO4_IO22 0x10
+ MX8MP_IOMUXC_SD2_CD_B__GPIO2_IO12 0xc0
+ >;
+ };
+
+ pinctrl_usdhc2: usdhc2grp {
+ fsl,pins = <
+ MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK 0x190
+ MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD 0x1d0
+ MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0 0x1d0
+ MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1 0x1d0
+ MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2 0x1d0
+ MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3 0x1d0
+ >;
+ };
+
+ pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK 0x194
+ MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD 0x1d4
+ MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0 0x1d4
+ MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1 0x1d4
+ MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2 0x1d4
+ MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3 0x1d4
+ >;
+ };
+
+ pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK 0x196
+ MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD 0x1d6
+ MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0 0x1d6
+ MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1 0x1d6
+ MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2 0x1d6
+ MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3 0x1d6
+ >;
+ };
+
+ pinctrl_usdhc3: usdhc3grp {
+ fsl,pins = <
+ MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK 0x190
+ MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD 0x1d0
+ MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0 0x1d0
+ MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1 0x1d0
+ MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2 0x1d0
+ MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3 0x1d0
+ MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4 0x1d0
+ MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5 0x1d0
+ MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6 0x1d0
+ MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7 0x1d0
+ MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE 0x190
+ >;
+ };
+
+ pinctrl_usdhc3_100mhz: usdhc3-100mhzgrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK 0x194
+ MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD 0x1d4
+ MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0 0x1d4
+ MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1 0x1d4
+ MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2 0x1d4
+ MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3 0x1d4
+ MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4 0x1d4
+ MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5 0x1d4
+ MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6 0x1d4
+ MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7 0x1d4
+ MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE 0x194
+ >;
+ };
+
+ pinctrl_usdhc3_200mhz: usdhc3-200mhzgrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK 0x196
+ MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD 0x1d6
+ MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0 0x1d6
+ MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1 0x1d6
+ MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2 0x1d6
+ MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3 0x1d6
+ MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4 0x1d6
+ MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5 0x1d6
+ MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6 0x1d6
+ MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7 0x1d6
+ MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE 0x196
+ >;
+ };
+
+ pinctrl_wdog: wdoggrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_GPIO1_IO02__WDOG1_WDOG_B 0xc6
+ >;
+ };
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM
2024-09-02 6:56 [PATCH v2 0/2] Add support for Variscite Symphony board and VAR-SOM-MX8MP SoM Tarang Raval
2024-09-02 6:56 ` [PATCH v2 1/2] arm64: dts: imx8mp-var-som-symphony: Add " Tarang Raval
@ 2024-09-02 6:56 ` Tarang Raval
2024-09-02 6:59 ` Krzysztof Kozlowski
1 sibling, 1 reply; 8+ messages in thread
From: Tarang Raval @ 2024-09-02 6:56 UTC (permalink / raw)
To: shawnguo, krzk+dt, robh, festevam
Cc: Tarang Raval, Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Hugo Villeneuve, Gregor Herburger, Joao Paulo Goncalves,
Hiago De Franco, Mathieu Othacehe, Alexander Stein, Josua Mayer,
Yannic Moog, Li Yang, devicetree, linux-kernel, imx,
linux-arm-kernel
Adds support for the Variscite VAR-SOM-MX8MP System on Module and
the Variscite Symphony Evaluation Kit.
Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 6d185d09cb6a..99555767f8d0 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1071,6 +1071,7 @@ properties:
- toradex,verdin-imx8mp # Verdin iMX8M Plus Modules
- toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT
- toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules
+ - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board
- const: fsl,imx8mp
- description: Avnet (MSC Branded) Boards with SM2S i.MX8M Plus Modules
@@ -1149,6 +1150,12 @@ properties:
- const: tq,imx8mp-tqma8mpql # TQ-Systems GmbH i.MX8MP TQMa8MPQL SOM
- const: fsl,imx8mp
+ - description: Variscite VAR-SOM-MX8M Plus based boards
+ items:
+ - const: variscite,var-som-mx8mp-symphony
+ - const: variscite,var-som-mx8mp
+ - const: fsl,imx8mp
+
- description: i.MX8MQ based Boards
items:
- enum:
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM
2024-09-02 6:56 ` [PATCH v2 2/2] dt-bindings: arm: fsl: " Tarang Raval
@ 2024-09-02 6:59 ` Krzysztof Kozlowski
2024-09-02 7:07 ` Tarang Raval
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-02 6:59 UTC (permalink / raw)
To: Tarang Raval, shawnguo, krzk+dt, robh, festevam
Cc: Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Hugo Villeneuve, Gregor Herburger, Joao Paulo Goncalves,
Hiago De Franco, Mathieu Othacehe, Alexander Stein, Josua Mayer,
Yannic Moog, Li Yang, devicetree, linux-kernel, imx,
linux-arm-kernel
On 02/09/2024 08:56, Tarang Raval wrote:
> Adds support for the Variscite VAR-SOM-MX8MP System on Module and
> the Variscite Symphony Evaluation Kit.
>
> Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 6d185d09cb6a..99555767f8d0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1071,6 +1071,7 @@ properties:
> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules
> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT
> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules
> + - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board
> - const: fsl,imx8mp
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM
2024-09-02 6:59 ` Krzysztof Kozlowski
@ 2024-09-02 7:07 ` Tarang Raval
2024-09-02 7:14 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Tarang Raval @ 2024-09-02 7:07 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Hugo Villeneuve, Gregor Herburger, Joao Paulo Goncalves,
Hiago De Franco, Mathieu Othacehe, Alexander Stein, Josua Mayer,
Yannic Moog, Li Yang, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Hi,
>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules
>> + - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board
>> - const: fsl,imx8mp
>
><form letter>
>This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp."
Best Regards,
Tarang
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM
2024-09-02 7:07 ` Tarang Raval
@ 2024-09-02 7:14 ` Krzysztof Kozlowski
2024-09-02 7:23 ` Tarang Raval
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-02 7:14 UTC (permalink / raw)
To: Tarang Raval
Cc: Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Hugo Villeneuve, Gregor Herburger, Joao Paulo Goncalves,
Hiago De Franco, Mathieu Othacehe, Alexander Stein, Josua Mayer,
Yannic Moog, Li Yang, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
On Mon, Sep 02, 2024 at 07:07:02AM +0000, Tarang Raval wrote:
> Hi,
>
> >> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules
> >> + - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board
> >> - const: fsl,imx8mp
> >
> ><form letter>
> >This is a friendly reminder during the review process.
> >
> > It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
>
> as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp."
??? No, there is no difference. You did not test your patches either.
When I wrote "This is not correct", it means you should drop it.
Incorrect compatibles should not be added.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM
2024-09-02 7:14 ` Krzysztof Kozlowski
@ 2024-09-02 7:23 ` Tarang Raval
2024-09-02 7:47 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Tarang Raval @ 2024-09-02 7:23 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Hugo Villeneuve, Gregor Herburger, Joao Paulo Goncalves,
Hiago De Franco, Mathieu Othacehe, Alexander Stein, Josua Mayer,
Yannic Moog, Li Yang, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Hi,
>> as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp."
>
>??? No, there is no difference. You did not test your patches either.
I did test my patches using "dt_binding_check" and "CHECK_DTBS," and there were no warnings or errors.
>When I wrote "This is not correct", it means you should drop it.
>Incorrect compatibles should not be added.
Sure I will Drop it.
Best Regars.
Tarang
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM
2024-09-02 7:23 ` Tarang Raval
@ 2024-09-02 7:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-02 7:47 UTC (permalink / raw)
To: Tarang Raval
Cc: Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Hugo Villeneuve, Gregor Herburger, Joao Paulo Goncalves,
Hiago De Franco, Mathieu Othacehe, Alexander Stein, Josua Mayer,
Yannic Moog, Li Yang, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
On 02/09/2024 09:23, Tarang Raval wrote:
> Hi,
>
>>> as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp."
>>
>> ??? No, there is no difference. You did not test your patches either.
>
> I did test my patches using "dt_binding_check" and "CHECK_DTBS," and there were no warnings or errors.
Ah, you are right, I missed what actually changed.
>
>> When I wrote "This is not correct", it means you should drop it.
>> Incorrect compatibles should not be added.
>
> Sure I will Drop it.
I guess I wasn't precise. Please drop that one diff hunk.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-09-02 7:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-02 6:56 [PATCH v2 0/2] Add support for Variscite Symphony board and VAR-SOM-MX8MP SoM Tarang Raval
2024-09-02 6:56 ` [PATCH v2 1/2] arm64: dts: imx8mp-var-som-symphony: Add " Tarang Raval
2024-09-02 6:56 ` [PATCH v2 2/2] dt-bindings: arm: fsl: " Tarang Raval
2024-09-02 6:59 ` Krzysztof Kozlowski
2024-09-02 7:07 ` Tarang Raval
2024-09-02 7:14 ` Krzysztof Kozlowski
2024-09-02 7:23 ` Tarang Raval
2024-09-02 7:47 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).