From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4018DC433EF for ; Thu, 7 Apr 2022 11:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238791AbiDGLuM (ORCPT ); Thu, 7 Apr 2022 07:50:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238581AbiDGLuK (ORCPT ); Thu, 7 Apr 2022 07:50:10 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2DF7190585 for ; Thu, 7 Apr 2022 04:48:09 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id bi13-20020a05600c3d8d00b0038c2c33d8f3so5472880wmb.4 for ; Thu, 07 Apr 2022 04:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=WFekK56Gey0nwjwSFnx0O6aDoHsXBZvzYZ5aCHEoU+Q=; b=fss10bR3bROT9qAiIjftMdGUyAxbS+hSjahXvNa5oNK2t0r3zNv6qqfpEvqMoMFIIu i6dxHsLbYmyBPl+8V3FtoKhIH+Qn7OXwxa1lNCG3cU0t3Bki5wkDHOTqFMOciHPI+W4M iN5DDZ3IDi8rkB/V928MqOmRTxXHgGNhiP+X2iIDuBjG36g2gzSR8bze17fdd+LJq15W J4MhVSBGJpme302mRdlm90AKGhQ6F/WvPMdPaKdwerzYTDHlR85+NTUdy6VXuHnjg9W9 Jlwpt3rRR265vssH0rVpHuPgTE2EwEL+ciWi7xErcTTtMzWPYZNLVpZ/SOuxTwOWOr0E QGuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WFekK56Gey0nwjwSFnx0O6aDoHsXBZvzYZ5aCHEoU+Q=; b=erOE9K94t4ed10QkPvgfiEvDz4E68uQvB8EKaUc+X/IGUmin/nBNMa2yakHm8eLRi5 P12SBdJOriYr3tg/+F/cSkjcLN8uqWZVAHht6dEVMbIIws+2XHmPIj8Gw5d5L413mKKM kMDWJE7vRmmrZ1fjL9A6nXMi18Ay9kGb90di1acg+x3uie2suBgzUkGeRxbZ4vGR6Kwi T6IgFAHIkw/8dGwpR70ox8xPyDq9pdiE/BJmZbAiZs/++HuNHQZxuSbfhKyVKxL/Azrq L/bBLVyiBYAKv9fU2nE4qNA+jW6rTpcJhoXn21eWQsb4cA1LOphuQSYrZcRJPFaTYCdZ etyg== X-Gm-Message-State: AOAM53194v31OnI7N6lOEAJTMqQF21cpnCZnCcsTMkhEHthEB3ow5daP b8lIG/qC1AqLJ2qiJZaPROYoVw== X-Google-Smtp-Source: ABdhPJwoMdNeuU1YCgrz1ayp3i5UQaxt1w9dTjtvLwbtPi6o+Kryz3m3ioMA0Tes3nKunn+xCVFdZA== X-Received: by 2002:a05:600c:1d9b:b0:38c:af70:9998 with SMTP id p27-20020a05600c1d9b00b0038caf709998mr12025660wms.169.1649332088181; Thu, 07 Apr 2022 04:48:08 -0700 (PDT) Received: from ?IPV6:2a01:e34:ed2f:f020:f2a2:7d81:4e67:6c1c? ([2a01:e34:ed2f:f020:f2a2:7d81:4e67:6c1c]) by smtp.googlemail.com with ESMTPSA id f8-20020a5d50c8000000b002061622ec88sm9037808wrt.105.2022.04.07.04.48.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 04:48:07 -0700 (PDT) Message-ID: Date: Thu, 7 Apr 2022 13:48:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/4] clocksource/drivers/timer-ti-dm: Update defines for am6 for inline functions Content-Language: en-US To: Tony Lindgren Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Keerthy , Nishanth Menon , Vignesh Raghavendra , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org References: <20220407071006.37031-1-tony@atomide.com> <20220407071006.37031-2-tony@atomide.com> <9671f0a5-6860-8a75-d65e-345ce890cd88@linaro.org> <7f3cbdf3-401c-6c30-20fa-b5121bd3f63d@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/04/2022 12:26, Tony Lindgren wrote: > * Tony Lindgren [220407 08:50]: >> * Daniel Lezcano [220407 08:23]: >>> On 07/04/2022 10:15, Tony Lindgren wrote: >>>> * Daniel Lezcano [220407 08:01]: >>>>> On 07/04/2022 09:10, Tony Lindgren wrote: >>>>>> @@ -251,7 +251,8 @@ int omap_dm_timers_active(void); >>>>>> * The below are inlined to optimize code size for system timers. Other code >>>>>> * should not need these at all. >>>>>> */ >>>>>> -#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS) >>>>>> +#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS) || \ >>>>>> + defined(CONFIG_ARCH_K3) >>>>> >>>>> Why not replace the above by CONFIG_OMAP_DM_TIMER ? >>>> >>>> Hmm that's a good question for why it was not that way earlier. >>>> >>>> This series changes things for tristate "OMAP dual-mode timer driver" if >>>> ARCH_K3 || COMPILE_TEST though. So the inline stubs are still needed for >>>> COMPILE_TEST it seems. >>> >>> But if ARCH_K3 or COMPILE_TEST is set, CONFIG_DM_TIMER is also set, no? >> >> Right but I suspect that COMPILE_TEST will produce a build error on other >> architectures. I need to check that though, maybe that is no longer the >> case. > > We could use IS_ENABLED(CONFIG_OMAP_DM_TIMER), but looks like we can now > just move the __omap_dm_timer_* inline functions to timer-ti-dm.c instead. > > I'll do that and repost after some testing. Even better :) -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog