From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB9CEB64D9 for ; Thu, 15 Jun 2023 00:48:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231151AbjFOAsL (ORCPT ); Wed, 14 Jun 2023 20:48:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjFOAsK (ORCPT ); Wed, 14 Jun 2023 20:48:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 975FF1BC9; Wed, 14 Jun 2023 17:48:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2A9CF61F4F; Thu, 15 Jun 2023 00:48:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A82DC433C0; Thu, 15 Jun 2023 00:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686790088; bh=ljTHxAt2/H9b6qwb5RfqtZnhtJZN2CPWpT6t2q4z+44=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=L10bqQ2XIuTNsKR/DVIaAOmKRB34mM779Gb5ukrZ/YtRbXXOzWwwEyxvAnbDVf8Cl V5jHQGhiqRCUw3qNbJa1QCoU4e8Ks050IjZYaywOEXfqdzFBFWRa9tDzsGr4Cayzd1 W+TszLJXjmiRJUIFmowq9MNMxuN2anui4gnkHZ8vqtdWB6U4E0Yl3hNn1+q5ciqk/z +AiLHvblE9HxILjr+10y93R2M8853VZziuQt2FLcTDnPy0ALahEabJy0AAVMLIRLJm hGrfjUe776bD17fxL9EuQyQV9e0+BKSkT/+rbFPDK54riiT6YYabTL3sFIBLE1PB+5 RsHk4IWAogE2Q== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230526-topic-smd_icc-v6-18-263283111e66@linaro.org> References: <20230526-topic-smd_icc-v6-0-263283111e66@linaro.org> <20230526-topic-smd_icc-v6-18-263283111e66@linaro.org> Subject: Re: [PATCH v6 18/22] clk: qcom: smd-rpm: Separate out interconnect bus clocks From: Stephen Boyd Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio To: Andy Gross , Bjorn Andersson , Conor Dooley , Evan Green , Georgi Djakov , Konrad Dybcio , Krzysztof Kozlowski , Leo Yan , Michael Turquette , Rob Herring Date: Wed, 14 Jun 2023 17:48:06 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Konrad Dybcio (2023-06-14 11:04:37) > The interconnect bus clocks are now handled within the ICC framework. > They still however need to get a kickstart *before* we call > clk_smd_rpm_enable_scaling(), or RPM will assume that they should all > be running at 0 kHz and the system will inevitably die. >=20 > Separate them out to ensure such a kickstart can still take place. >=20 > As a happy accident, the file got smaller: >=20 > Total: Before=3D41951, After=3D41555, chg -0.94% >=20 > Signed-off-by: Konrad Dybcio > --- > drivers/clk/qcom/clk-smd-rpm.c | 278 +++++++++++++++++------------------= ------ > 1 file changed, 115 insertions(+), 163 deletions(-) >=20 > diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rp= m.c > index 6e7f0438e8b8..0d1d97659d59 100644 > --- a/drivers/clk/qcom/clk-smd-rpm.c > +++ b/drivers/clk/qcom/clk-smd-rpm.c > @@ -498,13 +506,69 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk1, 11, 19200000= ); > DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk2, 12, 19200000); > DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk3, 13, 19200000); > =20 > +static struct clk_smd_rpm *bimc_pcnoc_icc_clks[] =3D { Can these be const arrays? > + &clk_smd_rpm_bimc_clk, > + &clk_smd_rpm_bus_0_pcnoc_clk, > +}; > + [...] > @@ -1332,6 +1275,15 @@ static int rpm_smd_clk_probe(struct platform_devic= e *pdev) > goto err; > } > =20 > + for (i =3D 0; i < desc->num_icc_clks; i++) { > + if (!desc->icc_clks[i]) > + continue; > + > + ret =3D clk_smd_rpm_handoff(desc->icc_clks[i]); This API can probably take a const struct clk_smd_rpm pointer as well.