From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB8DC303A18 for ; Wed, 15 Oct 2025 19:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760556629; cv=none; b=SlI1kQ8FpCY2nBIJ3OAtGXjsGDatxXTrJKrl33LnA/rk3vojJ22yDJzLtfvvJPw41jnj5yVTxuK5t4xzbu69fk70PHBIvpfxfowZn0JzxOK7iT1lt9dDc6GB5sNz+/mdE31wR320fapHugQDaLsWWp/9UOXgZQV66jLW96zbGzw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760556629; c=relaxed/simple; bh=nPbCX4b0wyKA4xqnzFN93V39LMSXnGf6slFjcnpoHkQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=prBaEl//vQOZ3bf7m+XMPhBdzx3B2B5kv4cYffpmr6GFV7z+x2A/TN6eGKJLs9BrSC51hghX0JgW/y220EQkzK0A4q0O7iLWp1T03giLV9G0LOcsjN/HA3jtA0uGBMjom6cZRW5Ci4szc7UXrK0VMgN6sgPvtv8MYhK6W73Mt7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rm3AAiFP; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rm3AAiFP" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-57a8b00108fso1289392e87.3 for ; Wed, 15 Oct 2025 12:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760556625; x=1761161425; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=xn6HzcB6Q1wB3Fmq1gYyY4hfzEIJC4qbMSCV9Ej5PPg=; b=rm3AAiFPzKNzHGrPkiYs5NwYhdnsqXjdCQBWWNuBFoqeIsqbpexoTcLGK/luwvXmun wpx116Sz82PUm2GQh7VvldSRl6Ucoy6S6IFHR3OTXlIT5x/9n1RJDL2bVLuqAQa3HQjs dS9npXuPQ7skG+fOpmauPij9yg878q7sGUl5LJReLUJkQ/5q0K/BGVicwKqV8fmmadmJ 0B/zLJRZ5oZFvTjYF3U5BT6Yqg7EQi1KJqMlakIRUmnHLhHGgMpjZfy3s6TYgJfPff0Y Qm2OCew+O+fK1ie7UR5poaypnjFT/RczzkT4862VbFs3icw2uroj8kBZbdZn0eEYeY/X 2pzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760556625; x=1761161425; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xn6HzcB6Q1wB3Fmq1gYyY4hfzEIJC4qbMSCV9Ej5PPg=; b=ZtFQF08l3zY8XDq19/FGnXYSA4+d4zT7UWq60zz8Uw4gxj0IjnoE4FUtY6sUSD7jdq QhHT1YnhXDRq1EmepLLXCuSxBRyHS17bAoth0xfe2GplFLWjn9NXgcVm96iJVJBHzAlp dJuxyV9OpOrq3wTuXDRMbX/BhT+1zk2uZ9HrzQ6j2G2CtwEl7Q1qnZjrXZ2AmDB8jIP5 nfr1YzyE9158mGiODorQbC2LH8m8FV7VzRLrr/OixRgUF1IoR0w/pc1Ib6T6JTQt+bB2 HC4uHQrADvbe+H0Ldg/JkdQK31CdCKBw+2dKYBGtIO0ylaKI/EsfukE/nbqWI9Vr2mwh SrhQ== X-Forwarded-Encrypted: i=1; AJvYcCVHJqPg8XcRTDM98S4cST2eYpBFPgPeOLPI0WtoQrJTH5PciP6uxkAwk3ZMB2g4ddkpU6R7uQJzYYu3@vger.kernel.org X-Gm-Message-State: AOJu0Ywc4DqHCj/+S+GA5GP3WFxfS6uEnzVlcEsxIOHet9B4sKdgcUdj 7eMLSgRTY9aIu7nxfXpT4WOmZaGM3sZt7jnn5CIYyloLb75Ar6O2FgG2tSnx/ExU26Y= X-Gm-Gg: ASbGncsIYXvSLl5+h/eBOHsrazgyb8nj6nbUc/+W3h0TNkGW3fwvLn0BCA5vPMt2pKv ftDnXleuWLUOS+uYsG9TyEXGZvftEBfY4ExE29g0QSDwFmMSI+eEO8l4WCEwZm64jtsaA01iJ4X LOQHrW4f6cepxQOIejOjL9/LuND8BXKP9HYaX84v7NYEtJgCPWbsk9/Rke+DUw2rwSIUOxbM8CV fXiIBEP3neSPp/QXItMkbGTzejljO2CzHEBPbgeg6AUA3FueqCp9Oapfed3yFbGw4I0UfoT09QK y0crIXqsY/LflxKofmG1gEb7RfPCCbQxSXnJ0NTJ+BWRKzC0DfeQwX+pDwGrc+PO5hTTmcu6PJq 6ldU+W4c19ZB/qUD4vZ38E7QbSVh+CUJu24NOFLAxXZ5YEQqtuYa8MeKTvTQoww8WXb1QJFNhJJ pB/wowfYOPPbxKDYLoRkeBgecRwRk6H20m4a7lJfxWLGh9G/5n3sXHGz4WzOLfrkXA30tTJw== X-Google-Smtp-Source: AGHT+IFtiwV326wSWMTN9z/8oSxLb3NlWVYgOdgv2W41aNnsDtgsz1zRyzjEAW4kE//A9Xvesx8DNg== X-Received: by 2002:a05:6512:118f:b0:585:805b:e3b0 with SMTP id 2adb3069b0e04-591c904cfbemr681247e87.9.1760556624721; Wed, 15 Oct 2025 12:30:24 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5909413ec6csm5546283e87.48.2025.10.15.12.30.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Oct 2025 12:30:24 -0700 (PDT) Message-ID: Date: Wed, 15 Oct 2025 22:30:21 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dt-bindings: i2c: qcom-cci: Document Kaanapali compatible To: Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab , Bryan O'Donoghue Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251014-add-support-for-camss-on-kaanapali-v2-0-f5745ba2dff9@oss.qualcomm.com> <20251014-add-support-for-camss-on-kaanapali-v2-1-f5745ba2dff9@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20251014-add-support-for-camss-on-kaanapali-v2-1-f5745ba2dff9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/15/25 05:56, Hangxiang Ma wrote: > Add Kaanapali compatible consistent with CAMSS CCI interfaces. The list > of clocks for Kaanapali requires its own compat string 'cam_top_ahb', > aggregated into 'qcom,qcm2290-cci' node. > > Signed-off-by: Hangxiang Ma > --- > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml > index 9bc99d736343..0140c423f6f4 100644 > --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml > @@ -25,6 +25,7 @@ properties: > > - items: > - enum: > + - qcom,kaanapali-cci > - qcom,qcm2290-cci > - qcom,sa8775p-cci > - qcom,sc7280-cci > @@ -128,6 +129,7 @@ allOf: > compatible: > contains: > enum: > + - qcom,kaanapali-cci > - qcom,qcm2290-cci > then: > properties: > @@ -136,7 +138,9 @@ allOf: > maxItems: 2 > clock-names: > items: > - - const: ahb > + - enum: > + - ahb > + - cam_top_ahb Why is not to give the clock "ahb" name like on QCM2290? On QCM2290 the macro in front of the vlaue is GCC_CAMSS_TOP_AHB_CLK, and name "ahb" is good for both, I believe. > - const: cci > > - if: > -- Best wishes, Vladimir