devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Allen-KH Cheng (程冠勳)" <Allen-KH.Cheng@mediatek.com>
To: "nfraprado@collabora.com" <nfraprado@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"linux-mediatek@lists.infradead.org" 
	<linux-mediatek@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	Project_Global_Chrome_Upstream_Group 
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"angelogioacchino.delregno@collabora.com" 
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v3 5/7] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema
Date: Thu, 3 Nov 2022 05:45:07 +0000	[thread overview]
Message-ID: <e2c8061c4bcc388171243646cfebe5876a227dd4.camel@mediatek.com> (raw)
In-Reply-To: <20221102202617.ailu6xc5qfstnl6c@notapiano>

On Wed, 2022-11-02 at 16:26 -0400, Nícolas F. R. A. Prado wrote:
> On Tue, Nov 01, 2022 at 05:01:14PM +0800, Allen-KH Cheng wrote:
> [..]
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-
> > wdt.yaml
> 
> [..]
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        watchdog: watchdog@10007000 {
> 
> You could drop this label since it's not used in the example.
> 
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 
> Thanks,
> Nícolas
> 

Will do.

Thanks,
Allen

> > +            compatible = "mediatek,mt8183-wdt";
> > +            reg = <0 0x10007000 0 0x100>;
> > +            interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_LOW>;
> > +            mediatek,disable-extrst;
> > +            timeout-sec = <10>;
> > +            #reset-cells = <1>;
> > +        };
> > +    };
> 
> [..]

  reply	other threads:[~2022-11-03  5:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01  9:01 [PATCH v3 0/7] MediaTek watchdog: Convert mtk-wdt.txt to dt-schema Allen-KH Cheng
2022-11-01  9:01 ` [PATCH v3 1/7] arm64: dts: mediatek: mt8186: Fix watchdog compatible Allen-KH Cheng
2022-11-02 20:18   ` Nícolas F. R. A. Prado
2022-11-01  9:01 ` [PATCH v3 2/7] arm64: dts: mediatek: mt8195: " Allen-KH Cheng
2022-11-02 20:18   ` Nícolas F. R. A. Prado
2022-11-01  9:01 ` [PATCH v3 3/7] arm64: dts: mediatek: mt7986: " Allen-KH Cheng
2022-11-02  9:01   ` AngeloGioacchino Del Regno
2022-11-02 20:19   ` Nícolas F. R. A. Prado
2022-11-01  9:01 ` [PATCH v3 4/7] arm64: dts: mediatek: mt8516: Fix the watchdog node name Allen-KH Cheng
2022-11-02 20:21   ` Nícolas F. R. A. Prado
2022-11-01  9:01 ` [PATCH v3 5/7] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema Allen-KH Cheng
2022-11-02 20:26   ` Nícolas F. R. A. Prado
2022-11-03  5:45     ` Allen-KH Cheng (程冠勳) [this message]
2022-11-01  9:01 ` [PATCH v3 6/7] dt-bindings: watchdog: mediatek,mtk-wdt: Add compatible for MT6795 Allen-KH Cheng
2022-11-02 20:27   ` Nícolas F. R. A. Prado
2022-11-01  9:01 ` [PATCH v3 7/7] dt-bindings: watchdog: mediatek,mtk-wdt: Add compatible for MT8173 Allen-KH Cheng
2022-11-02 20:28   ` Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2c8061c4bcc388171243646cfebe5876a227dd4.camel@mediatek.com \
    --to=allen-kh.cheng@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).