From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ezra Buehler <ezra@easyb.ch>, linux-mips@vger.kernel.org
Cc: Conor Dooley <conor+dt@kernel.org>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Reto Schneider <reto.schneider@husqvarnagroup.com>,
Rob Herring <robh@kernel.org>,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Stefan Roese <sr@denx.de>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
devicetree@vger.kernel.org,
Ezra Buehler <ezra.buehler@husqvarnagroup.com>
Subject: Re: [PATCH v1 1/3] MIPS: dts: ralink: mt7628a: Fix sysc's compatible property for MT7688
Date: Thu, 12 Jun 2025 13:22:04 +0200 [thread overview]
Message-ID: <e2ffca36-d2ed-4253-86a6-a990e7931ba0@kernel.org> (raw)
In-Reply-To: <20250611194716.302126-2-ezra@easyb.ch>
On 11/06/2025 21:47, Ezra Buehler wrote:
> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>
> Otherwise, the MT7688-based GARDENA smart Gateway will fail to boot
> printing "Kernel panic - not syncing: unable to get CPU clock, err=-2".
>
> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
> ---
> arch/mips/boot/dts/ralink/mt7628a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7628a.dtsi b/arch/mips/boot/dts/ralink/mt7628a.dtsi
> index 0212700c4fb4..10221a41f02a 100644
> --- a/arch/mips/boot/dts/ralink/mt7628a.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7628a.dtsi
> @@ -33,7 +33,7 @@ palmbus@10000000 {
> #size-cells = <1>;
>
> sysc: syscon@0 {
> - compatible = "ralink,mt7628-sysc", "syscon";
> + compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
This is in contradiction to bindings, so you need to fix bindings first
- with proper justification. If this happened in separate patchset, then
the DTS thread MUST provide lore link to that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-12 11:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 19:47 [PATCH v1 0/3] MIPS: dts: ralink: mt7628a: Tweak for GARDENA smart Gateway Ezra Buehler
2025-06-11 19:47 ` [PATCH v1 1/3] MIPS: dts: ralink: mt7628a: Fix sysc's compatible property for MT7688 Ezra Buehler
2025-06-12 7:34 ` Stefan Roese
2025-06-12 11:22 ` Krzysztof Kozlowski [this message]
2025-06-13 11:50 ` Ezra Buehler
2025-06-13 12:11 ` Krzysztof Kozlowski
2025-06-13 12:20 ` Ezra Buehler
2025-06-13 12:41 ` Krzysztof Kozlowski
2025-06-13 12:56 ` Ezra Buehler
2025-06-13 13:13 ` Krzysztof Kozlowski
2025-06-13 17:39 ` Ezra Buehler
2025-06-14 5:01 ` Sergio Paracuellos
2025-06-14 5:46 ` Ezra Buehler
2025-06-14 6:43 ` Sergio Paracuellos
2025-06-11 19:47 ` [PATCH v1 2/3] MIPS: dts: ralink: mt7628a: Update watchdog node according to bindings Ezra Buehler
2025-06-12 7:34 ` Stefan Roese
2025-06-14 4:47 ` Sergio Paracuellos
2025-06-11 19:47 ` [PATCH v1 3/3] MIPS: dts: ralink: gardena_smart_gateway_mt7688: Fix power LED Ezra Buehler
2025-06-12 7:35 ` Stefan Roese
2025-06-14 4:47 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ffca36-d2ed-4253-86a6-a990e7931ba0@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ezra.buehler@husqvarnagroup.com \
--cc=ezra@easyb.ch \
--cc=harveyhuntnexus@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=reto.schneider@husqvarnagroup.com \
--cc=robh@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=sr@denx.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).