From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF1E113AD9; Sat, 16 Sep 2023 15:13:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA167C433C8; Sat, 16 Sep 2023 15:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694877205; bh=UJcG/Z4VLEEdcyUQ1btwTp8/xlKMyVOUA/d+z5tDKPE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NS6hr4/Wd6HWpqFTi90Cbt/zkPXqtLtXB9/M2GugUVKALv9XtGEUqk+2e+htsDuXU ohpqAQDK6EipATqHisod7Gxqxkw49iUaZpr9xvqqNInza5o1MihQNdKDsvK4Xq/o+Z lrF/me9MFNUgGa0q82mkM/ZyB6sSJRyvHwHFo7yN3wKBM/qaJt3QC2NIVTfRPACIc2 EIMm6FRfe8Uxkbrut4AiGm8QolfvgtB8uHI2N/FVo+pkwanNzekTl2I6v+K7qi+mrF qZGNb9PhINkg1OdQcXNm94ffHwWHWr2SFHiRL7QkaAMgDqVCRQ2qLn83w+9+HGWotq p3oH8hUhuyA5g== Message-ID: Date: Sat, 16 Sep 2023 18:13:15 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/8] arm64: defconfig: enable interconnect and pinctrl for SM4450 Content-Language: en-US To: Trilok Soni , Krzysztof Kozlowski , Tengfei Fan , will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, catalin.marinas@arm.com Cc: geert+renesas@glider.be, arnd@arndb.de, neil.armstrong@linaro.org, nfraprado@collabora.com, rafal@milecki.pl, peng.fan@nxp.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_shashim@quicinc.com, quic_kaushalk@quicinc.com, quic_tdas@quicinc.com, quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com, kernel@quicinc.com References: <20230915021509.25773-1-quic_tengfan@quicinc.com> <20230915021509.25773-10-quic_tengfan@quicinc.com> <8f2c9664-a2c8-50dc-8a1c-e50a071ebeb2@linaro.org> <0a34dd35-7aea-4655-4cdd-e7196a1ba52b@linaro.org> <01c020ae-a019-e4eb-14cb-64503bde05a6@quicinc.com> <212f9bfa-6d4c-bba2-60d2-272c001a4322@quicinc.com> From: Georgi Djakov In-Reply-To: <212f9bfa-6d4c-bba2-60d2-272c001a4322@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Trilok, On 16.09.23 5:25, Trilok Soni wrote: > On 9/15/2023 7:21 PM, Trilok Soni wrote: >> On 9/15/2023 4:29 AM, Krzysztof Kozlowski wrote: >>> On 15/09/2023 13:18, Tengfei Fan wrote: >>>> >>>> >>>> 在 9/15/2023 5:16 PM, Krzysztof Kozlowski 写道: >>>>> On 15/09/2023 11:12, Tengfei Fan wrote: >>>>>> >>>>>> >>>>>> 在 9/15/2023 3:21 PM, Krzysztof Kozlowski 写道: >>>>>>> On 15/09/2023 04:15, Tengfei Fan wrote: >>>>>>>> Add the SM4450 interconnect and pinctrl drivers as built-in for >>>>>>>> support the Qualcomm SM4450 platform to boot to uart shell. >>>>>>>> >>>>>>>> Signed-off-by: Tengfei Fan >>>>>>>> --- >>>>>>>> arch/arm64/configs/defconfig | 2 ++ >>>>>>>> 1 file changed, 2 insertions(+) >>>>>>>> >>>>>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>>>>>> index ec59174b14db..e91993de865e 100644 >>>>>>>> --- a/arch/arm64/configs/defconfig >>>>>>>> +++ b/arch/arm64/configs/defconfig >>>>>>>> @@ -598,6 +598,7 @@ CONFIG_PINCTRL_SC8280XP=y >>>>>>>> CONFIG_PINCTRL_SDM660=y >>>>>>>> CONFIG_PINCTRL_SDM670=y >>>>>>>> CONFIG_PINCTRL_SDM845=y >>>>>>>> +CONFIG_PINCTRL_SM4450=y >>>>>>>> CONFIG_PINCTRL_SM6115=y >>>>>>>> CONFIG_PINCTRL_SM6125=y >>>>>>>> CONFIG_PINCTRL_SM6350=y >>>>>>>> @@ -1500,6 +1501,7 @@ CONFIG_INTERCONNECT_QCOM_SC7280=y >>>>>>>> CONFIG_INTERCONNECT_QCOM_SC8180X=y >>>>>>>> CONFIG_INTERCONNECT_QCOM_SC8280XP=y >>>>>>>> CONFIG_INTERCONNECT_QCOM_SDM845=y >>>>>>>> +CONFIG_INTERCONNECT_QCOM_SM4450=y >>>>>>> >>>>>>> Why it cannot be =m? >>>>>>> >>>>>>> Best regards, >>>>>>> Krzysztof >>>>>>> >>>>>> >>>>>> Hi Krzysztof, >>>>>> Because system haven't capacity of loading ko files at this time on >>>>>> SM4450 platform, so setting to "Y". >>>>> >>>>> Hm? System has this capability. All systems have. What is so different >>>>> on SM4450 comparing to everything else we have here? >>>>> >>>>> No, this should be =m and you need to fix your system. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>>> >>>> Hi Krzysztof, >>>> Find new way which can load ko files on SM4450 platform, still need use >>>> "Y", because of some other modules have dependence to these two config, >>>> like scm, smmu module drivers, uart shell console cannot be got if set >>>> to "m". >>> >>> That's what I am asking, which device exactly needs it. >>> >>>> >>>> Also do test for setting these two config to "m" on SM8450 platform, get >>>> uart shell consle failed if so setting. >>> >>> Yeah, this we know, I did this. I am asking about SM4450. >> >> Why we have =m requirement when other drivers above are =Y?. Can we confirm >> w/ Georgi? I am not aware that Interconnect drivers needs to be =m only. >> >> CONFIG_INTERCONNECT_QCOM_SC8180X=y >> CONFIG_INTERCONNECT_QCOM_SC8280XP=y >> CONFIG_INTERCONNECT_QCOM_SDM845=y > > Complete list here, and it is inconsistent. Latest 8550 is also =y. Do we document > the reasons somewhere on why they are added as =y? > > CONFIG_INTERCONNECT_QCOM=y > CONFIG_INTERCONNECT_QCOM_MSM8916=m > CONFIG_INTERCONNECT_QCOM_MSM8996=m > CONFIG_INTERCONNECT_QCOM_OSM_L3=m > CONFIG_INTERCONNECT_QCOM_QCM2290=m > CONFIG_INTERCONNECT_QCOM_QCS404=m > CONFIG_INTERCONNECT_QCOM_SA8775P=y > CONFIG_INTERCONNECT_QCOM_SC7180=y > CONFIG_INTERCONNECT_QCOM_SC7280=y > CONFIG_INTERCONNECT_QCOM_SC8180X=y > CONFIG_INTERCONNECT_QCOM_SC8280XP=y > CONFIG_INTERCONNECT_QCOM_SDM845=y > CONFIG_INTERCONNECT_QCOM_SM8150=m > CONFIG_INTERCONNECT_QCOM_SM8250=m > CONFIG_INTERCONNECT_QCOM_SM8350=m > CONFIG_INTERCONNECT_QCOM_SM8450=y > CONFIG_INTERCONNECT_QCOM_SM8550=y If the device can boot (to console/initramfs) with =m, we go with that. But if something critical like the UART depends on the interconnect provider, then we make it built-in. On SM8550 for example, we have enabled bandwidth scaling support for QUP and that's why it needs to be =y. It looks like on SM4450 this should be =y too. Thanks, Georgi