From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hugo Villeneuve <hugo@hugovil.com>, Jonathan Cameron <jic23@kernel.org>
Cc: hvilleneuve@dimonoff.com, lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: adc: add Texas Instruments ADS7924
Date: Sun, 15 Jan 2023 20:17:24 +0100 [thread overview]
Message-ID: <e30a869a-5585-901b-6a56-3e327e0cf60a@linaro.org> (raw)
In-Reply-To: <20230115113250.d8a0ec5a2638e24c1208539c@hugovil.com>
On 15/01/2023 17:32, Hugo Villeneuve wrote:
>>>>> + required:
>>>>> + - reg
>>>>> +
>>>>> + additionalProperties: false
>>>>
>>>> You are not allowing anything else from adc.yaml. Is it on purpose?
>>>
>>> I am really not an expert with this Yaml stuff, and reading the documentation makes me probably more confused than before reading it :)
>>>
>>> But one thing that is for sure is that these other properties in adc.yaml are not used in my driver:
>>>
>>> bipolar
>>> diff-channels
>>> settling-time-us
>>> oversampling-ratio
>>>
>>> So is it Ok then to use "additionalProperties: false"? I think so, but what is your recommandation?
>>
>> Makes sense to me. Whilst there are lots of things a channel can support, most
>> of them are hardware related and not universal.
>
> Ok, I think I am finally beginning to see the light here :)
>
> So I will then leave "additionalProperties: false".
>
> I will send a V4 soon with all the latest changes.
>
Just to clarify - we talk about hardware, not your Linux driver. What
your driver uses or doesn't, should not matter here that much.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-15 19:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 19:49 [PATCH v3 0/2] iio: adc: ti-ads7924: add Texas Instruments ADS7924 driver Hugo Villeneuve
2023-01-13 19:49 ` [PATCH v3 1/2] " Hugo Villeneuve
2023-01-14 16:28 ` Jonathan Cameron
2023-01-14 17:53 ` Hugo Villeneuve
2023-01-13 19:49 ` [PATCH v3 2/2] dt-bindings: iio: adc: add Texas Instruments ADS7924 Hugo Villeneuve
2023-01-15 14:57 ` Krzysztof Kozlowski
2023-01-15 16:22 ` Hugo Villeneuve
2023-01-15 16:43 ` Jonathan Cameron
2023-01-15 16:32 ` Hugo Villeneuve
2023-01-15 19:17 ` Krzysztof Kozlowski [this message]
2023-01-15 20:11 ` Hugo Villeneuve
2023-01-16 15:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e30a869a-5585-901b-6a56-3e327e0cf60a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).