From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22761C63797 for ; Sun, 15 Jan 2023 19:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbjAOTRe (ORCPT ); Sun, 15 Jan 2023 14:17:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231528AbjAOTR2 (ORCPT ); Sun, 15 Jan 2023 14:17:28 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C34A11284C for ; Sun, 15 Jan 2023 11:17:27 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id i9so38182089edj.4 for ; Sun, 15 Jan 2023 11:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fNy8Ed1dQVkCck3Yrixd5a7dXF6hx057okDs4An96m8=; b=J9u8jotCkPnE07dQeMS/V2VfXKl4wSsLemI/NPc1H9UTsGW1jLShEW9IifSiE1V9bP 03MemjO0vISX5316LeQd08YOsDuiSJJn7DhDydQ1eX9VnPh7nsNMJNS0u4Suj4qozLdH 5T+ksi59EtayJ3L77eJZGTcNnbiShr/O4FhKNDt/Qc3UnnMZco4aNiPUtE5TCTXZPwzD oAvss0B44SPVPxgZiyDO1DuQ1U7UITaJt39K8eLqjeIwtdC8TDy5YCkFLsM2eetT7nL8 6ifnVVFvvaLkNdbb/lC0/9IMw2YS33UmoYr5e3lutS5X+FrZCcc5sr49AzNassyo7E6s hsBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fNy8Ed1dQVkCck3Yrixd5a7dXF6hx057okDs4An96m8=; b=1Jvm4lh/nk5MCv+D5pQMpwcGybUX8MmvWIcth3nhuYVI04wLsnHUovLQPmPczojfBN IRBuOZSjuq04z4vojc1vW3OdHYLYUqpzoh7Os3rFa6oTaSxa3rcS+B6DaoR4QTMeV6zR JgyrHL7dRqcpBBIWHrCqhnca9F7SLE8m6m+D6f2OV/ZjMO+jAml95Nlxgtf7mCG48nrq SPx7QRnKISCmb+G7/i+DJlJkhLIMf/wGwGg92n/9NtDt4HmJRLIf79tztVBVQIETa+kn ajGR07416AWEIqv01KorMM1U8M1vgO4Mct1tNIAQFtNaD3nqYF5x8qyJfMkc0bPuAV7X Mtww== X-Gm-Message-State: AFqh2kpUzPrzkcxAe+Eld0cqsfxpV1hbay7IZRK2fqaC/7z9iORM4MXC U0Iu3BBBBaQJKPzjNSjlriYNmQ== X-Google-Smtp-Source: AMrXdXuu7deMsLziMX+f5y3yyfP4oYwu1gZcHnWOxhlz1HM7IMfRK3+mV5HRCYinCSuzyRrA9LwpSA== X-Received: by 2002:a05:6402:2484:b0:46c:6ed1:83ac with SMTP id q4-20020a056402248400b0046c6ed183acmr84595212eda.9.1673810246439; Sun, 15 Jan 2023 11:17:26 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id r14-20020aa7cb8e000000b00499b6b50419sm7636491edt.11.2023.01.15.11.17.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Jan 2023 11:17:25 -0800 (PST) Message-ID: Date: Sun, 15 Jan 2023 20:17:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 2/2] dt-bindings: iio: adc: add Texas Instruments ADS7924 Content-Language: en-US To: Hugo Villeneuve , Jonathan Cameron Cc: hvilleneuve@dimonoff.com, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230113194959.3276433-1-hugo@hugovil.com> <20230113194959.3276433-3-hugo@hugovil.com> <20230115112205.e46ab8d017b99dd987d003e4@hugovil.com> <20230115164326.7f03f6d9@jic23-huawei> <20230115113250.d8a0ec5a2638e24c1208539c@hugovil.com> From: Krzysztof Kozlowski In-Reply-To: <20230115113250.d8a0ec5a2638e24c1208539c@hugovil.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/01/2023 17:32, Hugo Villeneuve wrote: >>>>> + required: >>>>> + - reg >>>>> + >>>>> + additionalProperties: false >>>> >>>> You are not allowing anything else from adc.yaml. Is it on purpose? >>> >>> I am really not an expert with this Yaml stuff, and reading the documentation makes me probably more confused than before reading it :) >>> >>> But one thing that is for sure is that these other properties in adc.yaml are not used in my driver: >>> >>> bipolar >>> diff-channels >>> settling-time-us >>> oversampling-ratio >>> >>> So is it Ok then to use "additionalProperties: false"? I think so, but what is your recommandation? >> >> Makes sense to me. Whilst there are lots of things a channel can support, most >> of them are hardware related and not universal. > > Ok, I think I am finally beginning to see the light here :) > > So I will then leave "additionalProperties: false". > > I will send a V4 soon with all the latest changes. > Just to clarify - we talk about hardware, not your Linux driver. What your driver uses or doesn't, should not matter here that much. Best regards, Krzysztof