devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 3/9] clk: qcom: gdsc: Increase status poll timeout
Date: Wed, 30 Nov 2022 12:30:33 +0100	[thread overview]
Message-ID: <e3268c45-b97f-1eea-c0a2-752cac714397@linaro.org> (raw)
In-Reply-To: <20221130112852.2977816-4-abel.vesa@linaro.org>



On 30.11.2022 12:28, Abel Vesa wrote:
> The SM8550 GCC GDSCs need a higher timeout value when polling for status,
> so increase it to 1500us, while leaving the delay between disable-enable
> sequence for votable gdscs to stay the same.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/clk/qcom/gdsc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c
> index 0f21a8a767ac..9e4d6ce891aa 100644
> --- a/drivers/clk/qcom/gdsc.c
> +++ b/drivers/clk/qcom/gdsc.c
> @@ -46,6 +46,7 @@
>  #define RETAIN_MEM		BIT(14)
>  #define RETAIN_PERIPH		BIT(13)
>  
> +#define STATUS_POLL_TIMEOUT_US	1500
>  #define TIMEOUT_US		500
>  
>  #define domain_to_gdsc(domain) container_of(domain, struct gdsc, pd)
> @@ -107,7 +108,7 @@ static int gdsc_poll_status(struct gdsc *sc, enum gdsc_status status)
>  	do {
>  		if (gdsc_check_status(sc, status))
>  			return 0;
> -	} while (ktime_us_delta(ktime_get(), start) < TIMEOUT_US);
> +	} while (ktime_us_delta(ktime_get(), start) < STATUS_POLL_TIMEOUT_US);
>  
>  	if (gdsc_check_status(sc, status))
>  		return 0;

  reply	other threads:[~2022-11-30 11:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 11:28 [PATCH v4 0/9] clk: qcom: Add support for SM8550 Abel Vesa
2022-11-30 11:28 ` [PATCH v4 1/9] dt-bindings: clock: Add SM8550 GCC clocks Abel Vesa
2022-11-30 11:28 ` [PATCH v4 2/9] dt-bindings: clock: Add SM8550 TCSR CC clocks Abel Vesa
2022-12-01 22:12   ` Bjorn Andersson
2022-12-02 19:19     ` Abel Vesa
2022-11-30 11:28 ` [PATCH v4 3/9] clk: qcom: gdsc: Increase status poll timeout Abel Vesa
2022-11-30 11:30   ` Konrad Dybcio [this message]
2022-11-30 11:28 ` [PATCH v4 4/9] clk: qcom: Add LUCID_OLE PLL type for SM8550 Abel Vesa
2022-11-30 11:28 ` [PATCH v4 5/9] clk: qcom: Add GCC driver " Abel Vesa
2022-11-30 11:28 ` [PATCH v4 6/9] dt-bindings: clock: Add RPMHCC " Abel Vesa
2022-11-30 11:28 ` [PATCH v4 7/9] dt-bindings: clock: qcom,rpmh: Add CXO PAD clock IDs Abel Vesa
2022-11-30 11:28 ` [PATCH v4 8/9] clk: qcom: rpmh: Add support for SM8550 rpmh clocks Abel Vesa
2022-11-30 11:45   ` Dmitry Baryshkov
2022-11-30 11:59     ` Dmitry Baryshkov
2022-12-06 10:52       ` Abel Vesa
2022-12-06 10:42     ` Abel Vesa
2022-11-30 11:28 ` [PATCH v4 9/9] clk: qcom: Add TCSR clock driver for SM8550 Abel Vesa
2022-12-02 20:58 ` (subset) [PATCH v4 0/9] clk: qcom: Add support " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3268c45-b97f-1eea-c0a2-752cac714397@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).