From: Krzysztof Kozlowski <krzk@kernel.org>
To: Juerg Haefliger <juerg.haefliger@canonical.com>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Create and include a dtsi
Date: Fri, 4 Apr 2025 14:51:54 +0200 [thread overview]
Message-ID: <e326a1e8-5f2e-4b1d-bb72-64f1e32038fa@kernel.org> (raw)
In-Reply-To: <20250404090108.3333211-2-juerg.haefliger@canonical.com>
On 04/04/2025 11:01, Juerg Haefliger wrote:
> Create a dtsi for the HP OmniBook so it can be reused for the HP EliteBook
> which seems to be the same HW.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
> .../dts/qcom/x1e80100-hp-omnibook-x14.dts | 1554 +---------------
> .../dts/qcom/x1e80100-hp-omnibook-x14.dtsi | 1557 +++++++++++++++++
> 2 files changed, 1558 insertions(+), 1553 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dtsi
Very difficult to review. This should have been rename. You are not
using b4, so you can tweak -M/-B/-C parameters.
I also do not understand what the DTSI represents. The DTSI files should
be some sort of common hardware, design, product. Are you sure these
devices share the design?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-04 12:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 9:01 [PATCH 0/3] HP EliteBook Ultra G1q support Juerg Haefliger
2025-04-04 9:01 ` [PATCH 1/3] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Create and include a dtsi Juerg Haefliger
2025-04-04 12:51 ` Krzysztof Kozlowski [this message]
2025-04-07 9:20 ` Juerg Haefliger
2025-04-04 15:33 ` Rob Herring
2025-04-07 9:21 ` Juerg Haefliger
2025-04-04 9:01 ` [PATCH 2/3] arm64: dts: qcom: x1e80100-hp-elitebook-ultra-g1q: DT for HP EliteBook Ultra G1q Juerg Haefliger
2025-04-04 12:53 ` Krzysztof Kozlowski
2025-04-04 9:01 ` [PATCH 3/3] dt-bindings: arm: qcom: Document " Juerg Haefliger
2025-04-04 12:48 ` Krzysztof Kozlowski
2025-04-08 14:52 ` [PATCH v2 0/3] HP EliteBook Ultra G1q support Juerg Haefliger
2025-04-08 14:52 ` [PATCH v2 1/3] arm64: dts: qcom: x1e80100-hp-omnibook-x14: add sound label and pull out the model Juerg Haefliger
2025-04-10 5:17 ` Maud Spierings
2025-04-10 5:37 ` Maud Spierings
2025-04-08 14:52 ` [PATCH v2 2/3] dt-bindings: arm: qcom: Document HP EliteBook Ultra G1q Juerg Haefliger
2025-04-08 17:48 ` Rob Herring (Arm)
2025-04-08 14:52 ` [PATCH v2 3/3] arm64: dts: qcom: x1e80100-hp-elitebook-ultra-g1q: DT for " Juerg Haefliger
2025-04-10 5:34 ` Maud Spierings
2025-04-10 16:41 ` Konrad Dybcio
2025-04-11 11:05 ` Johan Hovold
2025-04-09 14:14 ` [PATCH v2 0/3] HP EliteBook Ultra G1q support Rob Herring (Arm)
2025-04-16 9:42 ` [PATCH v3 " Juerg Haefliger
2025-04-16 9:42 ` [PATCH v3 1/3] arm64: dts: qcom: x1e80100-hp-omnibook-x14: add sound label and pull out the model Juerg Haefliger
2025-04-25 19:44 ` Dmitry Baryshkov
2025-04-26 7:45 ` Juerg Haefliger
2025-04-26 8:08 ` Dmitry Baryshkov
2025-04-16 9:42 ` [PATCH v3 2/3] dt-bindings: arm: qcom: Document HP EliteBook Ultra G1q Juerg Haefliger
2025-04-16 9:42 ` [PATCH v3 3/3] arm64: dts: qcom: x1e80100-hp-elitebook-ultra-g1q: DT for " Juerg Haefliger
2025-04-25 19:45 ` Dmitry Baryshkov
2025-04-16 12:43 ` [PATCH v3 0/3] HP EliteBook Ultra G1q support Rob Herring (Arm)
2025-04-29 14:49 ` [PATCH v4 0/4] " Juerg Haefliger
2025-04-29 14:49 ` [PATCH v4 1/4] arm64: dts: qcom: x1e80100-hp-omnibook-x14: add sound label Juerg Haefliger
2025-04-29 14:49 ` [PATCH v4 2/4] dt-bindings: arm: qcom: Document HP EliteBook Ultra G1q Juerg Haefliger
2025-04-29 14:49 ` [PATCH v4 3/4] arm64: dts: qcom: x1e80100-hp-elitebook-ultra-g1q: DT for " Juerg Haefliger
2025-04-29 14:49 ` [PATCH v4 4/4] firmware: qcom: scm: Allow QSEECOM " Juerg Haefliger
2025-05-14 21:03 ` (subset) [PATCH v4 0/4] HP EliteBook Ultra G1q support Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e326a1e8-5f2e-4b1d-bb72-64f1e32038fa@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=juerg.haefliger@canonical.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).