From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AD4C433E0 for ; Wed, 10 Feb 2021 07:00:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D21DB64E57 for ; Wed, 10 Feb 2021 07:00:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231537AbhBJG7x (ORCPT ); Wed, 10 Feb 2021 01:59:53 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:3074 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231841AbhBJG7o (ORCPT ); Wed, 10 Feb 2021 01:59:44 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 09 Feb 2021 22:59:03 -0800 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 10 Feb 2021 06:59:02 +0000 Received: from [10.25.99.168] (172.20.145.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 10 Feb 2021 06:58:57 +0000 Subject: Re: Re: [PATCH v2 1/9] ASoC: dt-bindings: rt5659: Update binding doc To: Thierry Reding CC: Rob Herring , , , , , , , , , Oder Chiou , Bard Liao References: <1611944866-29373-1-git-send-email-spujar@nvidia.com> <1611944866-29373-2-git-send-email-spujar@nvidia.com> <20210205152933.GA3089668@robh.at.kernel.org> From: Sameer Pujar Message-ID: Date: Wed, 10 Feb 2021 12:28:53 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To DRHQMAIL107.nvidia.com (10.27.9.16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612940343; bh=7yrhYOs91UiuNjgRtR9OoL0rm9nKEiCtcwwaAr+kPyU=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=DLPHblKcUPz5LIi6RZ4luT7p0nXHB9E5zZ5rznJdfK21hdskQHNXHS1hqPxp548HT EROhRygrhadbwWF5xrTmfu0og2FgaCAHT3H9tACOMcIJZlt4h+Xg6wtWnm8DWBkxOj LI5KH5zicct9QycE5C65zGgoKp3nXcFQ1f1bpvGaBIST5DlYH1Mgc08CTpYf5vNV9C OpR9otAQ24fXvxFceyh3mvqdBYc+XHVMkwyUpFtHkgEC7jsdhGzOGY2gBvrL5Tc5H2 IPUiZPTH9U7nFy5gVkx9zncycaqnuKCpuY54G+Jdt+ExVuNqMpDQKigqbP9NsEtp9A D7oOSFJRmLrNw== Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2/10/2021 12:49 AM, Thierry Reding wrote: > On Tue, Feb 09, 2021 at 06:51:58PM +0530, Sameer Pujar wrote: >> Hi Rob, >> >> On 2/5/2021 8:59 PM, Rob Herring wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> On Fri, Jan 29, 2021 at 11:57:38PM +0530, Sameer Pujar wrote: >>>> Update following in rt5659.txt binding doc >>>> - Add JD source for Intel HDA header: Commit 041e74b71491 >>>> ("ASoC: rt5659: Add the support of Intel HDA Header") >>>> added driver support. Add missing info here. >>>> >>>> - sound-name-prefix: Used to prefix component widgets/kcontrols >>>> with given prefix. >>>> >>>> - ports: Helps to use the Codec with audio graph card >>>> >>>> Signed-off-by: Sameer Pujar >>>> Reported-by: Jon Hunter >>>> Cc: Oder Chiou >>>> Cc: Bard Liao >>>> --- >>>> Documentation/devicetree/bindings/sound/rt5659.txt | 11 +++++++++++ >>>> 1 file changed, 11 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/sound/rt5659.txt b/Documentation/devicetree/bindings/sound/rt5659.txt >>>> index 56788f5..c473df5 100644 >>>> --- a/Documentation/devicetree/bindings/sound/rt5659.txt >>>> +++ b/Documentation/devicetree/bindings/sound/rt5659.txt >>>> @@ -37,10 +37,21 @@ Optional properties: >>>> - realtek,jd-src >>>> 0: No JD is used >>>> 1: using JD3 as JD source >>>> + 2: JD source for Intel HDA header >>>> >>>> - realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin. >>>> - realtek,reset-gpios : The GPIO that controls the CODEC's RESET pin. >>>> >>>> +- sound-name-prefix: Please refer to name-prefix.txt >>>> + >>>> +- ports: A Codec may have a single or multiple I2S interfaces. These >>>> + interfaces on Codec side can be described under 'ports' or 'port'. >>>> + When the SoC or host device is connected to multiple interfaces of >>>> + the Codec, the connectivity can be described using 'ports' property. >>>> + If a single interface is used, then 'port' can be used. The usage >>>> + depends on the platform or board design. >>>> + Please refer to Documentation/devicetree/bindings/graph.txt >>> Please read what that file says now. >> Sorry, I did not understand above comment. Can you please elaborate a bit >> more? > I think what Rob meant to point out is that graph.txt now contains a > mention that the file has been moved to a more central location, which > is the dt-schema repository. So instead of referencing the graph.txt, > which then redirects to the graph.yaml in dt-schema, it'd be better to > directly reference graph.yaml from dt-schema. > > That said, I'm not aware of a good or standard way to make such a > reference. Perhaps in this case, given that the rt5659 binding is not > very large, you can convert the file to json-schema first and then use > standard json-schema references for this. OK, in that case I will try convert this binding to json-schema in a separate patch. Thanks.