From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Macpaul Lin <macpaul.lin@mediatek.com>
Subject: Re: [PATCH 1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch
Date: Sat, 25 Nov 2023 11:37:54 +0100 [thread overview]
Message-ID: <e34c2746-8e93-48b8-9c96-690242fbf6e9@linaro.org> (raw)
In-Reply-To: <20231125012303.760-1-chunfeng.yun@mediatek.com>
On 25/11/2023 02:23, Chunfeng Yun wrote:
> Due to some old SoCs with shared t-phy only support force-mode switch, and
> can't use compatible to distinguish between shared and non-shared t-phy,
> add a property to supported it.
> But now prefer to use "mediatek,syscon-type" on new SoC as far as possible.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index 2bb91542e984..eedba5b7025e 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -235,6 +235,12 @@ patternProperties:
> Specify the flag to enable BC1.2 if support it
> type: boolean
>
> + mediatek,force-mode:
> + description:
> + Use force mode to switch shared phy mode, perfer to use the bellow
I still do not understand what is the "force mode" you want to use. What
modes do you have? What are the characteristics of force mode?
Also, please run spellcheck.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-25 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 1:23 [PATCH 1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch Chunfeng Yun
2023-11-25 1:23 ` [PATCH 2/2] phy: mediatek: tphy: add support force phy mode switch Chunfeng Yun
2023-11-25 10:37 ` Krzysztof Kozlowski [this message]
2023-11-27 7:09 ` [PATCH 1/2] dt-bindings: phy: mediatek: tphy: add a property for force-mode switch Macpaul Lin
2023-11-27 7:21 ` Krzysztof Kozlowski
2023-11-27 13:37 ` AngeloGioacchino Del Regno
2023-11-30 2:00 ` Chunfeng Yun (云春峰)
2023-11-30 1:51 ` Chunfeng Yun (云春峰)
2023-11-30 8:03 ` Krzysztof Kozlowski
2023-12-10 9:09 ` Chunfeng Yun (云春峰)
2023-11-30 2:28 ` Chunfeng Yun (云春峰)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e34c2746-8e93-48b8-9c96-690242fbf6e9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).