* [PATCH v5 1/3] dt-bindings: media: add qcom,msm8998-venus
2024-06-04 16:41 [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
@ 2024-06-04 16:42 ` Marc Gonzalez
2024-06-04 16:43 ` [PATCH v5 2/3] media: venus: add msm8998 support Marc Gonzalez
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2024-06-04 16:42 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: MSM, linux-media, DT, Pierre-Hugues Husson, Arnaud Vrac,
Jeffrey Hugo, Bjorn Andersson, Konrad Dybcio, Bryan O Donoghue,
Stanimir Varbanov, Vikash Garodia
msm8998 has the same video encode/decode accelerator as msm8996.
Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
index 3a4d817e544e2..56c16458e3bb4 100644
--- a/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
@@ -18,7 +18,9 @@ allOf:
properties:
compatible:
- const: qcom,msm8996-venus
+ enum:
+ - qcom,msm8996-venus
+ - qcom,msm8998-venus
power-domains:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v5 2/3] media: venus: add msm8998 support
2024-06-04 16:41 [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
2024-06-04 16:42 ` [PATCH v5 1/3] dt-bindings: media: add qcom,msm8998-venus Marc Gonzalez
@ 2024-06-04 16:43 ` Marc Gonzalez
2024-06-06 3:05 ` Bjorn Andersson
2024-06-04 16:44 ` [PATCH v5 3/3] arm64: dts: qcom: msm8998: add venus node Marc Gonzalez
` (3 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Marc Gonzalez @ 2024-06-04 16:43 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: MSM, linux-media, DT, Pierre-Hugues Husson, Arnaud Vrac,
Jeffrey Hugo, Bjorn Andersson, Konrad Dybcio, Bryan O Donoghue,
Stanimir Varbanov, Vikash Garodia
From: Pierre-Hugues Husson <phhusson@freebox.fr>
Add the missing bits for msm8998 support.
Downstream vendor code for reference:
https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/arch/arm/boot/dts/qcom/msm8998-vidc.dtsi#L42-53
qcom,load-freq-tbl =
/* Encoders */
<972000 465000000 0x55555555>, /* 4k UHD @ 30 */
<489600 360000000 0x55555555>, /* 1080p @ 60 */
<244800 186000000 0x55555555>, /* 1080p @ 30 */
<108000 100000000 0x55555555>, /* 720p @ 30 */
/* Decoders */
<1944000 465000000 0xffffffff>, /* 4k UHD @ 60 */
< 972000 360000000 0xffffffff>, /* 4k UHD @ 30 */
< 489600 186000000 0xffffffff>, /* 1080p @ 60 */
< 244800 100000000 0xffffffff>; /* 1080p @ 30 */
Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
---
drivers/media/platform/qcom/venus/core.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index ce206b7097541..8b715cb7ab51a 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -587,6 +587,44 @@ static const struct venus_resources msm8996_res = {
.fwname = "qcom/venus-4.2/venus.mbn",
};
+static const struct freq_tbl msm8998_freq_table[] = {
+ { 1944000, 465000000 }, /* 4k UHD @ 60 (decode only) */
+ { 972000, 465000000 }, /* 4k UHD @ 30 */
+ { 489600, 360000000 }, /* 1080p @ 60 */
+ { 244800, 186000000 }, /* 1080p @ 30 */
+ { 108000, 100000000 }, /* 720p @ 30 */
+};
+
+static const struct reg_val msm8998_reg_preset[] = {
+ { 0x80124, 0x00000003 },
+ { 0x80550, 0x01111111 },
+ { 0x80560, 0x01111111 },
+ { 0x80568, 0x01111111 },
+ { 0x80570, 0x01111111 },
+ { 0x80580, 0x01111111 },
+ { 0x80588, 0x01111111 },
+ { 0xe2010, 0x00000000 },
+};
+
+static const struct venus_resources msm8998_res = {
+ .freq_tbl = msm8998_freq_table,
+ .freq_tbl_size = ARRAY_SIZE(msm8998_freq_table),
+ .reg_tbl = msm8998_reg_preset,
+ .reg_tbl_size = ARRAY_SIZE(msm8998_reg_preset),
+ .clks = { "core", "iface", "bus", "mbus" },
+ .clks_num = 4,
+ .vcodec0_clks = { "core" },
+ .vcodec1_clks = { "core" },
+ .vcodec_clks_num = 1,
+ .max_load = 2563200,
+ .hfi_version = HFI_VERSION_3XX,
+ .vmem_id = VIDC_RESOURCE_NONE,
+ .vmem_size = 0,
+ .vmem_addr = 0,
+ .dma_mask = 0xddc00000 - 1,
+ .fwname = "qcom/venus-4.4/venus.mbn",
+};
+
static const struct freq_tbl sdm660_freq_table[] = {
{ 979200, 518400000 },
{ 489600, 441600000 },
@@ -893,6 +931,7 @@ static const struct venus_resources sc7280_res = {
static const struct of_device_id venus_dt_match[] = {
{ .compatible = "qcom,msm8916-venus", .data = &msm8916_res, },
{ .compatible = "qcom,msm8996-venus", .data = &msm8996_res, },
+ { .compatible = "qcom,msm8998-venus", .data = &msm8998_res, },
{ .compatible = "qcom,sdm660-venus", .data = &sdm660_res, },
{ .compatible = "qcom,sdm845-venus", .data = &sdm845_res, },
{ .compatible = "qcom,sdm845-venus-v2", .data = &sdm845_res_v2, },
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v5 2/3] media: venus: add msm8998 support
2024-06-04 16:43 ` [PATCH v5 2/3] media: venus: add msm8998 support Marc Gonzalez
@ 2024-06-06 3:05 ` Bjorn Andersson
2024-06-30 15:07 ` Marc Gonzalez
0 siblings, 1 reply; 11+ messages in thread
From: Bjorn Andersson @ 2024-06-06 3:05 UTC (permalink / raw)
To: Marc Gonzalez, Mauro Carvalho Chehab
Cc: MSM, linux-media, DT, Pierre-Hugues Husson, Arnaud Vrac,
Jeffrey Hugo, Konrad Dybcio, Bryan O Donoghue, Stanimir Varbanov,
Vikash Garodia
On Tue, Jun 04, 2024 at 06:43:07PM GMT, Marc Gonzalez wrote:
> From: Pierre-Hugues Husson <phhusson@freebox.fr>
>
> Add the missing bits for msm8998 support.
>
> Downstream vendor code for reference:
>
> https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/arch/arm/boot/dts/qcom/msm8998-vidc.dtsi#L42-53
>
> qcom,load-freq-tbl =
> /* Encoders */
> <972000 465000000 0x55555555>, /* 4k UHD @ 30 */
> <489600 360000000 0x55555555>, /* 1080p @ 60 */
> <244800 186000000 0x55555555>, /* 1080p @ 30 */
> <108000 100000000 0x55555555>, /* 720p @ 30 */
> /* Decoders */
> <1944000 465000000 0xffffffff>, /* 4k UHD @ 60 */
> < 972000 360000000 0xffffffff>, /* 4k UHD @ 30 */
> < 489600 186000000 0xffffffff>, /* 1080p @ 60 */
> < 244800 100000000 0xffffffff>; /* 1080p @ 30 */
>
> Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Mauro, please merge the first two patches through your tree, and I can
merge the dts patch (patch 3/3) through the qcom-tree.
Thanks,
Bjorn
> ---
> drivers/media/platform/qcom/venus/core.c | 39 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index ce206b7097541..8b715cb7ab51a 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -587,6 +587,44 @@ static const struct venus_resources msm8996_res = {
> .fwname = "qcom/venus-4.2/venus.mbn",
> };
>
> +static const struct freq_tbl msm8998_freq_table[] = {
> + { 1944000, 465000000 }, /* 4k UHD @ 60 (decode only) */
> + { 972000, 465000000 }, /* 4k UHD @ 30 */
> + { 489600, 360000000 }, /* 1080p @ 60 */
> + { 244800, 186000000 }, /* 1080p @ 30 */
> + { 108000, 100000000 }, /* 720p @ 30 */
> +};
> +
> +static const struct reg_val msm8998_reg_preset[] = {
> + { 0x80124, 0x00000003 },
> + { 0x80550, 0x01111111 },
> + { 0x80560, 0x01111111 },
> + { 0x80568, 0x01111111 },
> + { 0x80570, 0x01111111 },
> + { 0x80580, 0x01111111 },
> + { 0x80588, 0x01111111 },
> + { 0xe2010, 0x00000000 },
> +};
> +
> +static const struct venus_resources msm8998_res = {
> + .freq_tbl = msm8998_freq_table,
> + .freq_tbl_size = ARRAY_SIZE(msm8998_freq_table),
> + .reg_tbl = msm8998_reg_preset,
> + .reg_tbl_size = ARRAY_SIZE(msm8998_reg_preset),
> + .clks = { "core", "iface", "bus", "mbus" },
> + .clks_num = 4,
> + .vcodec0_clks = { "core" },
> + .vcodec1_clks = { "core" },
> + .vcodec_clks_num = 1,
> + .max_load = 2563200,
> + .hfi_version = HFI_VERSION_3XX,
> + .vmem_id = VIDC_RESOURCE_NONE,
> + .vmem_size = 0,
> + .vmem_addr = 0,
> + .dma_mask = 0xddc00000 - 1,
> + .fwname = "qcom/venus-4.4/venus.mbn",
> +};
> +
> static const struct freq_tbl sdm660_freq_table[] = {
> { 979200, 518400000 },
> { 489600, 441600000 },
> @@ -893,6 +931,7 @@ static const struct venus_resources sc7280_res = {
> static const struct of_device_id venus_dt_match[] = {
> { .compatible = "qcom,msm8916-venus", .data = &msm8916_res, },
> { .compatible = "qcom,msm8996-venus", .data = &msm8996_res, },
> + { .compatible = "qcom,msm8998-venus", .data = &msm8998_res, },
> { .compatible = "qcom,sdm660-venus", .data = &sdm660_res, },
> { .compatible = "qcom,sdm845-venus", .data = &sdm845_res, },
> { .compatible = "qcom,sdm845-venus-v2", .data = &sdm845_res_v2, },
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v5 2/3] media: venus: add msm8998 support
2024-06-06 3:05 ` Bjorn Andersson
@ 2024-06-30 15:07 ` Marc Gonzalez
0 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2024-06-30 15:07 UTC (permalink / raw)
To: Bjorn Andersson
Cc: MSM, linux-media, DT, Mauro Carvalho Chehab, Pierre-Hugues Husson,
Arnaud Vrac, Jeffrey Hugo, Konrad Dybcio, Bryan O Donoghue,
Stanimir Varbanov, Vikash Garodia
On 06/06/2024 05:05, Bjorn Andersson wrote:
> Mauro, please merge the first two patches through your tree, and I can
> merge the dts patch (patch 3/3) through the qcom-tree.
Hello Bjorn,
Hans has accepted patches 1 & 2:
https://patchwork.linuxtv.org/project/linux-media/patch/2db42e45-c034-43be-be96-0e88511d1878@freebox.fr/
https://patchwork.linuxtv.org/project/linux-media/patch/eb15a48b-6185-42dd-92ca-8df33b0ea4b5@freebox.fr/
(Thanks Stanimir & Hans)
It's probably safe to merge patch 3 now?
Regards
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v5 3/3] arm64: dts: qcom: msm8998: add venus node
2024-06-04 16:41 [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
2024-06-04 16:42 ` [PATCH v5 1/3] dt-bindings: media: add qcom,msm8998-venus Marc Gonzalez
2024-06-04 16:43 ` [PATCH v5 2/3] media: venus: add msm8998 support Marc Gonzalez
@ 2024-06-04 16:44 ` Marc Gonzalez
2024-06-17 13:36 ` [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2024-06-04 16:44 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: MSM, linux-media, DT, Pierre-Hugues Husson, Arnaud Vrac,
Jeffrey Hugo, Bjorn Andersson, Konrad Dybcio, Bryan O Donoghue,
Stanimir Varbanov, Vikash Garodia
From: Pierre-Hugues Husson <phhusson@freebox.fr>
Now that the venus clocks are fixed, we can add the DT node.
Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
---
arch/arm64/boot/dts/qcom/msm8998.dtsi | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 6e286f91241be..f65a76da61ea8 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -3145,6 +3145,54 @@ hdmi_phy: hdmi-phy@c9a0600 {
};
};
+ venus: video-codec@cc00000 {
+ compatible = "qcom,msm8998-venus";
+ reg = <0x0cc00000 0xff000>;
+ interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&mmcc VIDEO_TOP_GDSC>;
+ clocks = <&mmcc VIDEO_CORE_CLK>,
+ <&mmcc VIDEO_AHB_CLK>,
+ <&mmcc VIDEO_AXI_CLK>,
+ <&mmcc VIDEO_MAXI_CLK>;
+ clock-names = "core", "iface", "bus", "mbus";
+ iommus = <&mmss_smmu 0x400>,
+ <&mmss_smmu 0x401>,
+ <&mmss_smmu 0x40a>,
+ <&mmss_smmu 0x407>,
+ <&mmss_smmu 0x40e>,
+ <&mmss_smmu 0x40f>,
+ <&mmss_smmu 0x408>,
+ <&mmss_smmu 0x409>,
+ <&mmss_smmu 0x40b>,
+ <&mmss_smmu 0x40c>,
+ <&mmss_smmu 0x40d>,
+ <&mmss_smmu 0x410>,
+ <&mmss_smmu 0x421>,
+ <&mmss_smmu 0x428>,
+ <&mmss_smmu 0x429>,
+ <&mmss_smmu 0x42b>,
+ <&mmss_smmu 0x42c>,
+ <&mmss_smmu 0x42d>,
+ <&mmss_smmu 0x411>,
+ <&mmss_smmu 0x431>;
+ memory-region = <&venus_mem>;
+ status = "disabled";
+
+ video-decoder {
+ compatible = "venus-decoder";
+ clocks = <&mmcc VIDEO_SUBCORE0_CLK>;
+ clock-names = "core";
+ power-domains = <&mmcc VIDEO_SUBCORE0_GDSC>;
+ };
+
+ video-encoder {
+ compatible = "venus-encoder";
+ clocks = <&mmcc VIDEO_SUBCORE1_CLK>;
+ clock-names = "core";
+ power-domains = <&mmcc VIDEO_SUBCORE1_GDSC>;
+ };
+ };
+
mmss_smmu: iommu@cd00000 {
compatible = "qcom,msm8998-smmu-v2", "qcom,smmu-v2";
reg = <0x0cd00000 0x40000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc)
2024-06-04 16:41 [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
` (2 preceding siblings ...)
2024-06-04 16:44 ` [PATCH v5 3/3] arm64: dts: qcom: msm8998: add venus node Marc Gonzalez
@ 2024-06-17 13:36 ` Marc Gonzalez
2024-06-27 16:41 ` Marc Gonzalez
2024-07-03 3:37 ` (subset) " Bjorn Andersson
2024-07-04 11:39 ` Marc Gonzalez
5 siblings, 1 reply; 11+ messages in thread
From: Marc Gonzalez @ 2024-06-17 13:36 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: MSM, linux-media, DT, Pierre-Hugues Husson, Arnaud Vrac,
Jeffrey Hugo, Bjorn Andersson, Konrad Dybcio, Bryan O Donoghue,
Stanimir Varbanov, Vikash Garodia
Hello Mauro,
Can you merge patches 1 & 2 in time for 6.11 ?
Regards
On 04/06/2024 18:41, Marc Gonzalez wrote:
> Changes in v5
> - Collect latest Acks (from Vikash)
> - Resend to Mauro
>
> Marc Gonzalez (1):
> dt-bindings: media: add qcom,msm8998-venus
>
> Pierre-Hugues Husson (2):
> arm64: dts: qcom: msm8998: add venus node
> media: venus: add msm8998 support
>
> Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml | 4 ++-
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 48 +++++++++++++++++++++++++++++
> drivers/media/platform/qcom/venus/core.c | 39 +++++++++++++++++++++++
> 3 files changed, 90 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc)
2024-06-17 13:36 ` [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
@ 2024-06-27 16:41 ` Marc Gonzalez
0 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2024-06-27 16:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Stanimir Varbanov
Cc: linux-media, MSM, DT, Pierre-Hugues Husson, Arnaud Vrac,
Jeffrey Hugo, Bjorn Andersson, Konrad Dybcio, Bryan O Donoghue,
Vikash Garodia
Hello,
It is still unclear to me exactly who is expected to merge patches 1 and 2.
In patchwork, patch 2 is marked as "Delegated to: Stanimir Varbanov"
https://patchwork.linuxtv.org/project/linux-media/patch/eb15a48b-6185-42dd-92ca-8df33b0ea4b5@freebox.fr/
Stanimir are you supposed to Ack? Review? Merge? None of the above?
Regards
On 17/06/2024 15:36, Marc Gonzalez wrote:
> Hello Mauro,
>
> Can you merge patches 1 & 2 in time for 6.11 ?
>
> Regards
>
>
> On 04/06/2024 18:41, Marc Gonzalez wrote:
>
>> Changes in v5
>> - Collect latest Acks (from Vikash)
>> - Resend to Mauro
>>
>> Marc Gonzalez (1):
>> dt-bindings: media: add qcom,msm8998-venus
>>
>> Pierre-Hugues Husson (2):
>> arm64: dts: qcom: msm8998: add venus node
>> media: venus: add msm8998 support
>>
>> Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml | 4 ++-
>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 48 +++++++++++++++++++++++++++++
>> drivers/media/platform/qcom/venus/core.c | 39 +++++++++++++++++++++++
>> 3 files changed, 90 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc)
2024-06-04 16:41 [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
` (3 preceding siblings ...)
2024-06-17 13:36 ` [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
@ 2024-07-03 3:37 ` Bjorn Andersson
2024-07-04 11:39 ` Marc Gonzalez
5 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2024-07-03 3:37 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Marc Gonzalez
Cc: MSM, linux-media, DT, Pierre-Hugues Husson, Arnaud Vrac,
Jeffrey Hugo, Konrad Dybcio, Bryan O Donoghue, Stanimir Varbanov,
Vikash Garodia
On Tue, 04 Jun 2024 18:41:04 +0200, Marc Gonzalez wrote:
> Changes in v5
> - Collect latest Acks (from Vikash)
> - Resend to Mauro
>
> Marc Gonzalez (1):
> dt-bindings: media: add qcom,msm8998-venus
>
> [...]
Applied, thanks!
[3/3] arm64: dts: qcom: msm8998: add venus node
commit: 1c6285e10d76b0cfb5b0384dc9c02e266a2ffd0a
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc)
2024-06-04 16:41 [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
` (4 preceding siblings ...)
2024-07-03 3:37 ` (subset) " Bjorn Andersson
@ 2024-07-04 11:39 ` Marc Gonzalez
2024-07-04 11:58 ` Hans Verkuil
5 siblings, 1 reply; 11+ messages in thread
From: Marc Gonzalez @ 2024-07-04 11:39 UTC (permalink / raw)
To: Hans Verkuil, Stanimir Varbanov, Mauro Carvalho Chehab
Cc: MSM, linux-media, DT, Pierre-Hugues Husson, Arnaud Vrac,
Jeffrey Hugo, Bjorn Andersson, Konrad Dybcio, Bryan O Donoghue,
Vikash Garodia
On 04/06/2024 18:41, Marc Gonzalez wrote:
> Changes in v5
> - Collect latest Acks (from Vikash)
> - Resend to Mauro
>
> Marc Gonzalez (1):
> dt-bindings: media: add qcom,msm8998-venus
>
> Pierre-Hugues Husson (2):
> arm64: dts: qcom: msm8998: add venus node
> media: venus: add msm8998 support
>
> Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml | 4 ++-
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 48 +++++++++++++++++++++++++++++
> drivers/media/platform/qcom/venus/core.c | 39 +++++++++++++++++++++++
> 3 files changed, 90 insertions(+), 1 deletion(-)
Hello Hans,
I got an email stating:
The following patches (submitted by you) have been updated in Patchwork:
* linux-media: [v5,1/3] dt-bindings: media: add qcom,msm8998-venus
- http://patchwork.linuxtv.org/project/linux-media/patch/2db42e45-c034-43be-be96-0e88511d1878@freebox.fr/
- for: Linux Media kernel patches
was: New
now: Accepted
* linux-media: [v5,2/3] media: venus: add msm8998 support
- http://patchwork.linuxtv.org/project/linux-media/patch/eb15a48b-6185-42dd-92ca-8df33b0ea4b5@freebox.fr/
- for: Linux Media kernel patches
was: New
now: Accepted
Yet, I've gotten a warning from kernel test robot <lkp@intel.com> stating:
arch/arm64/boot/dts/qcom/msm8998-mtp.dtb: /soc@0/video-codec@cc00000: failed to match any schema with compatible: ['qcom,msm8998-venus']
Is this because the patches are not merged in linux-next?
Will they be merged in v6.11 ?
Regards
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v5 0/3] Add support for qcom msm8998-venus (HW vdec / venc)
2024-07-04 11:39 ` Marc Gonzalez
@ 2024-07-04 11:58 ` Hans Verkuil
0 siblings, 0 replies; 11+ messages in thread
From: Hans Verkuil @ 2024-07-04 11:58 UTC (permalink / raw)
To: Marc Gonzalez, Stanimir Varbanov, Mauro Carvalho Chehab
Cc: MSM, linux-media, DT, Pierre-Hugues Husson, Arnaud Vrac,
Jeffrey Hugo, Bjorn Andersson, Konrad Dybcio, Bryan O Donoghue,
Vikash Garodia
On 04/07/2024 13:39, Marc Gonzalez wrote:
> On 04/06/2024 18:41, Marc Gonzalez wrote:
>
>> Changes in v5
>> - Collect latest Acks (from Vikash)
>> - Resend to Mauro
>>
>> Marc Gonzalez (1):
>> dt-bindings: media: add qcom,msm8998-venus
>>
>> Pierre-Hugues Husson (2):
>> arm64: dts: qcom: msm8998: add venus node
>> media: venus: add msm8998 support
>>
>> Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml | 4 ++-
>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 48 +++++++++++++++++++++++++++++
>> drivers/media/platform/qcom/venus/core.c | 39 +++++++++++++++++++++++
>> 3 files changed, 90 insertions(+), 1 deletion(-)
>
> Hello Hans,
>
> I got an email stating:
>
> The following patches (submitted by you) have been updated in Patchwork:
>
> * linux-media: [v5,1/3] dt-bindings: media: add qcom,msm8998-venus
> - http://patchwork.linuxtv.org/project/linux-media/patch/2db42e45-c034-43be-be96-0e88511d1878@freebox.fr/
> - for: Linux Media kernel patches
> was: New
> now: Accepted
>
> * linux-media: [v5,2/3] media: venus: add msm8998 support
> - http://patchwork.linuxtv.org/project/linux-media/patch/eb15a48b-6185-42dd-92ca-8df33b0ea4b5@freebox.fr/
> - for: Linux Media kernel patches
> was: New
> now: Accepted
>
>
> Yet, I've gotten a warning from kernel test robot <lkp@intel.com> stating:
>
> arch/arm64/boot/dts/qcom/msm8998-mtp.dtb: /soc@0/video-codec@cc00000: failed to match any schema with compatible: ['qcom,msm8998-venus']
>
>
> Is this because the patches are not merged in linux-next?
Almost certainly, yes. I don't see them in linux-next.
>
> Will they be merged in v6.11 ?
They are in our staging tree for v6.11. So yes :-)
Regards,
Hans
>
> Regards
>
^ permalink raw reply [flat|nested] 11+ messages in thread