devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "André Draszik" <andre.draszik@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Lee Jones <lee@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski	 <brgl@bgdev.pl>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Peter Griffin	 <peter.griffin@linaro.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Will McVicker <willmcvicker@google.com>,
	kernel-team@android.com, linux-kernel@vger.kernel.org,
		devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
		linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 3/6] dt-bindings: mfd: add max77759 binding
Date: Fri, 28 Feb 2025 13:59:26 +0000	[thread overview]
Message-ID: <e355ce38815760e69f40ec6d9d27fb6cab8f9894.camel@linaro.org> (raw)
In-Reply-To: <CAL_JsqK-_rPZqt_vRv75dSWDLUAyZ-LB=qz5J=Kse=7bO4q8sA@mail.gmail.com>

On Fri, 2025-02-28 at 07:01 -0600, Rob Herring wrote:
> On Thu, Feb 27, 2025 at 7:14 AM André Draszik <andre.draszik@linaro.org> wrote:
> > 
> > On Thu, 2025-02-27 at 07:04 -0600, Rob Herring wrote:
> > >
> > > 
> > > Why do you have GPIO properties here and in the child node? Either would
> > > be valid, but both probably not. Putting them here is actually
> > > preferred.
> > 
> > That's an oversight, I meant to put them into the child only, not here,
> > since the child is the one providing the gpio functionality.
> > 
> > What's the reason to have it preferred inside this parent node?
> 
> It really depends whether the GPIO block is a separate sub-block which
> is going to get reused or has its own resources or not. It's the same
> thing in system controllers which are often just a collection of
> leftover control bits.
> 
> We just don't want child nodes created just for the ease of
> instantiating drivers in Linux. While it's nice if drivers and nodes
> are 1 to 1, but that's specific to an OS.
> 
> You already need other child nodes here, so I don't care too much in this case.

Thanks Rob for taking the time and for the explanation! I'll keep
that in mind for the future.

Cheers,
Andre'



  reply	other threads:[~2025-02-28 13:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 17:51 [PATCH v2 0/6] Maxim Integrated MAX77759 PMIC MFD-based drivers André Draszik
2025-02-26 17:51 ` [PATCH v2 1/6] dt-bindings: gpio: add max77759 binding André Draszik
2025-02-26 20:30   ` Rob Herring (Arm)
2025-02-27 11:19     ` André Draszik
2025-02-27 12:51       ` Rob Herring
2025-02-27 12:56         ` André Draszik
2025-02-27 13:01   ` Rob Herring (Arm)
2025-02-26 17:51 ` [PATCH v2 2/6] dt-bindings: nvmem: " André Draszik
2025-02-26 20:30   ` Rob Herring (Arm)
2025-02-27 13:05   ` Rob Herring (Arm)
2025-02-26 17:51 ` [PATCH v2 3/6] dt-bindings: mfd: " André Draszik
2025-02-27 13:04   ` Rob Herring
2025-02-27 13:13     ` André Draszik
2025-02-28 13:01       ` Rob Herring
2025-02-28 13:59         ` André Draszik [this message]
2025-02-26 17:51 ` [PATCH v2 4/6] mfd: max77759: add Maxim MAX77759 core mfd driver André Draszik
2025-02-26 17:51 ` [PATCH v2 5/6] gpio: max77759: add Maxim MAX77759 gpio driver André Draszik
2025-02-28  7:10   ` Linus Walleij
2025-02-28 10:58     ` André Draszik
2025-02-28 11:37       ` André Draszik
2025-02-26 17:51 ` [PATCH v2 6/6] nvmem: max77759: add Maxim MAX77759 NVMEM driver André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e355ce38815760e69f40ec6d9d27fb6cab8f9894.camel@linaro.org \
    --to=andre.draszik@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gustavoars@kernel.org \
    --cc=kees@kernel.org \
    --cc=kernel-team@android.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).