From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E54D2CA5 for ; Mon, 30 Sep 2024 01:39:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727660376; cv=none; b=XZU6NaTL2iVUO/2xsDNCYgGa9JI340uYF8EOH+Gg14/i6w3uIlWQ1Gty98QxLF/AX1skF0UL8v6K6SxFfDdtiHNM7RG+sdrdOQEG3ScfIV61dy32Zdm99TTs1hUfY/eb0n94v40u/Ow0S30o+s1mqouUiYEstucT+ySE5ltyXQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727660376; c=relaxed/simple; bh=rg3+ZaIKPQIuaIo8I9fHK/6VgqiaSpXLidc/ska4nXI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a/UZkYQVi4p3tpsN9KSUlTDmfN2ekzZdkfX2XOsNck676SujvYVdI7Ymr8KZyruUq3kQYKZ3eRqwsBYBE8CMgTTSFrXCM0o0UfN9St8VzIayTCE8Q04GDKhTWWgPiXnGpk7k6mKNIblyNfD+bNXwU0ZKDNiD+uK4eyRyHApw3Lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=IdhQP2pj; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="IdhQP2pj" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727660371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iAY7TPcfuJe9Y1D5+TkGWlwCmuxBEheRTYpfat8WovA=; b=IdhQP2pjWP8TOwERDUGjnrxKVJWNNfrPpojiK4eEJq4rjXoYmtFy5cE3tkIF57hrN+GqhN vtNtogk8G/cd35fbchHv4U5ESfEnflYTOjMUcV5K5/cFNBvFlG/gdLHFGI2kJnq2ULTuLS KSVsDnzjpZRi9tK++A5d+bVva8vKB50= Date: Mon, 30 Sep 2024 09:39:00 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 1/2] amba: Add dev_is_amba() function and export it for modules Content-Language: en-US To: "Russell King (Oracle)" , Rob Herring Cc: saravanak@google.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Andy Shevchenko References: <20240923094249.80399-1-chentao@kylinos.cn> <20240923094249.80399-2-chentao@kylinos.cn> <20240924222857.GA404805-robh@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kunwu Chan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Thanks for the reply. On 2024/9/25 06:43, Russell King (Oracle) wrote: > On Tue, Sep 24, 2024 at 05:28:57PM -0500, Rob Herring wrote: >> On Mon, Sep 23, 2024 at 05:42:47PM +0800, Kunwu Chan wrote: >>> Add dev_is_amba() function to determine >>> whether the device is a AMBA device. >>> >>> Suggested-by: Andy Shevchenko >>> Signed-off-by: Kunwu Chan >>> --- >>> drivers/amba/bus.c | 6 ++++++ >>> include/linux/amba/bus.h | 5 +++++ >>> 2 files changed, 11 insertions(+) >> Russell, Can I get an ack for this to take it with patch #2. > Would be nice to discuss "how shall we merge this cross-subsystem > patch series" first, hmm? > > The reason I didn't take patch 1 originally is because it was submitted > to me without any users, and the general principle is not to accept > patches without users. Too many times, I've merged code where there's > been a "promise" that it will be used, only to have the author go > silent and users never come along. So now, my rule is... any code that > adds something must also come with its user. > Just one user in drivers/of/platform.c right now. Actually, I don't know if dev_is_amba will use it more in the future. So we keep the usage of  "dev->bus == &platform_bus_type " too? Although here come a wrapper function "dev_is_platform". -- Thanks, Kunwu.Chan