From: Brian Dodge <bdodge09@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
daniel.thompson@linaro.org, jingoohan1@gmail.com,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
jacek.anaszewski@gmail.com, Peter Bacon <pbacon@psemi.com>,
lee.jones@linaro.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/3] backlight/arcxcnn fix vendor prefix
Date: Mon, 26 Nov 2018 19:44:14 -0500 [thread overview]
Message-ID: <e372391c-1fd5-41ec-b766-7669fffb928d@gmail.com> (raw)
In-Reply-To: <20181111113053.GF27666@amd>
Thank you Pavel, that is a good point.
The chip vendor has indicated that there is no reason to maintain the
old/improper prefix and wishes to go forward (only) with the "arctic"
prefix and any existing dts files are or will be updated.
On 11/11/18 6:30 AM, Pavel Machek wrote:
> Hi!
>
>> The vendor-prefixes.txt file properly refers to ArcticSand
>> as arctic but the driver improperly abbreviated the prefix
>> to arc. This was a mistake in the original patch
>>
>> Signed-off-by: Brian Dodge <bdodge09@gmail.com>
>> ---
>> drivers/video/backlight/arcxcnn_bl.c | 22 +++++++++++-----------
>> 1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> *
>> - * Copyright 2016 ArcticSand, Inc.
>> - * Author : Brian Dodge <bdodge@arcticsand.com>
>> + * Copyright 2018 pSemi, Inc.
>> + * Author : Brian Dodge <bdodge@psemi.com>
> Ummm. Copyright 2016-2018?
>
>> @@ -202,27 +202,27 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)
>> if (ret == 0)
>> lp->pdata->initial_brightness = prog_val;
>>
>> - ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
>> + ret = of_property_read_u32(node, "arctic,led-config-0", &prog_val);
>> if (ret == 0)
>> lp->pdata->led_config_0 = (u8)prog_val;
>>
> If there's a dts using this, you want to update it at the same
> time. You may want to support both names going forward.
> Pavel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-11-27 0:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 12:10 [PATCH 0/3] backlight/arcxcnn fix vendor prefix in driver and bindings and add support for arc1, arc3 Brian Dodge
2018-11-07 12:10 ` [PATCH 1/3] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings Brian Dodge
2018-11-12 18:42 ` Rob Herring
2018-11-07 12:10 ` [PATCH 2/3] backlight/arcxcnn fix vendor prefix Brian Dodge
2018-11-11 11:30 ` Pavel Machek
2018-11-27 0:44 ` Brian Dodge [this message]
2019-06-21 13:39 ` Daniel Thompson
2019-06-21 13:46 ` Daniel Thompson
2019-06-21 13:48 ` Daniel Thompson
2019-06-21 22:13 ` Pavel Machek
2019-06-24 10:24 ` Daniel Thompson
2019-06-24 11:29 ` Brian Dodge
2019-06-24 13:59 ` Daniel Thompson
2018-11-07 12:10 ` [PATCH 3/3] backlight/arcxcnn add support for arc1 an arc3 chip families Brian Dodge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e372391c-1fd5-41ec-b766-7669fffb928d@gmail.com \
--to=bdodge09@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=pbacon@psemi.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).